Re: [PR] SOLR-17788: Abort replication if max retries is reached to fetch a file [solr]
github-actions[bot] closed pull request #3389: SOLR-17788: Abort replication if max retries is reached to fetch a file URL: https://github.com/apache/solr/pull/3389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17788: Abort replication if max retries is reached to fetch a file [solr]
github-actions[bot] commented on PR #3389: URL: https://github.com/apache/solr/pull/3389#issuecomment-3404043602 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17788: Abort replication if max retries is reached to fetch a file [solr]
github-actions[bot] commented on PR #3389: URL: https://github.com/apache/solr/pull/3389#issuecomment-3193024086 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] SOLR-17788: Abort replication if max retries is reached to fetch a file [solr]
nilesh892003 opened a new pull request, #3389: URL: https://github.com/apache/solr/pull/3389 https://issues.apache.org/jira/browse/SOLR-17788 # Description introducing an early abort in the replication process when the maximum retry limit for fetching a file is reached. # Solution - inserts a SolrException catch block to log the abort and set an aborted flag - Rethrows the exception to stop further retries - perform fsync in finally if we have fully downloaded the index. # Tests apache solr lacks junit for entire IndexFetcher. hence made this change in custom version of Solr that we run in production to verify the fix. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
