Re: [PR] SmokeTestRelease Added support for multiple JDK (backport 9x) [solr]

2025-08-26 Thread via GitHub


janhoy merged PR #3342:
URL: https://github.com/apache/solr/pull/3342


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SmokeTestRelease Added support for multiple JDK (backport 9x) [solr]

2025-08-26 Thread via GitHub


janhoy commented on PR #3342:
URL: https://github.com/apache/solr/pull/3342#issuecomment-3223989293

   I checked jenkins and wizard, and neither use the `--test-java17` option, so 
this should be safe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SmokeTestRelease Added support for multiple JDK (backport 9x) [solr]

2025-05-27 Thread via GitHub


HoustonPutman commented on PR #3342:
URL: https://github.com/apache/solr/pull/3342#issuecomment-2913552465

   Also, as long as we update the Jenkins job and the RC testing email, I don't 
mind making back-compat breaking changes here...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SmokeTestRelease Added support for multiple JDK (backport 9x) [solr]

2025-05-27 Thread via GitHub


HoustonPutman commented on PR #3342:
URL: https://github.com/apache/solr/pull/3342#issuecomment-2913550695

   In general, this looks great to me, but I haven't run it locally


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SmokeTestRelease Added support for multiple JDK (backport 9x) [solr]

2025-05-27 Thread via GitHub


janhoy commented on PR #3342:
URL: https://github.com/apache/solr/pull/3342#issuecomment-2911896513

   Time for a review @iamsanjay , @HoustonPutman ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[PR] SmokeTestRelease Added support for multiple JDK (backport 9x) [solr]

2025-05-06 Thread via GitHub


janhoy opened a new pull request, #3342:
URL: https://github.com/apache/solr/pull/3342

   This is a backport attempt for the generalization of smokeTestRelease from 
main (#2685). Did not merge since there are still important differences between 
main and 9x that the script must preserve/respect. One such is java versions, 
another is CLI syntax for invoking Solr examples etc.
   
   (cherry picked from commit 98aa72398a095920e89e8c86d5f8c6124afa94e5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]