[jira] [Commented] (SOLR-14903) SolrCloud tests should use the jetty.xml that we ship with
[ https://issues.apache.org/jira/browse/SOLR-14903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947440#comment-17947440 ] Chris M. Hostetter commented on SOLR-14903: --- FWIW: SOLR-17744 is a great example of the type of problem/test that could really benefit from having a reliable way to run *ALL* of Solr (w/all of it's "real" jetty configuration) in the same JVM as the test. The in process concurrency Semaphores used in that test could never be replicated in a docker based test. > SolrCloud tests should use the jetty.xml that we ship with > -- > > Key: SOLR-14903 > URL: https://issues.apache.org/jira/browse/SOLR-14903 > Project: Solr > Issue Type: Improvement >Reporter: Chris M. Hostetter >Assignee: Chris M. Hostetter >Priority: Major > Attachments: SOLR-14903.patch > > > writing a good test for SOLR-14898 turned out to be a challenge because > SolrCloudTestCase -- and any test using jetty -- doesn't _actually_ use the > jetty.xml that real Solr nodes use, because JettySolrRunner manually > configures i'ts jetty "Server" instance. > We should fix this so what you get i na test matches what a real Solr node > does. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-14903) SolrCloud tests should use the jetty.xml that we ship with
[ https://issues.apache.org/jira/browse/SOLR-14903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451017#comment-17451017 ] Jan Høydahl commented on SOLR-14903: I have built Solr integration tests with Testcontainers in some customer projects, but in this project there is a chicken and egg issue, as the docker image needs to be built before the integration tests start. Also in the future, any integration tests for solr-operator would also exercise more real-life cluster configurations for Solr. > SolrCloud tests should use the jetty.xml that we ship with > -- > > Key: SOLR-14903 > URL: https://issues.apache.org/jira/browse/SOLR-14903 > Project: Solr > Issue Type: Improvement >Reporter: Chris M. Hostetter >Assignee: Chris M. Hostetter >Priority: Major > Attachments: SOLR-14903.patch > > > writing a good test for SOLR-14898 turned out to be a challenge because > SolrCloudTestCase -- and any test using jetty -- doesn't _actually_ use the > jetty.xml that real Solr nodes use, because JettySolrRunner manually > configures i'ts jetty "Server" instance. > We should fix this so what you get i na test matches what a real Solr node > does. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-14903) SolrCloud tests should use the jetty.xml that we ship with
[ https://issues.apache.org/jira/browse/SOLR-14903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450793#comment-17450793 ] David Smiley commented on SOLR-14903: - I'm not in disagreement with what's here but I think there are emergent ways of addressing the underlying motivations (pain points). Namely that's docker integration tests. Rather than try to synthesize Solr starting realistically, there's nothing like the real thing with it's bin/solr script and the rest of the configs. I know such tests are more expensive but we shouldn't have too many at this level either. > SolrCloud tests should use the jetty.xml that we ship with > -- > > Key: SOLR-14903 > URL: https://issues.apache.org/jira/browse/SOLR-14903 > Project: Solr > Issue Type: Improvement >Reporter: Chris M. Hostetter >Assignee: Chris M. Hostetter >Priority: Major > Attachments: SOLR-14903.patch > > > writing a good test for SOLR-14898 turned out to be a challenge because > SolrCloudTestCase -- and any test using jetty -- doesn't _actually_ use the > jetty.xml that real Solr nodes use, because JettySolrRunner manually > configures i'ts jetty "Server" instance. > We should fix this so what you get i na test matches what a real Solr node > does. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
