Re: [PR] SOLR-17556: Examples should run with the standard & recommended Solr home and solr data dir [solr]
epugh merged PR #2861: URL: https://github.com/apache/solr/pull/2861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17556: Examples should run with the standard & recommended Solr home and solr data dir [solr]
epugh commented on PR #2861: URL: https://github.com/apache/solr/pull/2861#issuecomment-2488570462 Feedback in corporated. When this is back ported we need to remember to remove the CREDENTIALS lookups ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17556: Examples should run with the standard & recommended Solr home and solr data dir [solr]
gerlowskija commented on code in PR #2861: URL: https://github.com/apache/solr/pull/2861#discussion_r1848626386 ## solr/CHANGES.txt: ## @@ -237,6 +237,9 @@ led to the suppression of exceptions. (Andrey Bozhko) * SOLR-17545: Upgrade to Gradle 8.10 (Houston Putman) +* SOLR-17556: Examples should run with the standard & recommended Solr home and solr data dir (except for Review Comment: [0] Minor nit - the "should" here might confuse users. Is this how Solr behaves in 9.8? Is it how it should behave? etc. Wording like `"home" and "data" directories used by Solr examples have been updated to align with documented best practices.` might be a little clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17556: Examples should run with the standard & recommended Solr home and solr data dir [solr]
HoustonPutman commented on PR #2861: URL: https://github.com/apache/solr/pull/2861#issuecomment-2474331085 I mean, this is just changing the examples. I think we can back port this. People should not be using the tech products config in production. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17556: Examples should run with the standard & recommended Solr home and solr data dir [solr]
epugh commented on PR #2861: URL: https://github.com/apache/solr/pull/2861#issuecomment-2473525638 I think stripping out the `` makes this a breaking change for 10 only??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
