Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
epugh merged PR #4278: URL: https://github.com/apache/solr/pull/4278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
epugh commented on PR #4278: URL: https://github.com/apache/solr/pull/4278#issuecomment-4615518191 I have manually tested it and it worked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
epugh commented on PR #4278: URL: https://github.com/apache/solr/pull/4278#issuecomment-453537 > > we need to redo the test! > > @epugh, should I just replace the unit tests with integration tests? Yep! Fundamentally, most tests in Solr are integration style, we don't really call them "integration", but yeah. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
utsav00 commented on PR #4278: URL: https://github.com/apache/solr/pull/4278#issuecomment-4536640665 > we need to redo the test! @epugh, should I just replace the unit tests with integration tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
utsav00 commented on code in PR #4278: URL: https://github.com/apache/solr/pull/4278#discussion_r3299651417 ## changelog/unreleased/SOLR-18066-enable-hideStackTrace.yml: ## @@ -0,0 +1,7 @@ +title: Enable hideStackTrace config Review Comment: This sounds better. Would add this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
epugh commented on PR #4278: URL: https://github.com/apache/solr/pull/4278#issuecomment-4535053946 > @epugh, thanks for retriggering the pipeline. Will keep in mind about posting in such cases. > > And would love to work on the flaky tests, is it documented/logged somewhere? Take a look at https://develocity.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=solr* and dig into the dev-docs about "beasting" tests to learn more about how we try to deal with flaky tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
epugh commented on code in PR #4278: URL: https://github.com/apache/solr/pull/4278#discussion_r3298689419 ## changelog/unreleased/SOLR-18066-enable-hideStackTrace.yml: ## @@ -0,0 +1,7 @@ +title: Enable hideStackTrace config Review Comment: Think about this from the perspective of the end user.. "V2 Api's now properly resepect hideStackTrace config setting" maybe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
utsav00 commented on PR #4278: URL: https://github.com/apache/solr/pull/4278#issuecomment-4526474934 @epugh, thanks for retriggering the pipeline. Will keep in mind about posting in such cases. And would love to work on the flaky tests, is it documented/logged somewhere? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
epugh commented on PR #4278: URL: https://github.com/apache/solr/pull/4278#issuecomment-4525227174 @igiguere if you have the ability as a contributor to put in a code review (not sure we are set up for that in our repo), that owuld be grea.t. I think your "+1" is a "yes, I like this change and therefore it can be merged"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
epugh commented on PR #4278: URL: https://github.com/apache/solr/pull/4278#issuecomment-4525221286 clicked it again. if tests on ci fail, but you run locally and pass, just post that.. we have some flaky ones! something else to look in to at somet ime ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
epugh commented on PR #4278: URL: https://github.com/apache/solr/pull/4278#issuecomment-4244083849 I have retriggered the solr tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
utsav00 commented on PR #4278: URL: https://github.com/apache/solr/pull/4278#issuecomment-4243185688 Was happy to work on this, @igiguere! This is a dumb question but I am not able to find an option to rerun the workflow - doesn't seem to be failing due to the changes on this PR. Can you please help retrigger the workflow run? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18066: Fix hideIgnoreStackTrace from the solr.xml [solr]
igiguere commented on PR #4278: URL: https://github.com/apache/solr/pull/4278#issuecomment-4237057326 +1 for me. Good catch, and thank you! I remember woking on the ticket to hide stack traces, I should probably have paid attention to that when wroking on JAX-RS resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
