[jira] [Commented] (SPARK-17838) Strict type checking for arguments with a better messages across APIs.
[
https://issues.apache.org/jira/browse/SPARK-17838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627770#comment-15627770
]
Felix Cheung commented on SPARK-17838:
--
merged to master. this should be very safe to go in branch-2.1 if it makes it,
but not critical.
> Strict type checking for arguments with a better messages across APIs.
> --
>
> Key: SPARK-17838
> URL: https://issues.apache.org/jira/browse/SPARK-17838
> Project: Spark
> Issue Type: Improvement
> Components: SparkR
>Reporter: Hyukjin Kwon
> Fix For: 2.2.0
>
>
> It seems there should be more strict type checking for arguments in SparkR
> APIs. This was discussed in several PRs.
> https://github.com/apache/spark/pull/15239#discussion_r82445435
> Roughly it seems there are three cases as below:
> The first case below was described in
> https://github.com/apache/spark/pull/15239#discussion_r82445435
> - Check for {{zero-length variable name}}
> Some of other cases below were handled in
> https://github.com/apache/spark/pull/15231#discussion_r80417904
> - Catch the exception from JVM and format it as pretty
> - Check strictly types before calling JVM in SparkR
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-17838) Strict type checking for arguments with a better messages across APIs.
[
https://issues.apache.org/jira/browse/SPARK-17838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601064#comment-15601064
]
Apache Spark commented on SPARK-17838:
--
User 'HyukjinKwon' has created a pull request for this issue:
https://github.com/apache/spark/pull/15608
> Strict type checking for arguments with a better messages across APIs.
> --
>
> Key: SPARK-17838
> URL: https://issues.apache.org/jira/browse/SPARK-17838
> Project: Spark
> Issue Type: Improvement
> Components: SparkR
>Reporter: Hyukjin Kwon
>
> It seems there should be more strict type checking for arguments in SparkR
> APIs. This was discussed in several PRs.
> https://github.com/apache/spark/pull/15239#discussion_r82445435
> Roughly it seems there are three cases as below:
> The first case below was described in
> https://github.com/apache/spark/pull/15239#discussion_r82445435
> - Check for {{zero-length variable name}}
> Some of other cases below were handled in
> https://github.com/apache/spark/pull/15231#discussion_r80417904
> - Catch the exception from JVM and format it as pretty
> - Check strictly types before calling JVM in SparkR
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-17838) Strict type checking for arguments with a better messages across APIs.
[
https://issues.apache.org/jira/browse/SPARK-17838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578101#comment-15578101
]
Hyukjin Kwon commented on SPARK-17838:
--
I am trying to work on this but I don't mind if anyone takes over this. It
seems take a bit of time to me.
> Strict type checking for arguments with a better messages across APIs.
> --
>
> Key: SPARK-17838
> URL: https://issues.apache.org/jira/browse/SPARK-17838
> Project: Spark
> Issue Type: Improvement
> Components: SparkR
>Reporter: Hyukjin Kwon
>
> It seems there should be more strict type checking for arguments in SparkR
> APIs. This was discussed in several PRs.
> https://github.com/apache/spark/pull/15239#discussion_r82445435
> Roughly it seems there are three cases as below:
> The first case below was described in
> https://github.com/apache/spark/pull/15239#discussion_r82445435
> - Check for {{zero-length variable name}}
> Some of other cases below were handled in
> https://github.com/apache/spark/pull/15231#discussion_r80417904
> - Catch the exception from JVM and format it as pretty
> - Check strictly types before calling JVM in SparkR
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
