[jira] [Commented] (SPARK-18291) SparkR glm predict should output original label when family = "binomial"

2016-12-02 Thread Yanbo Liang (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714572#comment-15714572
 ] 

Yanbo Liang commented on SPARK-18291:
-

Yeah, I totally agree Option 3. I send 
https://github.com/apache/spark/pull/16118 to revert this change, so there is 
no breaking API change for this issue. We can add this fix back after 
SPARK-18618 resolved, so I reopen this JIRA. Thanks.

> SparkR glm predict should output original label when family = "binomial"
> 
>
> Key: SPARK-18291
> URL: https://issues.apache.org/jira/browse/SPARK-18291
> Project: Spark
>  Issue Type: Bug
>  Components: ML, SparkR
>Reporter: Yanbo Liang
>Assignee: Yanbo Liang
> Attachments: SparkR2.1decisionoutputschemaforGLMs.pdf
>
>
> SparkR spark.glm predict should output original label when family = 
> "binomial".
> For example, we can run the following code in sparkr shell:
> {code}
> training <- suppressWarnings(createDataFrame(iris))
> training <- training[training$Species %in% c("versicolor", "virginica"), ]
> model <- spark.glm(training, Species ~ Sepal_Length + Sepal_Width,family = 
> binomial(link = "logit"))
> showDF(predict(model, training))
> {code}
> The prediction column is double value which makes no sense to users.
> {code}
> ++---++---+--+-+---+
> |Sepal_Length|Sepal_Width|Petal_Length|Petal_Width|   Species|label| 
> prediction|
> ++---++---+--+-+---+
> | 7.0|3.2| 4.7|1.4|versicolor|  0.0| 
> 0.8271421517601544|
> | 6.4|3.2| 4.5|1.5|versicolor|  0.0| 
> 0.6044595910413112|
> | 6.9|3.1| 4.9|1.5|versicolor|  0.0| 
> 0.7916340858281998|
> | 5.5|2.3| 4.0|1.3|versicolor|  
> 0.0|0.16080518180591158|
> | 6.5|2.8| 4.6|1.5|versicolor|  0.0| 
> 0.6112229217050189|
> | 5.7|2.8| 4.5|1.3|versicolor|  0.0| 
> 0.2555087295500885|
> | 6.3|3.3| 4.7|1.6|versicolor|  0.0| 
> 0.5681507664364834|
> | 4.9|2.4| 3.3|1.0|versicolor|  
> 0.0|0.05990570219972002|
> | 6.6|2.9| 4.6|1.3|versicolor|  0.0| 
> 0.6644434078306246|
> | 5.2|2.7| 3.9|1.4|versicolor|  
> 0.0|0.11293577405862379|
> | 5.0|2.0| 3.5|1.0|versicolor|  
> 0.0|0.06152372321585971|
> | 5.9|3.0| 4.2|1.5|versicolor|  
> 0.0|0.35250697207602555|
> | 6.0|2.2| 4.0|1.0|versicolor|  
> 0.0|0.32267018290814303|
> | 6.1|2.9| 4.7|1.4|versicolor|  0.0|  
> 0.433391153814592|
> | 5.6|2.9| 3.6|1.3|versicolor|  0.0| 
> 0.2280744262436993|
> | 6.7|3.1| 4.4|1.4|versicolor|  0.0| 
> 0.7219848389339459|
> | 5.6|3.0| 4.5|1.5|versicolor|  
> 0.0|0.23527698971404695|
> | 5.8|2.7| 4.1|1.0|versicolor|  0.0|  
> 0.285024533520016|
> | 6.2|2.2| 4.5|1.5|versicolor|  0.0| 
> 0.4107047877447493|
> | 5.6|2.5| 3.9|1.1|versicolor|  
> 0.0|0.20083561961645083|
> ++---++---+--+-+---+
> {code}
> The prediction value should be the original label like:
> {code}
> ++---++---+--+-+--+
> |Sepal_Length|Sepal_Width|Petal_Length|Petal_Width|   
> Species|label|prediction|
> ++---++---+--+-+--+
> | 7.0|3.2| 4.7|1.4|versicolor|  0.0| 
> virginica|
> | 6.4|3.2| 4.5|1.5|versicolor|  0.0| 
> virginica|
> | 6.9|3.1| 4.9|1.5|versicolor|  0.0| 
> virginica|
> | 5.5|2.3| 4.0|1.3|versicolor|  
> 0.0|versicolor|
> | 6.5|2.8| 4.6|1.5|versicolor|  0.0| 
> virginica|
> | 5.7|2.8| 4.5|1.3|versicolor|  
> 0.0|versicolor|
> | 6.3|3.3| 4.7|1.6|versicolor|  0.0| 
> virginica|
> | 4.9|2.4| 3.3|1.0|versicolor|  
> 0.0|versicolor|
> | 6.6|2.9| 4.6|1.3|versicolor|  0.0| 
> virginica|
> | 5.2|2.7| 3.9|1.4|versicolor|  
> 0.0|versicolor|
> | 5.0|2.0| 3.5|1.0|versicolor|  
> 0.0|versicolor|
> |

[jira] [Commented] (SPARK-18291) SparkR glm predict should output original label when family = "binomial"

2016-12-02 Thread Apache Spark (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714569#comment-15714569
 ] 

Apache Spark commented on SPARK-18291:
--

User 'yanboliang' has created a pull request for this issue:
https://github.com/apache/spark/pull/16118

> SparkR glm predict should output original label when family = "binomial"
> 
>
> Key: SPARK-18291
> URL: https://issues.apache.org/jira/browse/SPARK-18291
> Project: Spark
>  Issue Type: Bug
>  Components: ML, SparkR
>Reporter: Yanbo Liang
>Assignee: Yanbo Liang
> Fix For: 2.1.0
>
> Attachments: SparkR2.1decisionoutputschemaforGLMs.pdf
>
>
> SparkR spark.glm predict should output original label when family = 
> "binomial".
> For example, we can run the following code in sparkr shell:
> {code}
> training <- suppressWarnings(createDataFrame(iris))
> training <- training[training$Species %in% c("versicolor", "virginica"), ]
> model <- spark.glm(training, Species ~ Sepal_Length + Sepal_Width,family = 
> binomial(link = "logit"))
> showDF(predict(model, training))
> {code}
> The prediction column is double value which makes no sense to users.
> {code}
> ++---++---+--+-+---+
> |Sepal_Length|Sepal_Width|Petal_Length|Petal_Width|   Species|label| 
> prediction|
> ++---++---+--+-+---+
> | 7.0|3.2| 4.7|1.4|versicolor|  0.0| 
> 0.8271421517601544|
> | 6.4|3.2| 4.5|1.5|versicolor|  0.0| 
> 0.6044595910413112|
> | 6.9|3.1| 4.9|1.5|versicolor|  0.0| 
> 0.7916340858281998|
> | 5.5|2.3| 4.0|1.3|versicolor|  
> 0.0|0.16080518180591158|
> | 6.5|2.8| 4.6|1.5|versicolor|  0.0| 
> 0.6112229217050189|
> | 5.7|2.8| 4.5|1.3|versicolor|  0.0| 
> 0.2555087295500885|
> | 6.3|3.3| 4.7|1.6|versicolor|  0.0| 
> 0.5681507664364834|
> | 4.9|2.4| 3.3|1.0|versicolor|  
> 0.0|0.05990570219972002|
> | 6.6|2.9| 4.6|1.3|versicolor|  0.0| 
> 0.6644434078306246|
> | 5.2|2.7| 3.9|1.4|versicolor|  
> 0.0|0.11293577405862379|
> | 5.0|2.0| 3.5|1.0|versicolor|  
> 0.0|0.06152372321585971|
> | 5.9|3.0| 4.2|1.5|versicolor|  
> 0.0|0.35250697207602555|
> | 6.0|2.2| 4.0|1.0|versicolor|  
> 0.0|0.32267018290814303|
> | 6.1|2.9| 4.7|1.4|versicolor|  0.0|  
> 0.433391153814592|
> | 5.6|2.9| 3.6|1.3|versicolor|  0.0| 
> 0.2280744262436993|
> | 6.7|3.1| 4.4|1.4|versicolor|  0.0| 
> 0.7219848389339459|
> | 5.6|3.0| 4.5|1.5|versicolor|  
> 0.0|0.23527698971404695|
> | 5.8|2.7| 4.1|1.0|versicolor|  0.0|  
> 0.285024533520016|
> | 6.2|2.2| 4.5|1.5|versicolor|  0.0| 
> 0.4107047877447493|
> | 5.6|2.5| 3.9|1.1|versicolor|  
> 0.0|0.20083561961645083|
> ++---++---+--+-+---+
> {code}
> The prediction value should be the original label like:
> {code}
> ++---++---+--+-+--+
> |Sepal_Length|Sepal_Width|Petal_Length|Petal_Width|   
> Species|label|prediction|
> ++---++---+--+-+--+
> | 7.0|3.2| 4.7|1.4|versicolor|  0.0| 
> virginica|
> | 6.4|3.2| 4.5|1.5|versicolor|  0.0| 
> virginica|
> | 6.9|3.1| 4.9|1.5|versicolor|  0.0| 
> virginica|
> | 5.5|2.3| 4.0|1.3|versicolor|  
> 0.0|versicolor|
> | 6.5|2.8| 4.6|1.5|versicolor|  0.0| 
> virginica|
> | 5.7|2.8| 4.5|1.3|versicolor|  
> 0.0|versicolor|
> | 6.3|3.3| 4.7|1.6|versicolor|  0.0| 
> virginica|
> | 4.9|2.4| 3.3|1.0|versicolor|  
> 0.0|versicolor|
> | 6.6|2.9| 4.6|1.3|versicolor|  0.0| 
> virginica|
> | 5.2|2.7| 3.9|1.4|versicolor|  
> 0.0|versicolor|
> | 5.0|2.0| 3.5|1.0|versicolor|  
> 0.0|versicolor|
> | 5.9|3.0| 4.2|1.5|versicolor|  
> 0.0|versicolor|
> | 6.0|

[jira] [Commented] (SPARK-18291) SparkR glm predict should output original label when family = "binomial"

2016-12-01 Thread Joseph K. Bradley (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713341#comment-15713341
 ] 

Joseph K. Bradley commented on SPARK-18291:
---

I just saw the comment at the end of the PR and [SPARK-18618].  It sounds like 
we reached similar conclusions.

> SparkR glm predict should output original label when family = "binomial"
> 
>
> Key: SPARK-18291
> URL: https://issues.apache.org/jira/browse/SPARK-18291
> Project: Spark
>  Issue Type: Bug
>  Components: ML, SparkR
>Reporter: Yanbo Liang
>Assignee: Yanbo Liang
> Fix For: 2.1.0
>
> Attachments: SparkR2.1decisionoutputschemaforGLMs.pdf
>
>
> SparkR spark.glm predict should output original label when family = 
> "binomial".
> For example, we can run the following code in sparkr shell:
> {code}
> training <- suppressWarnings(createDataFrame(iris))
> training <- training[training$Species %in% c("versicolor", "virginica"), ]
> model <- spark.glm(training, Species ~ Sepal_Length + Sepal_Width,family = 
> binomial(link = "logit"))
> showDF(predict(model, training))
> {code}
> The prediction column is double value which makes no sense to users.
> {code}
> ++---++---+--+-+---+
> |Sepal_Length|Sepal_Width|Petal_Length|Petal_Width|   Species|label| 
> prediction|
> ++---++---+--+-+---+
> | 7.0|3.2| 4.7|1.4|versicolor|  0.0| 
> 0.8271421517601544|
> | 6.4|3.2| 4.5|1.5|versicolor|  0.0| 
> 0.6044595910413112|
> | 6.9|3.1| 4.9|1.5|versicolor|  0.0| 
> 0.7916340858281998|
> | 5.5|2.3| 4.0|1.3|versicolor|  
> 0.0|0.16080518180591158|
> | 6.5|2.8| 4.6|1.5|versicolor|  0.0| 
> 0.6112229217050189|
> | 5.7|2.8| 4.5|1.3|versicolor|  0.0| 
> 0.2555087295500885|
> | 6.3|3.3| 4.7|1.6|versicolor|  0.0| 
> 0.5681507664364834|
> | 4.9|2.4| 3.3|1.0|versicolor|  
> 0.0|0.05990570219972002|
> | 6.6|2.9| 4.6|1.3|versicolor|  0.0| 
> 0.6644434078306246|
> | 5.2|2.7| 3.9|1.4|versicolor|  
> 0.0|0.11293577405862379|
> | 5.0|2.0| 3.5|1.0|versicolor|  
> 0.0|0.06152372321585971|
> | 5.9|3.0| 4.2|1.5|versicolor|  
> 0.0|0.35250697207602555|
> | 6.0|2.2| 4.0|1.0|versicolor|  
> 0.0|0.32267018290814303|
> | 6.1|2.9| 4.7|1.4|versicolor|  0.0|  
> 0.433391153814592|
> | 5.6|2.9| 3.6|1.3|versicolor|  0.0| 
> 0.2280744262436993|
> | 6.7|3.1| 4.4|1.4|versicolor|  0.0| 
> 0.7219848389339459|
> | 5.6|3.0| 4.5|1.5|versicolor|  
> 0.0|0.23527698971404695|
> | 5.8|2.7| 4.1|1.0|versicolor|  0.0|  
> 0.285024533520016|
> | 6.2|2.2| 4.5|1.5|versicolor|  0.0| 
> 0.4107047877447493|
> | 5.6|2.5| 3.9|1.1|versicolor|  
> 0.0|0.20083561961645083|
> ++---++---+--+-+---+
> {code}
> The prediction value should be the original label like:
> {code}
> ++---++---+--+-+--+
> |Sepal_Length|Sepal_Width|Petal_Length|Petal_Width|   
> Species|label|prediction|
> ++---++---+--+-+--+
> | 7.0|3.2| 4.7|1.4|versicolor|  0.0| 
> virginica|
> | 6.4|3.2| 4.5|1.5|versicolor|  0.0| 
> virginica|
> | 6.9|3.1| 4.9|1.5|versicolor|  0.0| 
> virginica|
> | 5.5|2.3| 4.0|1.3|versicolor|  
> 0.0|versicolor|
> | 6.5|2.8| 4.6|1.5|versicolor|  0.0| 
> virginica|
> | 5.7|2.8| 4.5|1.3|versicolor|  
> 0.0|versicolor|
> | 6.3|3.3| 4.7|1.6|versicolor|  0.0| 
> virginica|
> | 4.9|2.4| 3.3|1.0|versicolor|  
> 0.0|versicolor|
> | 6.6|2.9| 4.6|1.3|versicolor|  0.0| 
> virginica|
> | 5.2|2.7| 3.9|1.4|versicolor|  
> 0.0|versicolor|
> | 5.0|2.0| 3.5|1.0|versicolor|  
> 0.0|versicolor|
> | 5.9|3.0| 4.2|1.5|versicolor|  
> 0.0|versicolor|
> |

[jira] [Commented] (SPARK-18291) SparkR glm predict should output original label when family = "binomial"

2016-11-29 Thread Apache Spark (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704906#comment-15704906
 ] 

Apache Spark commented on SPARK-18291:
--

User 'yanboliang' has created a pull request for this issue:
https://github.com/apache/spark/pull/16058

> SparkR glm predict should output original label when family = "binomial"
> 
>
> Key: SPARK-18291
> URL: https://issues.apache.org/jira/browse/SPARK-18291
> Project: Spark
>  Issue Type: Bug
>  Components: ML, SparkR
>Reporter: Yanbo Liang
>Assignee: Yanbo Liang
> Fix For: 2.1.0
>
>
> SparkR spark.glm predict should output original label when family = 
> "binomial".
> For example, we can run the following code in sparkr shell:
> {code}
> training <- suppressWarnings(createDataFrame(iris))
> training <- training[training$Species %in% c("versicolor", "virginica"), ]
> model <- spark.glm(training, Species ~ Sepal_Length + Sepal_Width,family = 
> binomial(link = "logit"))
> showDF(predict(model, training))
> {code}
> The prediction column is double value which makes no sense to users.
> {code}
> ++---++---+--+-+---+
> |Sepal_Length|Sepal_Width|Petal_Length|Petal_Width|   Species|label| 
> prediction|
> ++---++---+--+-+---+
> | 7.0|3.2| 4.7|1.4|versicolor|  0.0| 
> 0.8271421517601544|
> | 6.4|3.2| 4.5|1.5|versicolor|  0.0| 
> 0.6044595910413112|
> | 6.9|3.1| 4.9|1.5|versicolor|  0.0| 
> 0.7916340858281998|
> | 5.5|2.3| 4.0|1.3|versicolor|  
> 0.0|0.16080518180591158|
> | 6.5|2.8| 4.6|1.5|versicolor|  0.0| 
> 0.6112229217050189|
> | 5.7|2.8| 4.5|1.3|versicolor|  0.0| 
> 0.2555087295500885|
> | 6.3|3.3| 4.7|1.6|versicolor|  0.0| 
> 0.5681507664364834|
> | 4.9|2.4| 3.3|1.0|versicolor|  
> 0.0|0.05990570219972002|
> | 6.6|2.9| 4.6|1.3|versicolor|  0.0| 
> 0.6644434078306246|
> | 5.2|2.7| 3.9|1.4|versicolor|  
> 0.0|0.11293577405862379|
> | 5.0|2.0| 3.5|1.0|versicolor|  
> 0.0|0.06152372321585971|
> | 5.9|3.0| 4.2|1.5|versicolor|  
> 0.0|0.35250697207602555|
> | 6.0|2.2| 4.0|1.0|versicolor|  
> 0.0|0.32267018290814303|
> | 6.1|2.9| 4.7|1.4|versicolor|  0.0|  
> 0.433391153814592|
> | 5.6|2.9| 3.6|1.3|versicolor|  0.0| 
> 0.2280744262436993|
> | 6.7|3.1| 4.4|1.4|versicolor|  0.0| 
> 0.7219848389339459|
> | 5.6|3.0| 4.5|1.5|versicolor|  
> 0.0|0.23527698971404695|
> | 5.8|2.7| 4.1|1.0|versicolor|  0.0|  
> 0.285024533520016|
> | 6.2|2.2| 4.5|1.5|versicolor|  0.0| 
> 0.4107047877447493|
> | 5.6|2.5| 3.9|1.1|versicolor|  
> 0.0|0.20083561961645083|
> ++---++---+--+-+---+
> {code}
> The prediction value should be the original label like:
> {code}
> ++---++---+--+-+--+
> |Sepal_Length|Sepal_Width|Petal_Length|Petal_Width|   
> Species|label|prediction|
> ++---++---+--+-+--+
> | 7.0|3.2| 4.7|1.4|versicolor|  0.0| 
> virginica|
> | 6.4|3.2| 4.5|1.5|versicolor|  0.0| 
> virginica|
> | 6.9|3.1| 4.9|1.5|versicolor|  0.0| 
> virginica|
> | 5.5|2.3| 4.0|1.3|versicolor|  
> 0.0|versicolor|
> | 6.5|2.8| 4.6|1.5|versicolor|  0.0| 
> virginica|
> | 5.7|2.8| 4.5|1.3|versicolor|  
> 0.0|versicolor|
> | 6.3|3.3| 4.7|1.6|versicolor|  0.0| 
> virginica|
> | 4.9|2.4| 3.3|1.0|versicolor|  
> 0.0|versicolor|
> | 6.6|2.9| 4.6|1.3|versicolor|  0.0| 
> virginica|
> | 5.2|2.7| 3.9|1.4|versicolor|  
> 0.0|versicolor|
> | 5.0|2.0| 3.5|1.0|versicolor|  
> 0.0|versicolor|
> | 5.9|3.0| 4.2|1.5|versicolor|  
> 0.0|versicolor|
> | 6.0|2.2| 4.0|1.0|versicolor|  
> 0.0|versicolor|
> |

[jira] [Commented] (SPARK-18291) SparkR glm predict should output original label when family = "binomial"

2016-11-06 Thread Apache Spark (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641240#comment-15641240
 ] 

Apache Spark commented on SPARK-18291:
--

User 'yanboliang' has created a pull request for this issue:
https://github.com/apache/spark/pull/15788

> SparkR glm predict should output original label when family = "binomial"
> 
>
> Key: SPARK-18291
> URL: https://issues.apache.org/jira/browse/SPARK-18291
> Project: Spark
>  Issue Type: Bug
>  Components: ML, SparkR
>Reporter: Yanbo Liang
>
> SparkR glm predict should output original label when family = "binomial".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org