[jira] [Commented] (SPARK-18419) Fix `JDBCOptions.asConnectionProperties` to be case-insensitive
[
https://issues.apache.org/jira/browse/SPARK-18419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712843#comment-15712843
]
Dongjoon Hyun commented on SPARK-18419:
---
Sorry, I thought it's resolved.
But, when I tried to verify it, I found it's not.
So, I reopen and refresh the testcase and PR.
> Fix `JDBCOptions.asConnectionProperties` to be case-insensitive
> ---
>
> Key: SPARK-18419
> URL: https://issues.apache.org/jira/browse/SPARK-18419
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Reporter: Dongjoon Hyun
>Priority: Minor
>
> This issue aims to fix `JDBCOptions.asConnectionProperties` to be
> case-insensitive.
> `JDBCOptions.asConnectionProperties` is designed to filter JDBC options out,
> but it fails to handle `CaseInsensitiveMap` correctly. For the following
> example, it returns `Map('numpartitions' -> "10")` as a wrong result and the
> assertion fails.
> {code}
> val options = new JDBCOptions(new CaseInsensitiveMap(Map(
> "url" -> "jdbc:mysql://localhost:3306/temp",
> "dbtable" -> "t1",
> "numPartitions" -> "10")))
> assert(options.asConnectionProperties.isEmpty)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-18419) Fix `JDBCOptions.asConnectionProperties` to be case-insensitive
[
https://issues.apache.org/jira/browse/SPARK-18419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712770#comment-15712770
]
Sean Owen commented on SPARK-18419:
---
[~dongjoon] given your comment on the PR, is this resolved?
> Fix `JDBCOptions.asConnectionProperties` to be case-insensitive
> ---
>
> Key: SPARK-18419
> URL: https://issues.apache.org/jira/browse/SPARK-18419
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Reporter: Dongjoon Hyun
>Priority: Minor
>
> This issue aims to fix `JDBCOptions.asConnectionProperties` to be
> case-insensitive.
> `JDBCOptions.asConnectionProperties` is designed to filter JDBC options out,
> but it fails to handle `CaseInsensitiveMap` correctly. For the following
> example, it returns `Map('numpartitions' -> "10")` as a wrong result and the
> assertion fails.
> {code}
> val options = new JDBCOptions(new CaseInsensitiveMap(Map(
> "url" -> "jdbc:mysql://localhost:3306/temp",
> "dbtable" -> "t1",
> "numPartitions" -> "10")))
> assert(options.asConnectionProperties.isEmpty)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-18419) Fix JDBCOptions.asConnectionProperties to be case-insensitive
[
https://issues.apache.org/jira/browse/SPARK-18419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15659688#comment-15659688
]
Apache Spark commented on SPARK-18419:
--
User 'dongjoon-hyun' has created a pull request for this issue:
https://github.com/apache/spark/pull/15863
> Fix JDBCOptions.asConnectionProperties to be case-insensitive
> --
>
> Key: SPARK-18419
> URL: https://issues.apache.org/jira/browse/SPARK-18419
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Reporter: Dongjoon Hyun
>Priority: Minor
>
> `JDBCOptions.asConnectionProperties` fails to filter `CaseInsensitiveMap`
> correctly. For the following case, it returns `Map('numpartitions' -> "10")`
> as a wrong result.
> {code}
> val options = new JDBCOptions(new CaseInsensitiveMap(Map(
> "url" -> "jdbc:mysql://localhost:3306/temp",
> "dbtable" -> "t1",
> "numPartitions" -> "10")))
> assert(options.asConnectionProperties.isEmpty)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
