[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144008#comment-16144008
]
Apache Spark commented on SPARK-21590:
--
User 'KevinZwx' has created a pull request for this issue:
[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120924#comment-16120924
]
Kevin Zhang commented on SPARK-21590:
-
Thanks, I'd like to work on this.
I agree the requirement
[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118560#comment-16118560
]
Burak Yavuz commented on SPARK-21590:
-
Ah, I apologize, I thought the other way around (you had data
[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117900#comment-16117900
]
Kevin Zhang commented on SPARK-21590:
-
[~brkyvz] Thanks for your advice, but I believe you don't
[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115998#comment-16115998
]
Burak Yavuz commented on SPARK-21590:
-
[~KevinZwx] there's nothing wrong. It works as it needs to
[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112274#comment-16112274
]
Kevin Zhang commented on SPARK-21590:
-
[~brkyvz] I don' t know the test you illustrated, but
[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111467#comment-16111467
]
Shixiong Zhu commented on SPARK-21590:
--
[~brkyvz] Yeah, some people may process data before 1970. I
[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111460#comment-16111460
]
Burak Yavuz commented on SPARK-21590:
-
There are tests to make sure it supports "negative" timestamps
[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111458#comment-16111458
]
Burak Yavuz commented on SPARK-21590:
-
Does it output incorrect results if you provide `+16 hours`
[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110209#comment-16110209
]
Kevin Zhang commented on SPARK-21590:
-
I think the only problem is the non-negative check of window
[
https://issues.apache.org/jira/browse/SPARK-21590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1610#comment-1610
]
Shixiong Zhu commented on SPARK-21590:
--
Yeah, this is a bug. A timestamp can be negative.
cc
11 matches
Mail list logo