[jira] [Commented] (SPARK-21629) OR nullability is incorrect
[
https://issues.apache.org/jira/browse/SPARK-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115702#comment-16115702
]
Liang-Chi Hsieh commented on SPARK-21629:
-
No problem. Mentees still learn something.
> OR nullability is incorrect
> ---
>
> Key: SPARK-21629
> URL: https://issues.apache.org/jira/browse/SPARK-21629
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.0.0, 2.1.1, 2.2.0
>Reporter: Herman van Hovell
>Priority: Minor
> Labels: Starter
>
> The SQL {{OR}} expression's nullability is slightly incorrect. It should only
> be nullable when both of the input expressions are nullable, and not when
> either of them is nullable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-21629) OR nullability is incorrect
[
https://issues.apache.org/jira/browse/SPARK-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115626#comment-16115626
]
Liang-Chi Hsieh commented on SPARK-21629:
-
[~hvanhovell] As this is not a problem, but I can't close it. Can you help it?
Thanks.
> OR nullability is incorrect
> ---
>
> Key: SPARK-21629
> URL: https://issues.apache.org/jira/browse/SPARK-21629
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.0.0, 2.1.1, 2.2.0
>Reporter: Herman van Hovell
>Assignee: Liang-Chi Hsieh
>Priority: Minor
> Labels: Starter
>
> The SQL {{OR}} expression's nullability is slightly incorrect. It should only
> be nullable when both of the input expressions are nullable, and not when
> either of them is nullable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-21629) OR nullability is incorrect
[
https://issues.apache.org/jira/browse/SPARK-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115405#comment-16115405
]
Liang-Chi Hsieh commented on SPARK-21629:
-
Yap, Thanks a lot [~hvanhovell].
> OR nullability is incorrect
> ---
>
> Key: SPARK-21629
> URL: https://issues.apache.org/jira/browse/SPARK-21629
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.0.0, 2.1.1, 2.2.0
>Reporter: Herman van Hovell
>Assignee: Liang-Chi Hsieh
>Priority: Minor
> Labels: Starter
>
> The SQL {{OR}} expression's nullability is slightly incorrect. It should only
> be nullable when both of the input expressions are nullable, and not when
> either of them is nullable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-21629) OR nullability is incorrect
[
https://issues.apache.org/jira/browse/SPARK-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115397#comment-16115397
]
Herman van Hovell commented on SPARK-21629:
---
Sure go for it. Should be a one-liner :)
> OR nullability is incorrect
> ---
>
> Key: SPARK-21629
> URL: https://issues.apache.org/jira/browse/SPARK-21629
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.0.0, 2.1.1, 2.2.0
>Reporter: Herman van Hovell
>Priority: Minor
> Labels: Starter
>
> The SQL {{OR}} expression's nullability is slightly incorrect. It should only
> be nullable when both of the input expressions are nullable, and not when
> either of them is nullable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-21629) OR nullability is incorrect
[
https://issues.apache.org/jira/browse/SPARK-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115395#comment-16115395
]
Liang-Chi Hsieh commented on SPARK-21629:
-
[~hvanhovell] Sorry, I'm mentoring the few local developers in Taiwan for
contributing Spark. This looks a trivial PR. May I ask holding this issue for
one of the mentees? If you don't mind, can you help assign it to me
temporarily. Thanks!
> OR nullability is incorrect
> ---
>
> Key: SPARK-21629
> URL: https://issues.apache.org/jira/browse/SPARK-21629
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.0.0, 2.1.1, 2.2.0
>Reporter: Herman van Hovell
>Priority: Minor
> Labels: Starter
>
> The SQL {{OR}} expression's nullability is slightly incorrect. It should only
> be nullable when both of the input expressions are nullable, and not when
> either of them is nullable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-21629) OR nullability is incorrect
[
https://issues.apache.org/jira/browse/SPARK-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114056#comment-16114056
]
Takeshi Yamamuro commented on SPARK-21629:
--
oh, yea. I see.
> OR nullability is incorrect
> ---
>
> Key: SPARK-21629
> URL: https://issues.apache.org/jira/browse/SPARK-21629
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.0.0, 2.1.1, 2.2.0
>Reporter: Herman van Hovell
>Priority: Minor
>
> The SQL {{OR}} expression's nullability is slightly incorrect. It should only
> be nullable when both of the input expressions are nullable, and not when
> either of them is nullable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-21629) OR nullability is incorrect
[
https://issues.apache.org/jira/browse/SPARK-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114041#comment-16114041
]
Herman van Hovell commented on SPARK-21629:
---
Thanks for doing this. The first sequence should also return {{nullable =
false}}.
> OR nullability is incorrect
> ---
>
> Key: SPARK-21629
> URL: https://issues.apache.org/jira/browse/SPARK-21629
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.0.0, 2.1.1, 2.2.0
>Reporter: Herman van Hovell
>Priority: Minor
>
> The SQL {{OR}} expression's nullability is slightly incorrect. It should only
> be nullable when both of the input expressions are nullable, and not when
> either of them is nullable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-21629) OR nullability is incorrect
[
https://issues.apache.org/jira/browse/SPARK-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113752#comment-16113752
]
Takeshi Yamamuro commented on SPARK-21629:
--
What's a concrete query and result example?
It is like a sequence below?
{code}
scala> Seq((Some(1), 1), (None, 2)).toDF("a", "b").selectExpr("a > 0 OR b >
0").printSchema
root
|-- ((a > 0) OR (b > 0)): boolean (nullable = true)
scala> Seq((1, 1), (0, 2)).toDF("a", "b").selectExpr("a > 0 OR b >
0").printSchema
root
|-- ((a > 0) OR (b > 0)): boolean (nullable = false)
{code}
> OR nullability is incorrect
> ---
>
> Key: SPARK-21629
> URL: https://issues.apache.org/jira/browse/SPARK-21629
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.0.0, 2.1.1, 2.2.0
>Reporter: Herman van Hovell
>Priority: Minor
>
> The SQL {{OR}} expression's nullability is slightly incorrect. It should only
> be nullable when both of the input expressions are nullable, and not when
> either of them is nullable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
