[jira] [Commented] (SPARK-26105) Clean unittest2 imports up added Python 2.6 before

2018-11-18 Thread Apache Spark (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691143#comment-16691143
 ] 

Apache Spark commented on SPARK-26105:
--

User 'HyukjinKwon' has created a pull request for this issue:
https://github.com/apache/spark/pull/23077

> Clean unittest2 imports up added Python 2.6 before
> --
>
> Key: SPARK-26105
> URL: https://issues.apache.org/jira/browse/SPARK-26105
> Project: Spark
>  Issue Type: Test
>  Components: PySpark
>Affects Versions: 3.0.0
>Reporter: Hyukjin Kwon
>Priority: Major
>
> Currently, PySpark tests sill assume the tests could be ran in Python 2.6 by 
> importing {{unittest2}}. For instance:
> {code}
> if sys.version_info[:2] <= (2, 6):
> try:
> import unittest2 as unittest
> except ImportError:
> sys.stderr.write('Please install unittest2 to test with Python 2.6 or 
> earlier')
> sys.exit(1)
> else:
> import unittest
> {code}
> We officially dropped Python 2.6 support a while ago and started to discuss 
> about Python 2 drop. It's better to remove them out. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-26105) Clean unittest2 imports up added Python 2.6 before

2018-11-18 Thread Apache Spark (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-26105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691141#comment-16691141
 ] 

Apache Spark commented on SPARK-26105:
--

User 'HyukjinKwon' has created a pull request for this issue:
https://github.com/apache/spark/pull/23077

> Clean unittest2 imports up added Python 2.6 before
> --
>
> Key: SPARK-26105
> URL: https://issues.apache.org/jira/browse/SPARK-26105
> Project: Spark
>  Issue Type: Test
>  Components: PySpark
>Affects Versions: 3.0.0
>Reporter: Hyukjin Kwon
>Priority: Major
>
> Currently, PySpark tests sill assume the tests could be ran in Python 2.6 by 
> importing {{unittest2}}. For instance:
> {code}
> if sys.version_info[:2] <= (2, 6):
> try:
> import unittest2 as unittest
> except ImportError:
> sys.stderr.write('Please install unittest2 to test with Python 2.6 or 
> earlier')
> sys.exit(1)
> else:
> import unittest
> {code}
> We officially dropped Python 2.6 support a while ago and started to discuss 
> about Python 2 drop. It's better to remove them out. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org