[jira] [Commented] (SPARK-5262) coalesce should allow NullType and 1 another type in parameters

2015-01-20 Thread Adrian Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285179#comment-14285179
 ] 

Adrian Wang commented on SPARK-5262:


Currently if you try coalesce in hivecontext, it will use hive udf instead of 
scala build-in method.

 coalesce should allow NullType and 1 another type in parameters
 ---

 Key: SPARK-5262
 URL: https://issues.apache.org/jira/browse/SPARK-5262
 Project: Spark
  Issue Type: Bug
  Components: SQL
Reporter: Adrian Wang

 Currently Coalesce(null, 1, null) would throw exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-5262) coalesce should allow NullType and 1 another type in parameters

2015-01-20 Thread Yin Huai (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285187#comment-14285187
 ] 

Yin Huai commented on SPARK-5262:
-

OK i see. In HiveContext, we are still using Hive's UDF. Actually, it will be 
good to do the work of this JIRA and SPARK-5244 together. 

 coalesce should allow NullType and 1 another type in parameters
 ---

 Key: SPARK-5262
 URL: https://issues.apache.org/jira/browse/SPARK-5262
 Project: Spark
  Issue Type: Bug
  Components: SQL
Reporter: Adrian Wang

 Currently Coalesce(null, 1, null) would throw exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-5262) coalesce should allow NullType and 1 another type in parameters

2015-01-20 Thread Adrian Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285192#comment-14285192
 ] 

Adrian Wang commented on SPARK-5262:


Yeah, so I think we'd better merge this first and add a test case in SPARK-5244 
. They focus differently, one on a bug while the other on a new feature.

 coalesce should allow NullType and 1 another type in parameters
 ---

 Key: SPARK-5262
 URL: https://issues.apache.org/jira/browse/SPARK-5262
 Project: Spark
  Issue Type: Bug
  Components: SQL
Reporter: Adrian Wang

 Currently Coalesce(null, 1, null) would throw exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-5262) coalesce should allow NullType and 1 another type in parameters

2015-01-20 Thread Yin Huai (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285176#comment-14285176
 ] 

Yin Huai commented on SPARK-5262:
-

[~adrian-wang] I tried Coalesce(null, 1, null) in HiveContext. It works. 
Actually, I got a NPE when I tried Coalesce(null, null, null). 

 coalesce should allow NullType and 1 another type in parameters
 ---

 Key: SPARK-5262
 URL: https://issues.apache.org/jira/browse/SPARK-5262
 Project: Spark
  Issue Type: Bug
  Components: SQL
Reporter: Adrian Wang

 Currently Coalesce(null, 1, null) would throw exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-5262) coalesce should allow NullType and 1 another type in parameters

2015-01-20 Thread Yin Huai (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285220#comment-14285220
 ] 

Yin Huai commented on SPARK-5262:
-

I am not sure they are actually focusing on different things. But if you want 
to do these separately, we should make sure that the behavior of coalesce is 
correct and the PR has unit tests.

 coalesce should allow NullType and 1 another type in parameters
 ---

 Key: SPARK-5262
 URL: https://issues.apache.org/jira/browse/SPARK-5262
 Project: Spark
  Issue Type: Bug
  Components: SQL
Reporter: Adrian Wang

 Currently Coalesce(null, 1, null) would throw exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-5262) coalesce should allow NullType and 1 another type in parameters

2015-01-15 Thread Apache Spark (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278416#comment-14278416
 ] 

Apache Spark commented on SPARK-5262:
-

User 'adrian-wang' has created a pull request for this issue:
https://github.com/apache/spark/pull/4057

 coalesce should allow NullType and 1 another type in parameters
 ---

 Key: SPARK-5262
 URL: https://issues.apache.org/jira/browse/SPARK-5262
 Project: Spark
  Issue Type: Bug
  Components: SQL
Reporter: Adrian Wang

 Currently Coalesce(null, 1, null) would throw exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org