Re: [PR] [Improve] StreamPark Platform configuration files improvements [incubator-streampark]
caicancai commented on PR #3679: URL: https://github.com/apache/incubator-streampark/pull/3679#issuecomment-2080321486 When I tested this commit locally (mac+linux), I found that the unzipped folder conf directory seemed to be missing something.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Improve] StreamPark Platform configuration files improvements [incubator-streampark]
wolfboys merged PR #3679: URL: https://github.com/apache/incubator-streampark/pull/3679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [Improve] StreamPark Platform configuration files improvements [incubator-streampark]
wolfboys opened a new pull request, #3679: URL: https://github.com/apache/incubator-streampark/pull/3679 Currently, the streampark platform provides multiple configuration files for user configuration, such as: application.yml, application-pgsql.yml, application-mysql.yml, kerberos.yml... , We can improve these configuration files. Many config files are internal system configurations, for example, in application.yml, a large number of configurations are internal platform configurations, such as jackson config for integration Spring Boot, swagger-ui config. the 'allow-circular-references' parameter for Spring... These do not need user configuration and should not be exposed to users. So, I propose that we improve these configurations by providing users with only one configuration file(only one). The configurations in this file should be completely user-focused, clear, and core configurations. ## What changes were proposed in this pull request Issue Number: close #3641 ## Brief change log ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: ## Does this pull request potentially affect one of the following parts - Dependencies (does it add or upgrade a dependency): (yes / no) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Improve] StreamPark Platform configuration files improvements [incubator-streampark]
GOODBOY008 merged PR #3653: URL: https://github.com/apache/incubator-streampark/pull/3653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [Improve] StreamPark Platform configuration files improvements [incubator-streampark]
wolfboys opened a new pull request, #3653: URL: https://github.com/apache/incubator-streampark/pull/3653 Currently, the streampark platform provides multiple configuration files for user configuration, such as: application.yml, application-pgsql.yml, application-mysql.yml, kerberos.yml... , We can improve these configuration files. Many config files are internal system configurations, for example, in application.yml, a large number of configurations are internal platform configurations, such as jackson config for integration Spring Boot, swagger-ui config. the 'allow-circular-references' parameter for Spring... These do not need user configuration and should not be exposed to users. So, I propose that we improve these configurations by providing users with only one configuration file(only one). The configurations in this file should be completely user-focused, clear, and core configurations. ## What changes were proposed in this pull request Issue Number: close #3641 ## Brief change log ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: ## Does this pull request potentially affect one of the following parts - Dependencies (does it add or upgrade a dependency): (yes / no) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
