[jira] [Commented] (WW-4988) Upgrade DWR from 1.x to 2.x (for DWR plugin)
[ https://issues.apache.org/jira/browse/WW-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711818#comment-16711818 ] Yasser Zamani commented on WW-4988: --- Thank you [~JCjA492kH6347Vb10Ja53], yes it is passing security checks after your upgrade :). I personally had tendency to add show case to reveal if it works but I concluded with [DWR-540|https://directwebremoting.atlassian.net/browse/DWR-540]. Fortunately there wasn't a burden to upgrade to DWR3 to fix that. > Upgrade DWR from 1.x to 2.x (for DWR plugin) > > > Key: WW-4988 > URL: https://issues.apache.org/jira/browse/WW-4988 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - DWR >Affects Versions: 2.6 > Environment: All environments >Reporter: James Chaplin >Priority: Minor > Labels: pull-request-available > Fix For: 2.6 > > > Hello Apache Struts Team. > There appears to be a failure/warning reported in the automated nightly > Jenkins builds in relation to the DWR plugin component (reported by > org.owasp:dependency-check-maven). > A PR ([https://github.com/apache/struts/pull/283)] has been opened in hopes > of addressing this by _upgrading the Struts 2.6 DWR plugin to the most recent > API-compatible version of DWR_ (2.x series). > > Since _only manual testing/verification is possible at this time_ (requires > modification of the showcase application web.xml, see above PR for details), > _there is a risk that upgrading the DWR dependency might introduce issues for > the DWR plugin_. > > If there is anyone who has _suggestions on creating an automated (preferably > self-contained) test for the DWR plugin_ within the regression suite please > advise by commenting on this JIRA. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4988) Upgrade DWR from 1.x to 2.x (for DWR plugin)
[ https://issues.apache.org/jira/browse/WW-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710853#comment-16710853 ] James Chaplin commented on WW-4988: --- Good job [~yasser.zamani] ! :) Thanks for your effort - and the addition to the showcase app. Upgrading to DWR3 (and DWR2 just prior) appears to allow the automated Jenkins builds to get further (past the DWR plugin for sure ;) ). > Upgrade DWR from 1.x to 2.x (for DWR plugin) > > > Key: WW-4988 > URL: https://issues.apache.org/jira/browse/WW-4988 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - DWR >Affects Versions: 2.6 > Environment: All environments >Reporter: James Chaplin >Priority: Minor > Labels: pull-request-available > Fix For: 2.6 > > > Hello Apache Struts Team. > There appears to be a failure/warning reported in the automated nightly > Jenkins builds in relation to the DWR plugin component (reported by > org.owasp:dependency-check-maven). > A PR ([https://github.com/apache/struts/pull/283)] has been opened in hopes > of addressing this by _upgrading the Struts 2.6 DWR plugin to the most recent > API-compatible version of DWR_ (2.x series). > > Since _only manual testing/verification is possible at this time_ (requires > modification of the showcase application web.xml, see above PR for details), > _there is a risk that upgrading the DWR dependency might introduce issues for > the DWR plugin_. > > If there is anyone who has _suggestions on creating an automated (preferably > self-contained) test for the DWR plugin_ within the regression suite please > advise by commenting on this JIRA. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4988) Upgrade DWR from 1.x to 2.x (for DWR plugin)
[ https://issues.apache.org/jira/browse/WW-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708370#comment-16708370 ] Lukasz Lenart commented on WW-4988: --- [~yasser.zamani] thanks, you are right :) > Upgrade DWR from 1.x to 2.x (for DWR plugin) > > > Key: WW-4988 > URL: https://issues.apache.org/jira/browse/WW-4988 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - DWR >Affects Versions: 2.6 > Environment: All environments >Reporter: James Chaplin >Priority: Minor > Labels: pull-request-available > Fix For: 2.6 > > > Hello Apache Struts Team. > There appears to be a failure/warning reported in the automated nightly > Jenkins builds in relation to the DWR plugin component (reported by > org.owasp:dependency-check-maven). > A PR ([https://github.com/apache/struts/pull/283)] has been opened in hopes > of addressing this by _upgrading the Struts 2.6 DWR plugin to the most recent > API-compatible version of DWR_ (2.x series). > > Since _only manual testing/verification is possible at this time_ (requires > modification of the showcase application web.xml, see above PR for details), > _there is a risk that upgrading the DWR dependency might introduce issues for > the DWR plugin_. > > If there is anyone who has _suggestions on creating an automated (preferably > self-contained) test for the DWR plugin_ within the regression suite please > advise by commenting on this JIRA. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4988) Upgrade DWR from 1.x to 2.x (for DWR plugin)
[ https://issues.apache.org/jira/browse/WW-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707169#comment-16707169 ] Yasser Zamani commented on WW-4988: --- I tried to add showcase for DWR2 but was failing due to [DWR-540|https://directwebremoting.atlassian.net/browse/DWR-540]. So with today efforts I could successfully [upgrade to DWR3 with a showcase|https://github.com/apache/struts/pull/285] :) the showcase works great! > Upgrade DWR from 1.x to 2.x (for DWR plugin) > > > Key: WW-4988 > URL: https://issues.apache.org/jira/browse/WW-4988 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - DWR >Affects Versions: 2.6 > Environment: All environments >Reporter: James Chaplin >Priority: Minor > Labels: pull-request-available > Fix For: 2.6 > > > Hello Apache Struts Team. > There appears to be a failure/warning reported in the automated nightly > Jenkins builds in relation to the DWR plugin component (reported by > org.owasp:dependency-check-maven). > A PR ([https://github.com/apache/struts/pull/283)] has been opened in hopes > of addressing this by _upgrading the Struts 2.6 DWR plugin to the most recent > API-compatible version of DWR_ (2.x series). > > Since _only manual testing/verification is possible at this time_ (requires > modification of the showcase application web.xml, see above PR for details), > _there is a risk that upgrading the DWR dependency might introduce issues for > the DWR plugin_. > > If there is anyone who has _suggestions on creating an automated (preferably > self-contained) test for the DWR plugin_ within the regression suite please > advise by commenting on this JIRA. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4988) Upgrade DWR from 1.x to 2.x (for DWR plugin)
[
https://issues.apache.org/jira/browse/WW-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706763#comment-16706763
]
Yasser Zamani commented on WW-4988:
---
Not looks nice to me personally. From {{struts-async-plugin}} which firstly I
named it {{struts-servlet3-plugin}}, I remember [~rgielen]'s comment that
putting version numbers in names isn't a good practice. After that, it's 2.6 :)
we can break DWR2 and replace it with DWR3. It's a just-one-file with just a
few code lines plugin. I think users will like to upgrade also.
> Upgrade DWR from 1.x to 2.x (for DWR plugin)
>
>
> Key: WW-4988
> URL: https://issues.apache.org/jira/browse/WW-4988
> Project: Struts 2
> Issue Type: Dependency
> Components: Plugin - DWR
>Affects Versions: 2.6
> Environment: All environments
>Reporter: James Chaplin
>Priority: Minor
> Labels: pull-request-available
> Fix For: 2.6
>
>
> Hello Apache Struts Team.
> There appears to be a failure/warning reported in the automated nightly
> Jenkins builds in relation to the DWR plugin component (reported by
> org.owasp:dependency-check-maven).
> A PR ([https://github.com/apache/struts/pull/283)] has been opened in hopes
> of addressing this by _upgrading the Struts 2.6 DWR plugin to the most recent
> API-compatible version of DWR_ (2.x series).
>
> Since _only manual testing/verification is possible at this time_ (requires
> modification of the showcase application web.xml, see above PR for details),
> _there is a risk that upgrading the DWR dependency might introduce issues for
> the DWR plugin_.
>
> If there is anyone who has _suggestions on creating an automated (preferably
> self-contained) test for the DWR plugin_ within the regression suite please
> advise by commenting on this JIRA.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4988) Upgrade DWR from 1.x to 2.x (for DWR plugin)
[
https://issues.apache.org/jira/browse/WW-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706162#comment-16706162
]
Lukasz Lenart commented on WW-4988:
---
There is also WW-4069 which requires a large rewrite of the existing plugin and
now I think we can add support for DWR3 in another plugin,
{{struts-dwr3-plugin}}, wdyt?
> Upgrade DWR from 1.x to 2.x (for DWR plugin)
>
>
> Key: WW-4988
> URL: https://issues.apache.org/jira/browse/WW-4988
> Project: Struts 2
> Issue Type: Dependency
> Components: Plugin - DWR
>Affects Versions: 2.6
> Environment: All environments
>Reporter: James Chaplin
>Priority: Minor
> Labels: pull-request-available
> Fix For: 2.6
>
>
> Hello Apache Struts Team.
> There appears to be a failure/warning reported in the automated nightly
> Jenkins builds in relation to the DWR plugin component (reported by
> org.owasp:dependency-check-maven).
> A PR ([https://github.com/apache/struts/pull/283)] has been opened in hopes
> of addressing this by _upgrading the Struts 2.6 DWR plugin to the most recent
> API-compatible version of DWR_ (2.x series).
>
> Since _only manual testing/verification is possible at this time_ (requires
> modification of the showcase application web.xml, see above PR for details),
> _there is a risk that upgrading the DWR dependency might introduce issues for
> the DWR plugin_.
>
> If there is anyone who has _suggestions on creating an automated (preferably
> self-contained) test for the DWR plugin_ within the regression suite please
> advise by commenting on this JIRA.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
