[jira] [Commented] (WW-5267) Allow SiteMesh to run on requests that are not Struts actions, but SiteMesh requires ActionContext
[ https://issues.apache.org/jira/browse/WW-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798118#comment-17798118 ] Kusal Kithul-Godage commented on WW-5267: - Closing as this can be implemented quite trivially for applications that desire it by using an overriding class > Allow SiteMesh to run on requests that are not Struts actions, but SiteMesh > requires ActionContext > -- > > Key: WW-5267 > URL: https://issues.apache.org/jira/browse/WW-5267 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > There are scenarios where you may want to exclude a request from Struts > filtering/processing using `struts.action.excludePattern` as it is not a > Struts action and/or having Struts consume/parse the multipart is undesirable. > However, you may still want that request to undergo filtering such as > SiteMesh, which requires the ActionContext to be present. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5267) Allow SiteMesh to run on requests that are not Struts actions, but SiteMesh requires ActionContext
[ https://issues.apache.org/jira/browse/WW-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697431#comment-17697431 ] Kusal Kithul-Godage commented on WW-5267: - Yep those sound like better options > Allow SiteMesh to run on requests that are not Struts actions, but SiteMesh > requires ActionContext > -- > > Key: WW-5267 > URL: https://issues.apache.org/jira/browse/WW-5267 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.2.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > There are scenarios where you may want to exclude a request from Struts > filtering/processing using `struts.action.excludePattern` as it is not a > Struts action and/or having Struts consume/parse the multipart is undesirable. > However, you may still want that request to undergo filtering such as > SiteMesh, which requires the ActionContext to be present. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5267) Allow SiteMesh to run on requests that are not Struts actions, but SiteMesh requires ActionContext
[
https://issues.apache.org/jira/browse/WW-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697415#comment-17697415
]
Lukasz Lenart commented on WW-5267:
---
Maybe this should be embedded into Sitemesh support or the Sitemesh plugin
should deliver a dedicate {{StrutsPrepareFilter}} which will initiate the
context
> Allow SiteMesh to run on requests that are not Struts actions, but SiteMesh
> requires ActionContext
> --
>
> Key: WW-5267
> URL: https://issues.apache.org/jira/browse/WW-5267
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> There are scenarios where you may want to exclude a request from Struts
> filtering/processing using `struts.action.excludePattern` as it is not a
> Struts action and/or having Struts consume/parse the multipart is undesirable.
> However, you may still want that request to undergo filtering such as
> SiteMesh, which requires the ActionContext to be present.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5267) Allow SiteMesh to run on requests that are not Struts actions, but SiteMesh requires ActionContext
[ https://issues.apache.org/jira/browse/WW-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697414#comment-17697414 ] Kusal Kithul-Godage commented on WW-5267: - As per [this comment|https://github.com/apache/struts/pull/663#issuecomment-1457617483], the solution to this should ideally not involve generating the ActionContext for requests that have explicitly been excluded by `struts.action.excludePattern` as it violates the expectation of `struts.action.excludePattern`, even if it is implemented as an opt-in option. > Allow SiteMesh to run on requests that are not Struts actions, but SiteMesh > requires ActionContext > -- > > Key: WW-5267 > URL: https://issues.apache.org/jira/browse/WW-5267 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.2.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > There are scenarios where you may want to exclude a request from Struts > filtering/processing using `struts.action.excludePattern` as it is not a > Struts action and/or having Struts consume/parse the multipart is undesirable. > However, you may still want that request to undergo filtering such as > SiteMesh, which requires the ActionContext to be present. -- This message was sent by Atlassian Jira (v8.20.10#820010)
