[jira] [Work logged] (WW-5278) Clean up duplicated code across ActionValidationManagers

2023-01-30 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/WW-5278?focusedWorklogId=842281=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842281
 ]

ASF GitHub Bot logged work on WW-5278:
--

Author: ASF GitHub Bot
Created on: 30/Jan/23 12:58
Start Date: 30/Jan/23 12:58
Worklog Time Spent: 10m 
  Work Description: lukaszlenart merged PR #656:
URL: https://github.com/apache/struts/pull/656




Issue Time Tracking
---

Worklog Id: (was: 842281)
Time Spent: 0.5h  (was: 20m)

> Clean up duplicated code across ActionValidationManagers
> 
>
> Key: WW-5278
> URL: https://issues.apache.org/jira/browse/WW-5278
> Project: Struts 2
>  Issue Type: Task
>  Components: Core Interceptors
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (WW-5278) Clean up duplicated code across ActionValidationManagers

2023-01-30 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/WW-5278?focusedWorklogId=842278=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842278
 ]

ASF GitHub Bot logged work on WW-5278:
--

Author: ASF GitHub Bot
Created on: 30/Jan/23 12:49
Start Date: 30/Jan/23 12:49
Worklog Time Spent: 10m 
  Work Description: kusalk commented on code in PR #656:
URL: https://github.com/apache/struts/pull/656#discussion_r1090584457


##
core/src/main/java/com/opensymphony/xwork2/validator/AbstractActionValidatorManager.java:
##
@@ -276,7 +276,7 @@ protected List loadFile(String fileName, 
Class clazz, boolean c
 retList = new 
ArrayList<>(validatorFileParser.parseActionValidatorConfigs(validatorFactory, 
is, fileName));
 }
 } catch (IOException e) {
-LOG.error("Caught exception while loading file {}", fileName, 
e);

Review Comment:
   An IOException can only be thrown by `InputStream::close`





Issue Time Tracking
---

Worklog Id: (was: 842278)
Time Spent: 20m  (was: 10m)

> Clean up duplicated code across ActionValidationManagers
> 
>
> Key: WW-5278
> URL: https://issues.apache.org/jira/browse/WW-5278
> Project: Struts 2
>  Issue Type: Task
>  Components: Core Interceptors
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (WW-5278) Clean up duplicated code across ActionValidationManagers

2023-01-30 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/WW-5278?focusedWorklogId=842275=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842275
 ]

ASF GitHub Bot logged work on WW-5278:
--

Author: ASF GitHub Bot
Created on: 30/Jan/23 12:42
Start Date: 30/Jan/23 12:42
Worklog Time Spent: 10m 
  Work Description: kusalk opened a new pull request, #656:
URL: https://github.com/apache/struts/pull/656

   WW-5278




Issue Time Tracking
---

Worklog Id: (was: 842275)
Remaining Estimate: 0h
Time Spent: 10m

> Clean up duplicated code across ActionValidationManagers
> 
>
> Key: WW-5278
> URL: https://issues.apache.org/jira/browse/WW-5278
> Project: Struts 2
>  Issue Type: Task
>  Components: Core Interceptors
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)