[jira] [Resolved] (TEZ-3683) LocalContainerLauncher#shouldDelete member variable is not used

2017-04-06 Thread Jonathan Eagles (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles resolved TEZ-3683. -- Resolution: Fixed Fix Version/s: TEZ-3334 > LocalContainerLauncher#shouldDelete member

[jira] [Resolved] (TEZ-3682) Pass parameters instead of configuration for changes to support tez shuffle handler

2017-04-06 Thread Jonathan Eagles (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles resolved TEZ-3682. -- Resolution: Fixed Fix Version/s: TEZ-3334 > Pass parameters instead of configuration for

[jira] [Commented] (TEZ-3682) Pass parameters instead of configuration for changes to support tez shuffle handler

2017-04-06 Thread Jonathan Eagles (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958984#comment-15958984 ] Jonathan Eagles commented on TEZ-3682: -- [~kshukla], I changed these lines back to the way before

[jira] [Commented] (TEZ-3683) LocalContainerLauncher#shouldDelete member variable is not used

2017-04-06 Thread Jonathan Eagles (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958998#comment-15958998 ] Jonathan Eagles commented on TEZ-3683: -- Look good, [~kshukla]. Committed to TEZ-3334 feature branch. >

[jira] [Commented] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback

2017-04-06 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959142#comment-15959142 ] Jason Lowe commented on TEZ-3684: - Is it worth putting in some sort of log if we end up not finding a valid

[jira] [Commented] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback

2017-04-06 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959286#comment-15959286 ] Jason Lowe commented on TEZ-3684: - +1 lgtm. > Incorporate first pass non-essential TEZ-3334 pre-merge

[jira] [Commented] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback

2017-04-06 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959228#comment-15959228 ] Jason Lowe commented on TEZ-3684: - Thanks for updating the patch! Does slf4j support %s for parameters?  I

[jira] [Updated] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback

2017-04-06 Thread Jonathan Eagles (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles updated TEZ-3684: - Attachment: TEZ-3684.3.patch [~jlowe], fixed the logging statement in v3 > Incorporate first pass

[jira] [Updated] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback

2017-04-06 Thread Jonathan Eagles (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles updated TEZ-3684: - Attachment: TEZ-3684.1.patch > Incorporate first pass non-essential TEZ-3334 pre-merge feedback >

[jira] [Updated] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback

2017-04-06 Thread Jonathan Eagles (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles updated TEZ-3684: - Attachment: TEZ-3684.2.patch [~jlowe], patch v2 add two warnings regarding the cause of not finding

[jira] [Created] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback

2017-04-06 Thread Jonathan Eagles (JIRA)
Jonathan Eagles created TEZ-3684: Summary: Incorporate first pass non-essential TEZ-3334 pre-merge feedback Key: TEZ-3684 URL: https://issues.apache.org/jira/browse/TEZ-3684 Project: Apache Tez

[jira] [Commented] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback

2017-04-06 Thread Jonathan Eagles (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959092#comment-15959092 ] Jonathan Eagles commented on TEZ-3684: -- [~sseth], This patch has a good portion the minor-nit

[jira] [Resolved] (TEZ-3684) Incorporate first pass non-essential TEZ-3334 pre-merge feedback

2017-04-06 Thread Jonathan Eagles (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles resolved TEZ-3684. -- Resolution: Fixed Fix Version/s: TEZ-3334 Thanks, [~jlowe]. Committed to feature branch

[jira] [Created] (TEZ-3685) ShuffleHandler completedInputSet off-by-one error

2017-04-06 Thread Jonathan Eagles (JIRA)
Jonathan Eagles created TEZ-3685: Summary: ShuffleHandler completedInputSet off-by-one error Key: TEZ-3685 URL: https://issues.apache.org/jira/browse/TEZ-3685 Project: Apache Tez Issue Type:

[jira] [Commented] (TEZ-3680) Optimizations to UnorderedPartitionedKVWriter

2017-04-06 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958516#comment-15958516 ] TezQA commented on TEZ-3680: {color:red}-1 overall{color}. Here are the results of testing the latest

[jira] [Commented] (TEZ-3285) Tez UI: Lock down dependency versions

2017-04-06 Thread Sreenath Somarajapuram (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958386#comment-15958386 ] Sreenath Somarajapuram commented on TEZ-3285: - Thank you so much [~skanekar] [~harishjp]

[jira] [Created] (TEZ-3683) LocalContainerLauncher#shouldDelete member variable is not used

2017-04-06 Thread Kuhu Shukla (JIRA)
Kuhu Shukla created TEZ-3683: Summary: LocalContainerLauncher#shouldDelete member variable is not used Key: TEZ-3683 URL: https://issues.apache.org/jira/browse/TEZ-3683 Project: Apache Tez

[jira] [Updated] (TEZ-3680) Optimizations to UnorderedPartitionedKVWriter

2017-04-06 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajesh Balamohan updated TEZ-3680: -- Attachment: TEZ-3680.2.patch Unordered*Writer was honoring pipelinedshuffle earlier. It is

[jira] [Updated] (TEZ-3683) LocalContainerLauncher#shouldDelete member variable is not used

2017-04-06 Thread Kuhu Shukla (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuhu Shukla updated TEZ-3683: - Attachment: TEZ-3683.001.patch [~jeagles], patch addresses a redundant member in LocalContainerLauncher.

[jira] [Updated] (TEZ-3680) Optimizations to UnorderedPartitionedKVWriter

2017-04-06 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajesh Balamohan updated TEZ-3680: -- Attachment: TEZ-3680.3.patch Thanks @sseth. 1. Removed finalMergeEnabled changes. Will create

[jira] [Comment Edited] (TEZ-3680) Optimizations to UnorderedPartitionedKVWriter

2017-04-06 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960263#comment-15960263 ] Rajesh Balamohan edited comment on TEZ-3680 at 4/7/17 4:39 AM: --- Thanks

[jira] [Commented] (TEZ-3654) CartesianProduct edge won't work with GroupInputEdge

2017-04-06 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960286#comment-15960286 ] Siddharth Seth commented on TEZ-3654: - +1 > CartesianProduct edge won't work with GroupInputEdge >

[jira] [Assigned] (TEZ-3680) Optimizations to UnorderedPartitionedKVWriter

2017-04-06 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Seth reassigned TEZ-3680: --- Assignee: Rajesh Balamohan > Optimizations to UnorderedPartitionedKVWriter >

[jira] [Commented] (TEZ-3680) Optimizations to UnorderedPartitionedKVWriter

2017-04-06 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960292#comment-15960292 ] Siddharth Seth commented on TEZ-3680: - SpillCallable does not notify per partition - is this required?

[jira] [Commented] (TEZ-3285) Tez UI: Lock down dependency versions

2017-04-06 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960305#comment-15960305 ] Siddharth Seth commented on TEZ-3285: - Nede to include the license information for the packages under

Failed: TEZ-3680 PreCommit Build #2367

2017-04-06 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/TEZ-3680 Build: https://builds.apache.org/job/PreCommit-TEZ-Build/2367/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (TEZ-3680) Optimizations to UnorderedPartitionedKVWriter

2017-04-06 Thread Siddharth Seth (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960208#comment-15960208 ] Siddharth Seth commented on TEZ-3680: - On using finalMergeEnabled for PipelinedShuffle - With the