[jira] [Comment Edited] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.

2016-10-19 Thread Sreenath Somarajapuram (JIRA)

[ 
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588241#comment-15588241
 ] 

Sreenath Somarajapuram edited comment on TEZ-3419 at 10/19/16 3:10 PM:
---

Thanks [~hitesh]
Committed to master & branch-0.8.


was (Author: sreenath):
Thanks [~hitesh]
Committed to master.

> Tez UI: Applications page shows error, for users with only DAG level ACL 
> permission.
> 
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
>  Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Fix For: 0.9.0, 0.8.5
>
> Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, Screen Shot 
> 2016-10-13 at 4.37.09 PM.png, Screen Shot 2016-10-17 at 4.11.29 PM.png, 
> Screen Shot 2016-10-17 at 4.11.59 PM.png, Screen Shot 2016-10-17 at 4.12.23 
> PM.png, TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, 
> TEZ-3419.4.patch, TEZ-3419.5.patch, TEZ-3419.6.patch, TEZ-3419.wip.1.patch, 
> Tez data missing.png, YARN & Tez data missing.png, YARN data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to 
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to 
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and 
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details 
> page.
> --- else if AHS is not accessible, display a message in app details tab, 
> something like "Data is not available. Check if you are authorized to access 
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.

2016-10-17 Thread Hitesh Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583809#comment-15583809
 ] 

Hitesh Shah edited comment on TEZ-3419 at 10/17/16 11:17 PM:
-

  - 2 screenshots show spurious data being shown in the UI.
  - 3rd screenshot is for the configs. Configs are not accessible due to 
permission issues but UI says no records found. I think this is a reasonable 
approach for now ( as compared to an error message indicating no data or 
permission issue ) but just wanted to make sure that this was the intention of 
the patch and not an accidental change. 


was (Author: hitesh):
  - 2 screenshots show spurious data being shown in the UI.
  - 3rd screenshot is for the configs. Configs are not accessible due to 
permission issues but UI says no records found. I think this is a reasonable 
approach for now but just wanted to make sure that this was the intention of 
the patch and not an accidental change. 

> Tez UI: Applications page shows error, for users with only DAG level ACL 
> permission.
> 
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
>  Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, Screen Shot 
> 2016-10-13 at 4.37.09 PM.png, Screen Shot 2016-10-17 at 4.11.29 PM.png, 
> Screen Shot 2016-10-17 at 4.11.59 PM.png, Screen Shot 2016-10-17 at 4.12.23 
> PM.png, TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, 
> TEZ-3419.4.patch, TEZ-3419.5.patch, TEZ-3419.wip.1.patch, Tez data 
> missing.png, YARN & Tez data missing.png, YARN data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to 
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to 
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and 
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details 
> page.
> --- else if AHS is not accessible, display a message in app details tab, 
> something like "Data is not available. Check if you are authorized to access 
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.

2016-10-13 Thread Hitesh Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573541#comment-15573541
 ] 

Hitesh Shah edited comment on TEZ-3419 at 10/13/16 11:37 PM:
-

-In any case, I think this patch can go in. +1 after addressing the minor nit 
on the error message which can be changed to say "Some data is not available".- 


was (Author: hitesh):
-In any case, I think this patch can go in. +1 after addressing the minor nit 
on the error message which can be changed to say "Some data is not available". 
- 

> Tez UI: Applications page shows error, for users with only DAG level ACL 
> permission.
> 
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
>  Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, 
> TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, TEZ-3419.4.patch, 
> TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN 
> data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to 
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to 
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and 
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details 
> page.
> --- else if AHS is not accessible, display a message in app details tab, 
> something like "Data is not available. Check if you are authorized to access 
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.

2016-10-13 Thread Hitesh Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573541#comment-15573541
 ] 

Hitesh Shah edited comment on TEZ-3419 at 10/13/16 11:37 PM:
-

-In any case, I think this patch can go in. +1 after addressing the minor nit 
on the error message which can be changed to say "Some data is not available". 
- 


was (Author: hitesh):
In any case, I think this patch can go in. +1 after addressing the minor nit on 
the error message which can be changed to say "Some data is not available".  

> Tez UI: Applications page shows error, for users with only DAG level ACL 
> permission.
> 
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
>  Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, 
> TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, TEZ-3419.4.patch, 
> TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN 
> data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to 
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to 
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and 
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details 
> page.
> --- else if AHS is not accessible, display a message in app details tab, 
> something like "Data is not available. Check if you are authorized to access 
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.

2016-10-13 Thread Hitesh Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573532#comment-15573532
 ] 

Hitesh Shah edited comment on TEZ-3419 at 10/13/16 11:34 PM:
-

-Can you clarify what data is missing on the app details page?- 

Looks like it is the tez version info and application entity + domain info ( 
which I am not sure why we are displaying )


was (Author: hitesh):
Can you clarify what data is missing on the app details page? 

> Tez UI: Applications page shows error, for users with only DAG level ACL 
> permission.
> 
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
>  Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: Screen Shot 2016-10-13 at 4.25.31 PM.png, 
> TEZ-3419.1.patch, TEZ-3419.2.patch, TEZ-3419.3.patch, TEZ-3419.4.patch, 
> TEZ-3419.wip.1.patch, Tez data missing.png, YARN & Tez data missing.png, YARN 
> data missing.png
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to 
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to 
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and 
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details 
> page.
> --- else if AHS is not accessible, display a message in app details tab, 
> something like "Data is not available. Check if you are authorized to access 
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (TEZ-3419) Tez UI: Applications page shows error, for users with only DAG level ACL permission.

2016-09-12 Thread Hitesh Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/TEZ-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485283#comment-15485283
 ] 

Hitesh Shah edited comment on TEZ-3419 at 9/12/16 9:02 PM:
---

To add, the message regarding contacting the admin seems fine but we need a 
link to provide more details on how one would go about verifying the 
acls/permissions, etc.


was (Author: hitesh):
To add, the message regarding contacting the admin seems fine but we need a 
link to provide more details on how one would go about running the checks. 

> Tez UI: Applications page shows error, for users with only DAG level ACL 
> permission.
> 
>
> Key: TEZ-3419
> URL: https://issues.apache.org/jira/browse/TEZ-3419
> Project: Apache Tez
>  Issue Type: Sub-task
>Affects Versions: 0.7.0
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-3419.1.patch, TEZ-3419.wip.1.patch
>
>
> Follow this logic and display better message:
> On loading app details page, send a request to 
> /ws/v1/timeline/TEZ_APPLICATION/tez_
> - If it succeed, display the details page as we do now.
> - If it fails, send a request to 
> /ws/v1/timeline/TEZ_DAG_ID?primaryFilter=applicationId%3A
> -- If it succeed, then we know that DAGs under the app are available and 
> assume that the user doesn't have permission to access app level data.
> --- If AHS is accessible, display application data from there in the details 
> page.
> --- else if AHS is not accessible, display a message in app details tab, 
> something like "Data is not available. Check if you are authorized to access 
> application data!".
> --- Also display the DAGs tab, for the user to see DAGs under that app.
> -- If it fails, display error message as we do now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)