[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[
https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884304#comment-16884304
]
TezQA commented on TEZ-3463:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 24m
49s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
15s{color} | {color:green} tez-dist in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
17s{color} | {color:green} docs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
41s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 Image:yetus/tez:d4a62de |
| JIRA Issue | TEZ-3463 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12841106/TEZ-3463.2.patch |
| Optional Tests | dupname asflicense mvnsite javac javadoc unit xml |
| uname | Linux 902bb8836058 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | master / 4125639 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
| Test Results |
https://builds.apache.org/job/PreCommit-TEZ-Build/149/testReport/ |
| Max. process+thread count | 72 (vs. ulimit of 1) |
| modules | C: tez-dist docs U: . |
| Console output |
https://builds.apache.org/job/PreCommit-TEZ-Build/149/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from
> minimal distribution
>
>
> Key: TEZ-3463
> URL: https://issues.apache.org/jira/browse/TEZ-3463
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
>Priority: Major
> Attachments: TEZ-3463.1.patch, TEZ-3463.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[ https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722861#comment-15722861 ] Jonathan Eagles commented on TEZ-3463: -- Pinging [~mingma], [~hitesh] for comments on latest patch including documentation. > Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from > minimal distribution > > > Key: TEZ-3463 > URL: https://issues.apache.org/jira/browse/TEZ-3463 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3463.1.patch, TEZ-3463.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[ https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713091#comment-15713091 ] Jonathan Eagles commented on TEZ-3463: -- [~mingma], do you have any comments on the documentation regarding clarity? > Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from > minimal distribution > > > Key: TEZ-3463 > URL: https://issues.apache.org/jira/browse/TEZ-3463 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3463.1.patch, TEZ-3463.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[
https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709759#comment-15709759
]
TezQA commented on TEZ-3463:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12841106/TEZ-3463.2.patch
against master revision d6543f3.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2133//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2133//console
This message is automatically generated.
> Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from
> minimal distribution
>
>
> Key: TEZ-3463
> URL: https://issues.apache.org/jira/browse/TEZ-3463
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-3463.1.patch, TEZ-3463.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[ https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709765#comment-15709765 ] Jonathan Eagles commented on TEZ-3463: -- [~hitesh], can you check the patch and documentation now to check correctness and clarity. I have checked hive and pig and for correctness. > Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from > minimal distribution > > > Key: TEZ-3463 > URL: https://issues.apache.org/jira/browse/TEZ-3463 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3463.1.patch, TEZ-3463.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[ https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685626#comment-15685626 ] Ming Ma commented on TEZ-3463: -- We also want MR jars to be excluded for the same reason [~jeagles] mentioned. Agree with [~hitesh] 's summary, the patch + documentation. Just to confirm, there is no issue with higher layer such as Cascading, Hive and Pig? > Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from > minimal distribution > > > Key: TEZ-3463 > URL: https://issues.apache.org/jira/browse/TEZ-3463 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3463.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[ https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563697#comment-15563697 ] Hitesh Shah commented on TEZ-3463: -- We can put this change under a profile if possible and disable it by default for now until we figure out a better long term solution? > Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from > minimal distribution > > > Key: TEZ-3463 > URL: https://issues.apache.org/jira/browse/TEZ-3463 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3463.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[ https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563624#comment-15563624 ] Jonathan Eagles commented on TEZ-3463: -- We provide MR libraries as part of runtime, a new version of MR was rolled out, but tez couldn't use the new feature (fileinputformat v2?) since the the two libraries present in the tez runtime classpath. I can see this going in or not. Users do truly need a version of this in their classpath. In our case, we never want to use the tez provided version. > Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from > minimal distribution > > > Key: TEZ-3463 > URL: https://issues.apache.org/jira/browse/TEZ-3463 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3463.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[ https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563530#comment-15563530 ] Hitesh Shah commented on TEZ-3463: -- When using the minimal tarball in HDFS, we use yarn application classpath which does not include MR jars by default if I am not mistaken. This would end up breaking users that use the minimal tarball (with use cluster libs set to true ) as there would be no MR jars on the classpath ( esp. the ones we directly depend on ). Could you provide more context on the issue you are hitting with the MR jars? Is this on the client where the tez jars from the minimal tarball clash with the default mr jars in hadoop classpath? Or is this for the cluster classpath where the hadoop tarball is used along with the tez minimal tarball? > Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from > minimal distribution > > > Key: TEZ-3463 > URL: https://issues.apache.org/jira/browse/TEZ-3463 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3463.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[ https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563336#comment-15563336 ] Jonathan Eagles commented on TEZ-3463: -- findbugs warning is fixed in TEZ-3464. [~hitesh], can you have a look at this small patch to remove additional mapreduce jars from the minimal build? > Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from > minimal distribution > > > Key: TEZ-3463 > URL: https://issues.apache.org/jira/browse/TEZ-3463 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3463.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3463) Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from minimal distribution
[
https://issues.apache.org/jira/browse/TEZ-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556147#comment-15556147
]
TezQA commented on TEZ-3463:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12832183/TEZ-3463.1.patch
against master revision dceb365.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2026//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/2026//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2026//console
This message is automatically generated.
> Remove hadoop-mapreduce-client-common and hadoop-mapreduce-client-core from
> minimal distribution
>
>
> Key: TEZ-3463
> URL: https://issues.apache.org/jira/browse/TEZ-3463
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-3463.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
