[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[ https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15810943#comment-15810943 ] Siddharth Seth commented on TEZ-3504: - +1 > Tez UI: Duration is displaying invalid values when start or end time is > invalid > --- > > Key: TEZ-3504 > URL: https://issues.apache.org/jira/browse/TEZ-3504 > Project: Apache Tez > Issue Type: Bug >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: DurationValues.png, Error tooltip.png, TEZ-3504.1.patch, > TEZ-3504.2.patch, TEZ-3504.3.patch, TEZ-3504.4.patch, TEZ-3504.5.patch, > TEZ-3504.6.patch, TEZ-3504.WIP.1.patch > > > The UI code must validate start - end times and calculate the duration only > if their values are valid. If not valid a 'Not Available!' could be displayed. > Following validations must be done: > # Start time must be a number greater than 0 > # End time must be a number greater than 0 > # End time must be greater than or equal to start time -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[
https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794959#comment-15794959
]
TezQA commented on TEZ-3504:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12845367/TEZ-3504.6.patch
against master revision 36f2eea.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2160//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2160//console
This message is automatically generated.
> Tez UI: Duration is displaying invalid values when start or end time is
> invalid
> ---
>
> Key: TEZ-3504
> URL: https://issues.apache.org/jira/browse/TEZ-3504
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: DurationValues.png, Error tooltip.png, TEZ-3504.1.patch,
> TEZ-3504.2.patch, TEZ-3504.3.patch, TEZ-3504.4.patch, TEZ-3504.5.patch,
> TEZ-3504.6.patch, TEZ-3504.WIP.1.patch
>
>
> The UI code must validate start - end times and calculate the duration only
> if their values are valid. If not valid a 'Not Available!' could be displayed.
> Following validations must be done:
> # Start time must be a number greater than 0
> # End time must be a number greater than 0
> # End time must be greater than or equal to start time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[
https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714312#comment-15714312
]
TezQA commented on TEZ-3504:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12841416/TEZ-3504.5.patch
against master revision 8079919.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2140//console
This message is automatically generated.
> Tez UI: Duration is displaying invalid values when start or end time is
> invalid
> ---
>
> Key: TEZ-3504
> URL: https://issues.apache.org/jira/browse/TEZ-3504
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: DurationValues.png, Error tooltip.png, TEZ-3504.1.patch,
> TEZ-3504.2.patch, TEZ-3504.3.patch, TEZ-3504.4.patch, TEZ-3504.5.patch,
> TEZ-3504.WIP.1.patch
>
>
> The UI code must validate start - end times and calculate the duration only
> if their values are valid. If not valid a 'Not Available!' could be displayed.
> Following validations must be done:
> # Start time must be a number greater than 0
> # End time must be a number greater than 0
> # End time must be greater than or equal to start time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[
https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710426#comment-15710426
]
TezQA commented on TEZ-3504:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12841187/Error%20tooltip.png
against master revision 8079919.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2136//console
This message is automatically generated.
> Tez UI: Duration is displaying invalid values when start or end time is
> invalid
> ---
>
> Key: TEZ-3504
> URL: https://issues.apache.org/jira/browse/TEZ-3504
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: DurationValues.png, Error tooltip.png, TEZ-3504.1.patch,
> TEZ-3504.2.patch, TEZ-3504.3.patch, TEZ-3504.4.patch, TEZ-3504.WIP.1.patch
>
>
> The UI code must validate start - end times and calculate the duration only
> if their values are valid. If not valid a 'Not Available!' could be displayed.
> Following validations must be done:
> # Start time must be a number greater than 0
> # End time must be a number greater than 0
> # End time must be greater than or equal to start time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[ https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703106#comment-15703106 ] Hitesh Shah commented on TEZ-3504: -- Additional comment related to UX: Should the "Invalid data" have a tool-tip to indicate what the issue is i.e. say something like: "Invalid timestamp data as start time is greater than end time" ? > Tez UI: Duration is displaying invalid values when start or end time is > invalid > --- > > Key: TEZ-3504 > URL: https://issues.apache.org/jira/browse/TEZ-3504 > Project: Apache Tez > Issue Type: Bug >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: DurationValues.png, TEZ-3504.1.patch, TEZ-3504.2.patch, > TEZ-3504.3.patch, TEZ-3504.WIP.1.patch > > > The UI code must validate start - end times and calculate the duration only > if their values are valid. If not valid a 'Not Available!' could be displayed. > Following validations must be done: > # Start time must be a number greater than 0 > # End time must be a number greater than 0 > # End time must be greater than or equal to start time -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[ https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690916#comment-15690916 ] Hitesh Shah commented on TEZ-3504: -- Why is there code duplication in timeline.js and ahs-app.js ? And likewise replication of all tests? Also why does the screenshot show invalid data for the 29th Feb row where start time is same as end time? > Tez UI: Duration is displaying invalid values when start or end time is > invalid > --- > > Key: TEZ-3504 > URL: https://issues.apache.org/jira/browse/TEZ-3504 > Project: Apache Tez > Issue Type: Bug >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: DurationValues.png, TEZ-3504.1.patch, TEZ-3504.2.patch, > TEZ-3504.3.patch > > > The UI code must validate start - end times and calculate the duration only > if their values are valid. If not valid a 'Not Available!' could be displayed. > Following validations must be done: > # Start time must be a number greater than 0 > # End time must be a number greater than 0 > # End time must be greater than or equal to start time -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[
https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689312#comment-15689312
]
TezQA commented on TEZ-3504:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12840203/TEZ-3504.3.patch
against master revision 501a351.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2127//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2127//console
This message is automatically generated.
> Tez UI: Duration is displaying invalid values when start or end time is
> invalid
> ---
>
> Key: TEZ-3504
> URL: https://issues.apache.org/jira/browse/TEZ-3504
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: DurationValues.png, TEZ-3504.1.patch, TEZ-3504.2.patch,
> TEZ-3504.3.patch
>
>
> The UI code must validate start - end times and calculate the duration only
> if their values are valid. If not valid a 'Not Available!' could be displayed.
> Following validations must be done:
> # Start time must be a number greater than 0
> # End time must be a number greater than 0
> # End time must be greater than or equal to start time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[
https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689148#comment-15689148
]
TezQA commented on TEZ-3504:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12840203/TEZ-3504.3.patch
against master revision 501a351.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2125//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2125//console
This message is automatically generated.
> Tez UI: Duration is displaying invalid values when start or end time is
> invalid
> ---
>
> Key: TEZ-3504
> URL: https://issues.apache.org/jira/browse/TEZ-3504
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: DurationValues.png, TEZ-3504.1.patch, TEZ-3504.2.patch,
> TEZ-3504.3.patch
>
>
> The UI code must validate start - end times and calculate the duration only
> if their values are valid. If not valid a 'Not Available!' could be displayed.
> Following validations must be done:
> # Start time must be a number greater than 0
> # End time must be a number greater than 0
> # End time must be greater than or equal to start time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[
https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689145#comment-15689145
]
TezQA commented on TEZ-3504:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12840203/TEZ-3504.3.patch
against master revision 501a351.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2124//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2124//console
This message is automatically generated.
> Tez UI: Duration is displaying invalid values when start or end time is
> invalid
> ---
>
> Key: TEZ-3504
> URL: https://issues.apache.org/jira/browse/TEZ-3504
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: DurationValues.png, TEZ-3504.1.patch, TEZ-3504.2.patch,
> TEZ-3504.3.patch
>
>
> The UI code must validate start - end times and calculate the duration only
> if their values are valid. If not valid a 'Not Available!' could be displayed.
> Following validations must be done:
> # Start time must be a number greater than 0
> # End time must be a number greater than 0
> # End time must be greater than or equal to start time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[
https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688994#comment-15688994
]
TezQA commented on TEZ-3504:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12840098/DurationValues.png
against master revision 501a351.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2123//console
This message is automatically generated.
> Tez UI: Duration is displaying invalid values when start or end time is
> invalid
> ---
>
> Key: TEZ-3504
> URL: https://issues.apache.org/jira/browse/TEZ-3504
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: DurationValues.png, TEZ-3504.1.patch, TEZ-3504.2.patch
>
>
> The UI code must validate start - end times and calculate the duration only
> if their values are valid. If not valid a 'Not Available!' could be displayed.
> Following validations must be done:
> # Start time must be a number greater than 0
> # End time must be a number greater than 0
> # End time must be greater than or equal to start time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[
https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687749#comment-15687749
]
TezQA commented on TEZ-3504:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12840098/DurationValues.png
against master revision 501a351.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2118//console
This message is automatically generated.
> Tez UI: Duration is displaying invalid values when start or end time is
> invalid
> ---
>
> Key: TEZ-3504
> URL: https://issues.apache.org/jira/browse/TEZ-3504
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: DurationValues.png, TEZ-3504.1.patch, TEZ-3504.2.patch
>
>
> The UI code must validate start - end times and calculate the duration only
> if their values are valid. If not valid a 'Not Available!' could be displayed.
> Following validations must be done:
> # Start time must be a number greater than 0
> # End time must be a number greater than 0
> # End time must be greater than or equal to start time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[ https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629887#comment-15629887 ] Hitesh Shah commented on TEZ-3504: -- Why is "undefined" being returned for the following case: endTime > 0 and startTime > 0 and startTime > endTime. This is a bug with respect to data and should likely be displayed as such to indicate that there is some incorrect data instead of showing Not available. > Tez UI: Duration is displaying invalid values when start or end time is > invalid > --- > > Key: TEZ-3504 > URL: https://issues.apache.org/jira/browse/TEZ-3504 > Project: Apache Tez > Issue Type: Bug >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-3504.1.patch > > > The UI code must validate start - end times and calculate the duration only > if their values are valid. If not valid a 'Not Available!' could be displayed. > Following validations must be done: > # Start time must be a number greater than 0 > # End time must be a number greater than 0 > # End time must be greater than or equal to start time -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[
https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623420#comment-15623420
]
TezQA commented on TEZ-3504:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12836202/TEZ-3504.1.patch
against master revision a328d46.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2083//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2083//console
This message is automatically generated.
> Tez UI: Duration is displaying invalid values when start or end time is
> invalid
> ---
>
> Key: TEZ-3504
> URL: https://issues.apache.org/jira/browse/TEZ-3504
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sreenath Somarajapuram
>Assignee: Sreenath Somarajapuram
> Attachments: TEZ-3504.1.patch
>
>
> The UI code must validate start - end times and calculate the duration only
> if their values are valid. If not valid a 'Not Available!' could be displayed.
> Following validations must be done:
> # Start time must be a number greater than 0
> # End time must be a number greater than 0
> # End time must be greater than or equal to start time
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-3504) Tez UI: Duration is displaying invalid values when start or end time is invalid
[ https://issues.apache.org/jira/browse/TEZ-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623371#comment-15623371 ] Harish Jaiprakash commented on TEZ-3504: Patch looks good. > Tez UI: Duration is displaying invalid values when start or end time is > invalid > --- > > Key: TEZ-3504 > URL: https://issues.apache.org/jira/browse/TEZ-3504 > Project: Apache Tez > Issue Type: Bug >Reporter: Sreenath Somarajapuram >Assignee: Sreenath Somarajapuram > Attachments: TEZ-3504.1.patch > > > The UI code must validate start - end times and calculate the duration only > if their values are valid. If not valid a 'Not Available!' could be displayed. > Following validations must be done: > # Start time must be a number greater than 0 > # End time must be a number greater than 0 > # End time must be greater than or equal to start time -- This message was sent by Atlassian JIRA (v6.3.4#6332)
