[jira] [Commented] (TEZ-3933) Remove sleep from test TestExceptionPropagation
[ https://issues.apache.org/jira/browse/TEZ-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471129#comment-16471129 ] Kuhu Shukla commented on TEZ-3933: -- +1. lgtm. Thank you for the updated patch. Committing to master and branch-0.9. > Remove sleep from test TestExceptionPropagation > --- > > Key: TEZ-3933 > URL: https://issues.apache.org/jira/browse/TEZ-3933 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles >Priority: Major > Attachments: TEZ-3933.001.patch, TEZ-3933.002.patch > > > While investigating TEZ-3932, it was found that the test suite takes nearly 2 > minutes to run. After removing the sleep, test suite now takes 40 seconds. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TEZ-3933) Remove sleep from test TestExceptionPropagation
[ https://issues.apache.org/jira/browse/TEZ-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471121#comment-16471121 ] Jonathan Eagles commented on TEZ-3933: -- TestAMRecovery has been failing intermittently recently (RMProxy retry conf problem?). [~kshukla], patch 002 has addressed your comments. > Remove sleep from test TestExceptionPropagation > --- > > Key: TEZ-3933 > URL: https://issues.apache.org/jira/browse/TEZ-3933 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles >Priority: Major > Attachments: TEZ-3933.001.patch, TEZ-3933.002.patch > > > While investigating TEZ-3932, it was found that the test suite takes nearly 2 > minutes to run. After removing the sleep, test suite now takes 40 seconds. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TEZ-3933) Remove sleep from test TestExceptionPropagation
[
https://issues.apache.org/jira/browse/TEZ-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471083#comment-16471083
]
TezQA commented on TEZ-3933:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12922894/TEZ-3933.002.patch
against master revision d0abd3d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.test.TestAMRecovery
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2798//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2798//console
This message is automatically generated.
> Remove sleep from test TestExceptionPropagation
> ---
>
> Key: TEZ-3933
> URL: https://issues.apache.org/jira/browse/TEZ-3933
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
>Priority: Major
> Attachments: TEZ-3933.001.patch, TEZ-3933.002.patch
>
>
> While investigating TEZ-3932, it was found that the test suite takes nearly 2
> minutes to run. After removing the sleep, test suite now takes 40 seconds.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3933) Remove sleep from test TestExceptionPropagation
[ https://issues.apache.org/jira/browse/TEZ-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470958#comment-16470958 ] Jonathan Eagles commented on TEZ-3933: -- Totally agree. Posted a new version of the patch. > Remove sleep from test TestExceptionPropagation > --- > > Key: TEZ-3933 > URL: https://issues.apache.org/jira/browse/TEZ-3933 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles >Priority: Major > Attachments: TEZ-3933.001.patch, TEZ-3933.002.patch > > > While investigating TEZ-3932, it was found that the test suite takes nearly 2 > minutes to run. After removing the sleep, test suite now takes 40 seconds. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TEZ-3933) Remove sleep from test TestExceptionPropagation
[ https://issues.apache.org/jira/browse/TEZ-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470534#comment-16470534 ] Kuhu Shukla commented on TEZ-3933: -- Thank you for the patch [~jeagles]. The sleeps being removed looks good but we may want to remove trailing whitespaces as part of a separate JIRA instead of this one? Let me know your thoughts on this. > Remove sleep from test TestExceptionPropagation > --- > > Key: TEZ-3933 > URL: https://issues.apache.org/jira/browse/TEZ-3933 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles >Priority: Major > Attachments: TEZ-3933.001.patch > > > While investigating TEZ-3932, it was found that the test suite takes nearly 2 > minutes to run. After removing the sleep, test suite now takes 40 seconds. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TEZ-3933) Remove sleep from test TestExceptionPropagation
[ https://issues.apache.org/jira/browse/TEZ-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469263#comment-16469263 ] Jonathan Eagles commented on TEZ-3933: -- Filed TEZ-3934 to address the intermittent test failure in TestSpeculation > Remove sleep from test TestExceptionPropagation > --- > > Key: TEZ-3933 > URL: https://issues.apache.org/jira/browse/TEZ-3933 > Project: Apache Tez > Issue Type: Bug >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles >Priority: Major > Attachments: TEZ-3933.001.patch > > > While investigating TEZ-3932, it was found that the test suite takes nearly 2 > minutes to run. After removing the sleep, test suite now takes 40 seconds. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TEZ-3933) Remove sleep from test TestExceptionPropagation
[
https://issues.apache.org/jira/browse/TEZ-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468096#comment-16468096
]
TezQA commented on TEZ-3933:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12922528/TEZ-3933.001.patch
against master revision 081a64f.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.dag.app.TestSpeculation
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2796//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2796//console
This message is automatically generated.
> Remove sleep from test TestExceptionPropagation
> ---
>
> Key: TEZ-3933
> URL: https://issues.apache.org/jira/browse/TEZ-3933
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
>Priority: Major
> Attachments: TEZ-3933.001.patch
>
>
> While investigating TEZ-3932, it was found that the test suite takes nearly 2
> minutes to run. After removing the sleep, test suite now takes 40 seconds.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
