[GitHub] Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190844337 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,278 @@

[GitHub] limited commented on issue #2331: Traffic Router upgrade Tomcat to 8.5

limited commented on issue #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#issuecomment-392045570 test this please This is an automated message from the Apache

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #955

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1679 originally caused by: GitHub pull request #2331 of commit

[GitHub] limited commented on issue #925: [TC-69] Upgrade Tomcat Version for Traffic Router

limited commented on issue #925: [TC-69] Upgrade Tomcat Version for Traffic Router URL: https://github.com/apache/incubator-trafficcontrol/issues/925#issuecomment-392045445 Very exciting Andy! * Any idea on the HTTPS performance improvements from this upgrade? * Requirements

[GitHub] asfgit commented on issue #2331: Traffic Router upgrade Tomcat to 8.5

asfgit commented on issue #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#issuecomment-392046773 Refer to this link for build results (access rights to CI server needed):

[GitHub] Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190841696 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190840779 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

Vijay-1 commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190866276 ## File path: traffic_ops/app/lib/API/Cachegroup.pm ## @@ -57,6 +57,7 @@ sub index

[GitHub] dangogh commented on issue #2331: Traffic Router upgrade Tomcat to 8.5

dangogh commented on issue #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#issuecomment-392066416 also see in the rat report -- this file doesn't have the Apache license header: ```

[GitHub] asfgit commented on issue #2320: Start of integration tests for Grove

asfgit commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392104967 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2124: Add TO Go deliveryservices routes

asfgit commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-39229 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5

dangogh commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#discussion_r190947658 ## File path: VERSION ## @@ -1 +1 @@ -2.3.0 Review comment: The VERSION change really

[GitHub] dg4prez commented on issue #889: [TC-545] CRConfig should not list teak nodes as edges

dg4prez commented on issue #889: [TC-545] CRConfig should not list teak nodes as edges URL: https://github.com/apache/incubator-trafficcontrol/issues/889#issuecomment-392086475 This was fixed in a previous release. This is

[GitHub] rob05c closed pull request #2333: adds 'view delivery services' link to all server types

rob05c closed pull request #2333: adds 'view delivery services' link to all server types URL: https://github.com/apache/incubator-trafficcontrol/pull/2333 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dg4prez closed issue #889: [TC-545] CRConfig should not list teak nodes as edges

dg4prez closed issue #889: [TC-545] CRConfig should not list teak nodes as edges URL: https://github.com/apache/incubator-trafficcontrol/issues/889 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rob05c closed issue #2323: Feature Request: Show delivery services associated with MSO "Server"

rob05c closed issue #2323: Feature Request: Show delivery services associated with MSO "Server" URL: https://github.com/apache/incubator-trafficcontrol/issues/2323 This is an automated message from the Apache Git Service.

[GitHub] asfgit commented on issue #2302: Add TO Go cdns/name

asfgit commented on issue #2302: Add TO Go cdns/name URL: https://github.com/apache/incubator-trafficcontrol/pull/2302#issuecomment-392109606 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1683/

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #962

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1686 originally caused by: GitHub pull request #2320 of commit

[GitHub] mitchell852 opened a new pull request #2333: adds 'view delivery services' link to all server types

mitchell852 opened a new pull request #2333: adds 'view delivery services' link to all server types URL: https://github.com/apache/incubator-trafficcontrol/pull/2333 fixes #2323 This is an automated message from the Apache

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #956

See

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #957

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1681 originally caused by: GitHub pull request #2320 of commit

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #958

See

[GitHub] mitchell852 commented on issue #2335: Fix for Traffic Router file leak when TM or TO is down

mitchell852 commented on issue #2335: Fix for Traffic Router file leak when TM or TO is down URL: https://github.com/apache/incubator-trafficcontrol/pull/2335#issuecomment-392158797 @dewrich - were all the format changes necessary? maybe they were, just asking.

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r191002483 ## File path: traffic_ops/traffic_ops_golang/crconfig/edgelocations.go ## @@ -57,6

[GitHub] rawlinp opened a new pull request #2337: Geolocation-based client steering

rawlinp opened a new pull request #2337: Geolocation-based client steering URL: https://github.com/apache/incubator-trafficcontrol/pull/2337 By being able to assign coordinates to a delivery service through the Origin API, we can now use that data to optimally sort the list of targets of

[GitHub] asfgit commented on issue #2333: adds 'view delivery services' link to all server types

asfgit commented on issue #2333: adds 'view delivery services' link to all server types URL: https://github.com/apache/incubator-trafficcontrol/pull/2333#issuecomment-392085828 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh commented on issue #2320: Start of integration tests for Grove

dangogh commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392128053 don't forget to add the appropriate Apache license header on any new files...

[GitHub] asfgit commented on issue #2335: Fix for Traffic Router file leak when TM or TO is down

asfgit commented on issue #2335: Fix for Traffic Router file leak when TM or TO is down URL: https://github.com/apache/incubator-trafficcontrol/pull/2335#issuecomment-392151706 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #966

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1690 originally caused by: GitHub pull request #2335 of commit

[GitHub] asfgit commented on issue #2320: Start of integration tests for Grove

asfgit commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392125552 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf

asfgit commented on issue #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/pull/2334#issuecomment-392127881 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #964

See

[GitHub] dewrich closed pull request #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf

dewrich closed pull request #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/pull/2334 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190948333 ## File path: lib/go-tc/cachegroupfallback.go ## @@ -0,0 +1,55 @@ +package tc + +

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190963209 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190950254 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190959281 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190972947 ## File path: traffic_ops/traffic_ops_golang/crconfig/edgelocations.go ## @@ -57,6

[GitHub] asfgit commented on issue #2336: Update TR routes to point to 1.3 TO routes

asfgit commented on issue #2336: Update TR routes to point to 1.3 TO routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2336#issuecomment-392152497 Can one of the admins verify this patch? This is an

[GitHub] dangogh opened a new pull request #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf

dangogh opened a new pull request #2334: TO postinstall -- modify GenerateCert.pm to not overwrite cdn.conf URL: https://github.com/apache/incubator-trafficcontrol/pull/2334 same change as #2329 to GenerateCert.pm which is what's actually used by `_postinstall`

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #963

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1687 originally caused by: GitHub pull request #2320 of commit

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #965

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1689 originally caused by: GitHub pull request #2320 of commit

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #656

See Changes: [dewrich] do the same change in GenerateCert.pm which is used by _postinstall -- [...truncated 1.34 MB...] unit_1 |

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190952902 ## File path: traffic_ops/app/db/migrations/2018052100_cache_group_fallback.sql

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190962982 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190962922 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190962185 ## File path: traffic_ops/app/lib/API/CachegroupFallback.pm ## @@ -0,0 +1,287 @@

[GitHub] rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup

rawlinp commented on a change in pull request #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r190971957 ## File path: traffic_ops/traffic_ops_golang/crconfig/edgelocations.go ## @@ -57,6

[GitHub] asfgit commented on issue #2336: Update TR routes to point to 1.3 TO routes

asfgit commented on issue #2336: Update TR routes to point to 1.3 TO routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2336#issuecomment-392152246 Can one of the admins verify this patch? This is an

[GitHub] rivasj opened a new pull request #2336: Update TR routes to point to 1.3 TO routes

rivasj opened a new pull request #2336: Update TR routes to point to 1.3 TO routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2336 -Updated default TO API paths from 1.1/1.2 to 1.3 -Updated test .json files to return 1.3 TO routes

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #968

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1692 originally caused by: GitHub pull request #2320 of commit

[GitHub] asfgit commented on issue #2320: Start of integration tests for Grove

asfgit commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392204201 Refer to this link for build results (access rights to CI server needed):

[GitHub] ajschmidt commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5

ajschmidt commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#discussion_r191029034 ## File path: VERSION ## @@ -1 +1 @@ -2.3.0 Review comment: I could, but it will

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #967

See

[GitHub] ajschmidt commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5

ajschmidt commented on a change in pull request #2331: Traffic Router upgrade Tomcat to 8.5 URL: https://github.com/apache/incubator-trafficcontrol/pull/2331#discussion_r191029242 ## File path: VERSION ## @@ -1 +1 @@ -2.3.0 Review comment: Oh, and the previous

[GitHub] asfgit commented on issue #2337: Geolocation-based client steering

asfgit commented on issue #2337: Geolocation-based client steering URL: https://github.com/apache/incubator-trafficcontrol/pull/2337#issuecomment-392194464 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #969

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1693 originally caused by: GitHub pull request #2320 of commit

[GitHub] asfgit commented on issue #2320: Start of integration tests for Grove

asfgit commented on issue #2320: Start of integration tests for Grove URL: https://github.com/apache/incubator-trafficcontrol/pull/2320#issuecomment-392205986 Refer to this link for build results (access rights to CI server needed):