Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #734

See Changes: [rob05c] Conversion Utility to modify Traffic Ops profile based on conversion -- [...truncated 2.15 MB...] unit_1 | Parse

[GitHub] rob05c commented on issue #2456: Add TO Go delete deliveryservice_user

rob05c commented on issue #2456: Add TO Go delete deliveryservice_user URL: https://github.com/apache/trafficcontrol/pull/2456#issuecomment-401422731 API tests are in https://github.com/apache/trafficcontrol/pull/2339 This is

[GitHub] ocket8888 commented on issue #2484: Add terminating newline to JSON API responses, so HTTP responses are POSIX text files

ocket commented on issue #2484: Add terminating newline to JSON API responses, so HTTP responses are POSIX text files URL: https://github.com/apache/trafficcontrol/issues/2484#issuecomment-401433997 Hey, sounds good to me. By the way, I can't get into the vpn, slack or email, what's

[GitHub] asfgit commented on issue #2339: Add TO Go users/id/deliveryservices

asfgit commented on issue #2339: Add TO Go users/id/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2339#issuecomment-401430730 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1936/ Test

Jenkins build is back to normal : trafficcontrol-PR #1936

See

[GitHub] ocket8888 edited a comment on issue #2484: Add terminating newline to JSON API responses, so HTTP responses are POSIX text files

ocket edited a comment on issue #2484: Add terminating newline to JSON API responses, so HTTP responses are POSIX text files URL: https://github.com/apache/trafficcontrol/issues/2484#issuecomment-401433997 Hey, sounds good to me.

[GitHub] rob05c commented on issue #2457: Add TO Go post deliveryservice_user

rob05c commented on issue #2457: Add TO Go post deliveryservice_user URL: https://github.com/apache/trafficcontrol/pull/2457#issuecomment-401422696 API tests are in https://github.com/apache/trafficcontrol/pull/2339 This is

[GitHub] dangogh opened a new pull request #2489: Remove `incubator` and `incubating` text

dangogh opened a new pull request #2489: Remove `incubator` and `incubating` text URL: https://github.com/apache/trafficcontrol/pull/2489 removes `-incubating` from source tarball file name and removes vestiges of `-incubator` from github and jenkins paths in the docs. Also removes

[GitHub] asfgit commented on issue #2405: Add Traffic Ops Golang user/current

asfgit commented on issue #2405: Add Traffic Ops Golang user/current URL: https://github.com/apache/trafficcontrol/pull/2405#issuecomment-401478749 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1940/ Test

[GitHub] asfgit commented on issue #2353: Add TO Go regions/name

asfgit commented on issue #2353: Add TO Go regions/name URL: https://github.com/apache/trafficcontrol/pull/2353#issuecomment-401477237 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1938/ Test PASSed.

[GitHub] asfgit commented on issue #2405: Add Traffic Ops Golang user/current

asfgit commented on issue #2405: Add Traffic Ops Golang user/current URL: https://github.com/apache/trafficcontrol/pull/2405#issuecomment-401494943 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1941/ Test

[GitHub] asfgit commented on issue #2489: Remove `incubator` and `incubating` text

asfgit commented on issue #2489: Remove `incubator` and `incubating` text URL: https://github.com/apache/trafficcontrol/pull/2489#issuecomment-401476475 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1937/

[GitHub] asfgit commented on issue #2353: Add TO Go regions/name

asfgit commented on issue #2353: Add TO Go regions/name URL: https://github.com/apache/trafficcontrol/pull/2353#issuecomment-401477974 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1939/ Test PASSed.

Build failed in Jenkins: trafficcontrol-master-build #881

See Changes: [rob05c] Conversion Utility to modify Traffic Ops profile based on conversion -- [...truncated 13.41 MB...] traffic_portal_build_1 | | +--

[GitHub] dangogh commented on a change in pull request #2485: Modify the grove rpm version format

dangogh commented on a change in pull request #2485: Modify the grove rpm version format URL: https://github.com/apache/trafficcontrol/pull/2485#discussion_r199207507 ## File path: grove/build/build_rpm.sh ## @@ -19,6 +19,7 @@ cd "$ROOTDIR/grove"

[GitHub] limited commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7

limited commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7 URL: https://github.com/apache/trafficcontrol/pull/2428#discussion_r199179291 ## File path: traffic_ops/install/bin/convert_profile/convert_profile.go ## @@ -0,0 +1,293 @@

[GitHub] rob05c closed pull request #2428: Utility to update TO profile from ATS6 to ATS7

rob05c closed pull request #2428: Utility to update TO profile from ATS6 to ATS7 URL: https://github.com/apache/trafficcontrol/pull/2428 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] ocket8888 commented on issue #2484: All API responses seemingly in violation of POSIX standards

ocket commented on issue #2484: All API responses seemingly in violation of POSIX standards URL: https://github.com/apache/trafficcontrol/issues/2484#issuecomment-401375622 No, I can't. It just seems like a good quality-of-life update. The newline won't, as you pointed out, affect the

[GitHub] ocket8888 edited a comment on issue #2484: All API responses seemingly in violation of POSIX standards

ocket edited a comment on issue #2484: All API responses seemingly in violation of POSIX standards URL: https://github.com/apache/trafficcontrol/issues/2484#issuecomment-401375622 No, I can't. It just seems like a good quality-of-life update. The newline won't, as you pointed out,

[GitHub] rob05c commented on issue #2483: GET /api/1.3/deliveryservices/{{id}}/servers/eligible returns integers as strings

rob05c commented on issue #2483: GET /api/1.3/deliveryservices/{{id}}/servers/eligible returns integers as strings URL: https://github.com/apache/trafficcontrol/issues/2483#issuecomment-401377943 Git blame on the code shows the function hasn't changed since 11 months ago, so it should

[GitHub] rob05c edited a comment on issue #2483: GET /api/1.3/deliveryservices/{{id}}/servers/eligible returns integers as strings

rob05c edited a comment on issue #2483: GET /api/1.3/deliveryservices/{{id}}/servers/eligible returns integers as strings URL: https://github.com/apache/trafficcontrol/issues/2483#issuecomment-401377943 Git blame on the code shows the function hasn't changed since 11 months ago, so it

[GitHub] rob05c commented on issue #2484: All API responses seemingly in violation of POSIX standards

rob05c commented on issue #2484: All API responses seemingly in violation of POSIX standards URL: https://github.com/apache/trafficcontrol/issues/2484#issuecomment-401381157 Eh, I guess I could support that. I'm not a fan of unnecessary space, but one character isn't going to make a

[GitHub] rob05c commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7

rob05c commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7 URL: https://github.com/apache/trafficcontrol/pull/2428#discussion_r199177537 ## File path: traffic_ops/install/bin/convert_profile/convert_profile.go ## @@ -0,0 +1,293 @@

[GitHub] rob05c commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7

rob05c commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7 URL: https://github.com/apache/trafficcontrol/pull/2428#discussion_r199177537 ## File path: traffic_ops/install/bin/convert_profile/convert_profile.go ## @@ -0,0 +1,293 @@

[GitHub] rob05c commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7

rob05c commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7 URL: https://github.com/apache/trafficcontrol/pull/2428#discussion_r199177537 ## File path: traffic_ops/install/bin/convert_profile/convert_profile.go ## @@ -0,0 +1,293 @@

[GitHub] limited commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7

limited commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7 URL: https://github.com/apache/trafficcontrol/pull/2428#discussion_r199177351 ## File path: traffic_ops/build/traffic_ops.spec ## @@ -140,6 +150,11 @@ Built: %(date) by

[GitHub] ocket8888 commented on issue #2483: GET /api/1.3/deliveryservices/{{id}}/servers/eligible returns integers as strings

ocket commented on issue #2483: GET /api/1.3/deliveryservices/{{id}}/servers/eligible returns integers as strings URL: https://github.com/apache/trafficcontrol/issues/2483#issuecomment-401374664 well if the api defines those to be strings and we're not going to change that, then TP

[GitHub] rob05c commented on issue #2483: GET /api/1.3/deliveryservices/{{id}}/servers/eligible returns integers as strings

rob05c commented on issue #2483: GET /api/1.3/deliveryservices/{{id}}/servers/eligible returns integers as strings URL: https://github.com/apache/trafficcontrol/issues/2483#issuecomment-401376733 Yeah, I'm seeing ints too. I'd be interested to know how @ocket saw strings. We shouldn't

[GitHub] asfgit commented on issue #2428: Utility to update TO profile from ATS6 to ATS7

asfgit commented on issue #2428: Utility to update TO profile from ATS6 to ATS7 URL: https://github.com/apache/trafficcontrol/pull/2428#issuecomment-401384918 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed pull request #2487: remove use of /usr/local/go

mitchell852 closed pull request #2487: remove use of /usr/local/go URL: https://github.com/apache/trafficcontrol/pull/2487 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] mitchell852 commented on issue #2483: GET /api/1.3/deliveryservices/{{id}}/servers/eligible returns integers as strings

mitchell852 commented on issue #2483: GET /api/1.3/deliveryservices/{{id}}/servers/eligible returns integers as strings URL: https://github.com/apache/trafficcontrol/issues/2483#issuecomment-401370721 I think the documentation is wrong (big surprise, right?). I'm seeing ints btw when i

[GitHub] rob05c commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7

rob05c commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7 URL: https://github.com/apache/trafficcontrol/pull/2428#discussion_r199176845 ## File path: traffic_ops/build/traffic_ops.spec ## @@ -112,6 +112,16 @@ Built: %(date) by

[GitHub] mitchell852 closed issue #2043: TP - provide the ability to manage roles/capability mappings

mitchell852 closed issue #2043: TP - provide the ability to manage roles/capability mappings URL: https://github.com/apache/trafficcontrol/issues/2043 This is an automated message from the Apache Git Service. To respond to

[GitHub] mitchell852 commented on issue #2488: Create a capability that can be used to secure API values

mitchell852 commented on issue #2488: Create a capability that can be used to secure API values URL: https://github.com/apache/trafficcontrol/issues/2488#issuecomment-401367631 related to #2037 This is an automated message

[GitHub] asfgit commented on issue #2485: Modify the grove rpm version format

asfgit commented on issue #2485: Modify the grove rpm version format URL: https://github.com/apache/trafficcontrol/pull/2485#issuecomment-401364497 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/1934/ Test

[GitHub] mitchell852 opened a new issue #2488: Create a capability that can be used to secure API values

mitchell852 opened a new issue #2488: Create a capability that can be used to secure API values URL: https://github.com/apache/trafficcontrol/issues/2488 We have some endpoints that contain secure values. For example: GET /api/parameters currently if you are an admin (priv

Build failed in Jenkins: trafficcontrol-master-build #880

See Changes: [mitchell852] remove /usr/local/go from goose install -- use natively-installed go -- [...truncated 19.83 MB...] traffic_portal_build_1 | | +--

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #733

See Changes: [mitchell852] remove /usr/local/go from goose install -- use natively-installed go -- [...truncated 1.92 MB...] unit_1 |

[GitHub] limited commented on issue #2428: Utility to update TO profile from ATS6 to ATS7

limited commented on issue #2428: Utility to update TO profile from ATS6 to ATS7 URL: https://github.com/apache/trafficcontrol/pull/2428#issuecomment-401370086 @rawlinp @dewrich If no other comments, can we please merge? Very low risk change :-)

[GitHub] rob05c commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7

rob05c commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7 URL: https://github.com/apache/trafficcontrol/pull/2428#discussion_r199176929 ## File path: traffic_ops/build/traffic_ops.spec ## @@ -140,6 +150,11 @@ Built: %(date) by