[GitHub] mitchell852 commented on issue #2651: Initial state for new server objects should be PRE_PROD

mitchell852 commented on issue #2651: Initial state for new server objects should be PRE_PROD URL: https://github.com/apache/trafficcontrol/issues/2651#issuecomment-412108014 I'm not sure what is appropriate. You want to start a discussion at d...@trafficcontrol.apache.org? --

[GitHub] asfgit commented on issue #2647: cdn-in-a-box: allow to-access.sh funcs in all containers

asfgit commented on issue #2647: cdn-in-a-box: allow to-access.sh funcs in all containers URL: https://github.com/apache/trafficcontrol/pull/2647#issuecomment-412120218 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcon

Jenkins build is back to normal : trafficcontrol-PR #2228

See

[GitHub] dewrich closed pull request #2647: cdn-in-a-box: allow to-access.sh funcs in all containers

dewrich closed pull request #2647: cdn-in-a-box: allow to-access.sh funcs in all containers URL: https://github.com/apache/trafficcontrol/pull/2647 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

Build failed in Jenkins: trafficcontrol-master-build #987

See Changes: [dewrich] move context to allow to-access.sh funcs in all containers [dewrich] need placeholder file to include this empty dir and not accept any other [dewrich] fix rpm path [dewrich]

Build failed in Jenkins: trafficcontrol-PR #2229

See Changes: [rob05c] add pprof debugging served on localhost:6060 and move db-stats and [rob05c] add configurable timeouts to highly used DB queries [dylan.volz] show / hide TP views based on a users capabili

[GitHub] asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481#issuecomment-412139778 Refer to this link for build results (access rights to CI server needed): https://builds.apach

[GitHub] mitchell852 commented on issue #2651: Initial state for new server objects should be PRE_PROD

mitchell852 commented on issue #2651: Initial state for new server objects should be PRE_PROD URL: https://github.com/apache/trafficcontrol/issues/2651#issuecomment-412152788 just for a little context ![image](https://user-images.githubusercontent.com/251272/43972365-57d05e02-9c91-1

[GitHub] mitchell852 commented on issue #2651: Initial state for new server objects should be PRE_PROD

mitchell852 commented on issue #2651: Initial state for new server objects should be PRE_PROD URL: https://github.com/apache/trafficcontrol/issues/2651#issuecomment-412153077 ^^ maybe that could be configurable. i.e. you can decide which state "new" servers are initially set toor actua

[GitHub] mitchell852 edited a comment on issue #2651: Initial state for new server objects should be PRE_PROD

mitchell852 edited a comment on issue #2651: Initial state for new server objects should be PRE_PROD URL: https://github.com/apache/trafficcontrol/issues/2651#issuecomment-412153077 ^^ maybe that could be configurable. i.e. you can decide which state "new" servers are initially set too

Build failed in Jenkins: trafficcontrol-PR #2230

See Changes: [mitchell852] turn caps on/off based upon setting in tp_properties.json -- [...truncated 20.52 MB...] traffic_portal_build_1 | | | | +-- jsonify@0.0.0 t

[GitHub] asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481#issuecomment-412155047 Refer to this link for build results (access rights to CI server needed): https://builds.apach

[GitHub] guzzijason commented on issue #2651: Initial state for new server objects should be PRE_PROD

guzzijason commented on issue #2651: Initial state for new server objects should be PRE_PROD URL: https://github.com/apache/trafficcontrol/issues/2651#issuecomment-412157801 I'm +1 on enabling the drop down. This is an automa

[GitHub] dangogh opened a new issue #2654: TO Go internal error on /api/users/999/deliveryservices

dangogh opened a new issue #2654: TO Go internal error on /api/users/999/deliveryservices URL: https://github.com/apache/trafficcontrol/issues/2654 in current master, seeing this error in the log: ``` ERROR: deliveryservices.go:50: 2018-08-10T16:43:17.83605499Z: 10.132.71.198:52700 g

[GitHub] rob05c commented on issue #2654: TO Go internal error on /api/users/999/deliveryservices

rob05c commented on issue #2654: TO Go internal error on /api/users/999/deliveryservices URL: https://github.com/apache/trafficcontrol/issues/2654#issuecomment-412170624 Why can it be null in the database? If we have to assign a default in the code if it's null anyway, would it be better t

[GitHub] dangogh opened a new pull request #2655: [Issue 2654] fix deepcachingtype retrieval in users/xx/deliveryservices

dangogh opened a new pull request #2655: [Issue 2654] fix deepcachingtype retrieval in users/xx/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2655 Now handles null properly. This fixes #2654 This

Jenkins build is back to normal : trafficcontrol-PR #2231

See

[GitHub] asfgit commented on issue #2653: Fix TO Go routes to all use transactions and timeouts

asfgit commented on issue #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#issuecomment-412172537 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontro

[GitHub] DylanVolz opened a new pull request #2656: properly handle db timeouts in when checking user during authorization

DylanVolz opened a new pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656 This is an automated message from the Apache Git Servi

[GitHub] rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209355667 ## File path: traffic_ops/traffic_ops_golang/wrappers.go ## @@ -117,7 +1

[GitHub] rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209355981 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@ -63

[GitHub] rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209356185 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@ -63

[GitHub] rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209356185 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@ -63

[GitHub] rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209356693 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@ -63

[GitHub] rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209356954 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@ -63

[GitHub] rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209356954 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@ -63

[GitHub] rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209357334 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@ -63

[GitHub] rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209357334 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@ -63

[GitHub] DylanVolz commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

DylanVolz commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209357639 ## File path: traffic_ops/traffic_ops_golang/auth/authorize.go ## @@

[GitHub] rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209357696 ## File path: traffic_ops/traffic_ops_golang/wrappers.go ## @@ -117,7 +1

[GitHub] asfgit commented on issue #2655: [Issue 2654] fix deepcachingtype retrieval in users/xx/deliveryservices

asfgit commented on issue #2655: [Issue 2654] fix deepcachingtype retrieval in users/xx/deliveryservices URL: https://github.com/apache/trafficcontrol/pull/2655#issuecomment-412176787 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org

Build failed in Jenkins: trafficcontrol-PR #2232

See Changes: [dylan.volz] show / hide TP views based on a users capabilities [dylan.volz] creates a permission utils for methods related to checking [dylan.volz] adds capability checking to dashboard widgets

[GitHub] DylanVolz commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization

DylanVolz commented on a change in pull request #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#discussion_r209358359 ## File path: traffic_ops/traffic_ops_golang/wrappers.go ## @@ -117,7

[GitHub] dg4prez opened a new issue #2657: TO API: unable to write a null or blank value to IPv6

dg4prez opened a new issue #2657: TO API: unable to write a null or blank value to IPv6 URL: https://github.com/apache/trafficcontrol/issues/2657 Created two servers with v6 addresses, then removed the address for one. When removing the second's in traffic portal, an error tells me that i

[GitHub] asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization

asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#issuecomment-412183884 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/

Build failed in Jenkins: trafficcontrol-PR #2233

See Changes: [Dylan_Volz] properly handle db timeouts in when checking user during authorization -- [...truncated 21.22 MB...] traffic_portal_build_1 | | | | +-- jso

Build failed in Jenkins: trafficcontrol-PR #2234

See -- [...truncated 19.20 MB...] traffic_portal_build_1 | | | | +-- jsonify@0.0.0 traffic_portal_build_1 | | | | +-- resumer@0.0.0 traffic_portal_build_1 | | | | `-- throu

[GitHub] asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization

asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#issuecomment-412189645 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/

[GitHub] asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization

asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#issuecomment-412191001 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/

Build failed in Jenkins: trafficcontrol-PR #2235

See -- [...truncated 20.27 MB...] traffic_portal_build_1 | | | | +-- jsonify@0.0.0 traffic_portal_build_1 | | | | +-- resumer@0.0.0 traffic_portal_build_1 | | | | `-- throu

[GitHub] rob05c commented on issue #2656: properly handle db timeouts in when checking user during authorization

rob05c commented on issue #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#issuecomment-412207283 retest this please This is an automated me

[GitHub] asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization

asfgit commented on issue #2656: properly handle db timeouts in when checking user during authorization URL: https://github.com/apache/trafficcontrol/pull/2656#issuecomment-412207826 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/

Build failed in Jenkins: trafficcontrol-PR #2236

See -- GitHub pull request #2656 of commit bf1df22e7e42cde6de19d3cc3a3b0a33f929e7d6, no merge conflicts. Setting status of bf1df22e7e42cde6de19d3cc3a3b0a33f929e7d6 to PENDING with url

[GitHub] asfgit commented on issue #2653: Fix TO Go routes to all use transactions and timeouts

asfgit commented on issue #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#issuecomment-412215675 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontro

Jenkins build is back to normal : trafficcontrol-PR #2237

See

[GitHub] ocket8888 opened a new pull request #2658: Cache script improvements

ocket opened a new pull request #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658 I converted the cache scripts to use the new `to-access.sh` helper functions. Also made minor adjustments to that script, and added to the README. --

Build failed in Jenkins: trafficcontrol-PR #2238

See -- [...truncated 13.24 MB...] traffic_portal_build_1 | | | | +-- jsonify@0.0.0 traffic_portal_build_1 | | | | +-- resumer@0.0.0 traffic_portal_build_1 | | | | `-- throu

[GitHub] asfgit commented on issue #2658: Cache script improvements

asfgit commented on issue #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#issuecomment-412223735 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2238/ Test FAILed.

Jenkins build is back to normal : trafficcontrol-PR #2239

See

[GitHub] asfgit commented on issue #2653: Fix TO Go routes to all use transactions and timeouts

asfgit commented on issue #2653: Fix TO Go routes to all use transactions and timeouts URL: https://github.com/apache/trafficcontrol/pull/2653#issuecomment-412224267 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontro

[GitHub] ocket8888 commented on issue #2658: Cache script improvements

ocket commented on issue #2658: Cache script improvements URL: https://github.com/apache/trafficcontrol/pull/2658#issuecomment-412224658 okay, that commit is literally just README changes. I think the CI is broken This is