Build failed in Jenkins: trafficcontrol-PR #4149

2019-08-15 Thread Apache Jenkins Server
See -- GitHub pull request #2456 of commit 6bb79570dc1c01067c3b7c5cd865a3b987cc, no merge conflicts. Setting status of 6bb79570dc1c01067c3b7c5cd865a3b987cc to PENDING with url

[GitHub] [trafficcontrol] asfgit commented on issue #2456: Add TO Go delete deliveryservice_user

2019-08-15 Thread GitBox
asfgit commented on issue #2456: Add TO Go delete deliveryservice_user URL: https://github.com/apache/trafficcontrol/pull/2456#issuecomment-521669930 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4149/

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
asfgit commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521660504 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4147/ Test PASSed.

Build failed in Jenkins: trafficcontrol-PR #4148

2019-08-15 Thread Apache Jenkins Server
See Changes: [rob] Add TO Go put deliveryservices/id/safe [rob] Add TO Go ds/safe client func, test -- [...truncated 3.05 MB...] traffic_portal_build_1 |

[GitHub] [trafficcontrol] asfgit commented on issue #2455: Add TO Go put deliveryservices/id/safe

2019-08-15 Thread GitBox
asfgit commented on issue #2455: Add TO Go put deliveryservices/id/safe URL: https://github.com/apache/trafficcontrol/pull/2455#issuecomment-521663630 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4148/

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
ocket commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521716358 The best we could do in that direction is return an error without breaking the "API version promise". And actually, that might qualify; not sure.

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3768: Codecov

2019-08-15 Thread GitBox
ocket commented on a change in pull request #3768: Codecov URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314406505 ## File path: traffic_monitor/tests/gocover.bash ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash + +# Licensed under the Apache License,

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3768: Codecov

2019-08-15 Thread GitBox
ocket commented on a change in pull request #3768: Codecov URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314406675 ## File path: traffic_monitor/tests/gocover.bash ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash + +# Licensed under the Apache License,

[GitHub] [trafficcontrol] lbathina commented on a change in pull request #3768: Codecov

2019-08-15 Thread GitBox
lbathina commented on a change in pull request #3768: Codecov URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314377876 ## File path: traffic_monitor/tests/gocover.bash ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash + +# Licensed under the Apache License,

[GitHub] [trafficcontrol] asfgit commented on issue #2456: Add TO Go delete deliveryservice_user

2019-08-15 Thread GitBox
asfgit commented on issue #2456: Add TO Go delete deliveryservice_user URL: https://github.com/apache/trafficcontrol/pull/2456#issuecomment-521683787 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4150/

Jenkins build is back to normal : trafficcontrol-PR #4150

2019-08-15 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] asfgit commented on issue #2457: Add TO Go post deliveryservice_user

2019-08-15 Thread GitBox
asfgit commented on issue #2457: Add TO Go post deliveryservice_user URL: https://github.com/apache/trafficcontrol/pull/2457#issuecomment-521685320 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4151/ Test

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
ocket commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521713196 > _"If you update the name of a capability does it automatically update all the FK references in the api_capabilities table?"_ It can,

[GitHub] [trafficcontrol] rawlinp commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
rawlinp commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521715386 Well, if we make the built-in capabilities immutable the `ON UPDATE CASCADE` is unnecessary. Since TO plugins can access the TODB at startup, I think

[GitHub] [trafficcontrol] lbathina commented on a change in pull request #3768: Codecov

2019-08-15 Thread GitBox
lbathina commented on a change in pull request #3768: Codecov URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314378734 ## File path: traffic_monitor/tests/gocover.bash ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash + +# Licensed under the Apache License,

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
asfgit commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521699235 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4152/ Test PASSed.

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
asfgit commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521712221 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4153/ Test PASSed.

[GitHub] [trafficcontrol] rob05c commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
rob05c commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521712151 >If you update the name of a capability does it automatically update all the FK references in the api_capabilities table? No, but it should.

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
asfgit commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521730744 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4154/ Test PASSed.

[GitHub] [trafficcontrol] lbathina commented on a change in pull request #3768: Codecov

2019-08-15 Thread GitBox
lbathina commented on a change in pull request #3768: Codecov URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314379439 ## File path: traffic_monitor/tests/gocover.bash ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash + +# Licensed under the Apache License,

[GitHub] [trafficcontrol] rawlinp commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
rawlinp commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521707964 Ah, I see now that `capability.name` is used as a FK in the `api_capabilities` table. If you update the name of a capability does it automatically

[GitHub] [trafficcontrol] rob05c edited a comment on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
rob05c edited a comment on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521713551 >Do extensions have access to TODB? Yes. TO Plugins can access anything the main TO app can. If a hook can't access something that's

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
ocket commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521713541 Oh, rob05c beat me to it. But also of note while we're looking, the Role/Capability relationship has the same problem.

[GitHub] [trafficcontrol] rob05c edited a comment on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
rob05c edited a comment on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521713551 >Do extensions have access to TODB? Yes. TO Plugins can access anything the main TO app can. If a hook can't access something that's

[GitHub] [trafficcontrol] rob05c commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
rob05c commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521713551 >Do extensions have access to TODB? Yes. TO Plugins can access anything the main TO app can. If a hook can't access something that's needed, it can

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3768: Codecov

2019-08-15 Thread GitBox
ocket commented on a change in pull request #3768: Codecov URL: https://github.com/apache/trafficcontrol/pull/3768#discussion_r314407957 ## File path: traffic_monitor/tests/gocover.bash ## @@ -0,0 +1,36 @@ +#!/usr/bin/env bash + +# Licensed under the Apache License,

[GitHub] [trafficcontrol] rawlinp merged pull request #3872: fixes broken TO unit tests when change log messages were improved

2019-08-15 Thread GitBox
rawlinp merged pull request #3872: fixes broken TO unit tests when change log messages were improved URL: https://github.com/apache/trafficcontrol/pull/3872 This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] lbathina opened a new issue #3874: Monitoring.json doesn't list the delivery services

2019-08-15 Thread GitBox
lbathina opened a new issue #3874: Monitoring.json doesn't list the delivery services URL: https://github.com/apache/trafficcontrol/issues/3874 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request - [ ] improvement request

[GitHub] [trafficcontrol] ocket8888 merged pull request #3873: fixes inaccurate change log message when queuing/dequeuing server upd…

2019-08-15 Thread GitBox
ocket merged pull request #3873: fixes inaccurate change log message when queuing/dequeuing server upd… URL: https://github.com/apache/trafficcontrol/pull/3873 This is an automated message from the Apache Git Service.

[GitHub] [trafficcontrol] rob05c opened a new pull request #3875: Add TO Go ATS CDN configs

2019-08-15 Thread GitBox
rob05c opened a new pull request #3875: Add TO Go ATS CDN configs URL: https://github.com/apache/trafficcontrol/pull/3875 Draft, still need to add tests. ## What does this PR (Pull Request) do? - [ ] This PR fixes #REPLACE_ME OR is not related to any Issue

Build failed in Jenkins: trafficcontrol-master-build #1465

2019-08-15 Thread Apache Jenkins Server
See Changes: [ocket] fixed inaccurate change log message when queuing/dequeuing server -- [...truncated 2.79 MB...] traffic_portal_build_1 | +

[GitHub] [trafficcontrol] asfgit commented on issue #3873: fixes inaccurate change log message when queuing/dequeuing server upd…

2019-08-15 Thread GitBox
asfgit commented on issue #3873: fixes inaccurate change log message when queuing/dequeuing server upd… URL: https://github.com/apache/trafficcontrol/pull/3873#issuecomment-521816824 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] asfgit commented on issue #3875: Add TO Go ATS CDN configs

2019-08-15 Thread GitBox
asfgit commented on issue #3875: Add TO Go ATS CDN configs URL: https://github.com/apache/trafficcontrol/pull/3875#issuecomment-521841348 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4159/ Test PASSed.

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
asfgit commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521755833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4156/ Test PASSed.

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #3872: fixes broken unit tests when change log messages were improved

2019-08-15 Thread GitBox
mitchell852 opened a new pull request #3872: fixes broken unit tests when change log messages were improved URL: https://github.com/apache/trafficcontrol/pull/3872 ## What does this PR (Pull Request) do? fixes broken unit tests when change log messages were improved no additional

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1500

2019-08-15 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] asfgit commented on issue #3872: fixes broken TO unit tests when change log messages were improved

2019-08-15 Thread GitBox
asfgit commented on issue #3872: fixes broken TO unit tests when change log messages were improved URL: https://github.com/apache/trafficcontrol/pull/3872#issuecomment-521792162 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #3873: fixes inaccurate change log message when queuing/dequeuing server upd…

2019-08-15 Thread GitBox
mitchell852 opened a new pull request #3873: fixes inaccurate change log message when queuing/dequeuing server upd… URL: https://github.com/apache/trafficcontrol/pull/3873 …ates for a cdn ## What does this PR (Pull Request) do? Regardless of whether you were queuing or dequeuing

[GitHub] [trafficcontrol] asfgit commented on issue #3870: Rewrite /capabilities to Go

2019-08-15 Thread GitBox
asfgit commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-521752082 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4155/ Test PASSed.