[GitHub] [trafficcontrol] rgresino opened a new issue #3888: Change Default Query String Behavior in TP to 1 or 2

2019-08-27 Thread GitBox
rgresino opened a new issue #3888: Change Default Query String Behavior in TP to 1 or 2 URL: https://github.com/apache/trafficcontrol/issues/3888 ## I'm submitting a ... - [ ] bug report - [ ] new feature / enhancement request - [ x] improvement request (usability,

[GitHub] [trafficcontrol] asf-ci commented on issue #3688: Add TO Go remap.config

2019-08-27 Thread GitBox
asf-ci commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-525369218 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4180/ Test FAILed.

Build failed in Jenkins: trafficcontrol-PR #4180

2019-08-27 Thread Apache Jenkins Server
See Changes: [rob] Add TO Go remap.config -- [...truncated 3.31 MB...] traffic_portal_build_1 | +-- extend@3.0.2 traffic_portal_build_1 |

[GitHub] [trafficcontrol] asf-ci commented on issue #3688: Add TO Go remap.config

2019-08-27 Thread GitBox
asf-ci commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-525369567 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4181/ Test FAILed.

Build failed in Jenkins: trafficcontrol-PR #4181

2019-08-27 Thread Apache Jenkins Server
See -- GitHub pull request #3688 of commit da76edf6a7e9885626eef2b27e7e410ddf2aea77, no merge conflicts. Setting status of da76edf6a7e9885626eef2b27e7e410ddf2aea77 to PENDING with url

[GitHub] [trafficcontrol] rob05c commented on issue #3688: Add TO Go remap.config

2019-08-27 Thread GitBox
rob05c commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-525369872 retest this please This is an automated message from the Apache Git Service. To respond to

Build failed in Jenkins: trafficcontrol-PR #4182

2019-08-27 Thread Apache Jenkins Server
See -- GitHub pull request #3688 of commit 2aa3fe09720cfb58715548d0cf48cc58e463baec, no merge conflicts. Setting status of 2aa3fe09720cfb58715548d0cf48cc58e463baec to PENDING with url

[GitHub] [trafficcontrol] asf-ci commented on issue #3688: Add TO Go remap.config

2019-08-27 Thread GitBox
asf-ci commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-525369893 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4182/ Test FAILed.

[GitHub] [trafficcontrol] asf-ci commented on issue #3688: Add TO Go remap.config

2019-08-27 Thread GitBox
asf-ci commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-525371365 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4183/ Test FAILed.

Build failed in Jenkins: trafficcontrol-PR #4183

2019-08-27 Thread Apache Jenkins Server
See -- [...truncated 2.95 MB...] traffic_portal_build_1 | +-- extend@3.0.2 traffic_portal_build_1 | +-- forever-agent@0.6.1

[GitHub] [trafficcontrol] asf-ci commented on issue #3688: Add TO Go remap.config

2019-08-27 Thread GitBox
asf-ci commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-525372755 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4184/ Test FAILed.

Build failed in Jenkins: trafficcontrol-PR #4184

2019-08-27 Thread Apache Jenkins Server
See -- [...truncated 3.05 MB...] traffic_portal_build_1 | | `-- stack-trace@0.0.10 traffic_portal_build_1 | +-- morgan@1.9.1 traffic_portal_build_1

Build failed in Jenkins: trafficcontrol-PR #4185

2019-08-27 Thread Apache Jenkins Server
See -- [...truncated 2.97 MB...] traffic_portal_build_1 | +-- forever-agent@0.6.1 traffic_portal_build_1 | +-- form-data@2.3.3

[GitHub] [trafficcontrol] asf-ci commented on issue #3688: Add TO Go remap.config

2019-08-27 Thread GitBox
asf-ci commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-525376451 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4185/ Test FAILed.

[GitHub] [trafficcontrol] rob05c commented on issue #3688: Add TO Go remap.config

2019-08-27 Thread GitBox
rob05c commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-525378556 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] asf-ci commented on issue #3688: Add TO Go remap.config

2019-08-27 Thread GitBox
asf-ci commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-525380569 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4186/ Test PASSed.

Jenkins build is back to normal : trafficcontrol-PR #4186

2019-08-27 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] mhoppa opened a new pull request #3889: Update CIAB docs on how to expose services to localhost

2019-08-27 Thread GitBox
mhoppa opened a new pull request #3889: Update CIAB docs on how to expose services to localhost URL: https://github.com/apache/trafficcontrol/pull/3889 ## What does this PR (Pull Request) do? - [x] This PR fixes is not related to any Issue Following the documentation for

[GitHub] [trafficcontrol] asf-ci commented on issue #3688: Add TO Go remap.config

2019-08-27 Thread GitBox
asf-ci commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-525520504 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4187/ Test PASSed.

[GitHub] [trafficcontrol] jhg03a commented on issue #3888: Change Default Query String Behavior in TP to 1 or 2

2019-08-27 Thread GitBox
jhg03a commented on issue #3888: Change Default Query String Behavior in TP to 1 or 2 URL: https://github.com/apache/trafficcontrol/issues/3888#issuecomment-525476987 I believe preserving the query string as part of the cachekey is the most appropriate project default. It is the most

[GitHub] [trafficcontrol] rawlinp commented on issue #3888: Change Default Query String Behavior in TP to 1 or 2

2019-08-27 Thread GitBox
rawlinp commented on issue #3888: Change Default Query String Behavior in TP to 1 or 2 URL: https://github.com/apache/trafficcontrol/issues/3888#issuecomment-525475103 I believe this is already configurable per TP instance via `traffic_portal_properties.json`, so different companies can

[GitHub] [trafficcontrol] rgresino closed issue #3888: Change Default Query String Behavior in TP to 1 or 2

2019-08-27 Thread GitBox
rgresino closed issue #3888: Change Default Query String Behavior in TP to 1 or 2 URL: https://github.com/apache/trafficcontrol/issues/3888 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] rgresino commented on issue #3888: Change Default Query String Behavior in TP to 1 or 2

2019-08-27 Thread GitBox
rgresino commented on issue #3888: Change Default Query String Behavior in TP to 1 or 2 URL: https://github.com/apache/trafficcontrol/issues/3888#issuecomment-525507790 Fine. I will try to resolve by educating the DS requestors or maybe we could provide better “helper” text. Preserving

[GitHub] [trafficcontrol] asf-ci commented on issue #3889: Update CIAB docs on how to expose services to localhost

2019-08-27 Thread GitBox
asf-ci commented on issue #3889: Update CIAB docs on how to expose services to localhost URL: https://github.com/apache/trafficcontrol/pull/3889#issuecomment-525519243 Can one of the admins verify this patch? This is an

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3889: Update CIAB docs on how to expose services to localhost

2019-08-27 Thread GitBox
ocket commented on a change in pull request #3889: Update CIAB docs on how to expose services to localhost URL: https://github.com/apache/trafficcontrol/pull/3889#discussion_r318365517 ## File path: docs/source/admin/quick_howto/ciab.rst ## @@ -42,7 +42,7 @@ These can

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3889: Update CIAB docs on how to expose services to localhost

2019-08-27 Thread GitBox
mhoppa commented on a change in pull request #3889: Update CIAB docs on how to expose services to localhost URL: https://github.com/apache/trafficcontrol/pull/3889#discussion_r318373352 ## File path: docs/source/admin/quick_howto/ciab.rst ## @@ -42,7 +42,7 @@ These can

[GitHub] [trafficcontrol] ezelkow1 commented on a change in pull request #3762: Add Cache-Side Config Generator

2019-08-27 Thread GitBox
ezelkow1 commented on a change in pull request #3762: Add Cache-Side Config Generator URL: https://github.com/apache/trafficcontrol/pull/3762#discussion_r318183089 ## File path: lib/go-atscfg/volumedotconfig.go ## @@ -0,0 +1,72 @@ +package atscfg + +/* + * Licensed to the

[GitHub] [trafficcontrol] ocket8888 commented on issue #3888: Change Default Query String Behavior in TP to 1 or 2

2019-08-27 Thread GitBox
ocket commented on issue #3888: Change Default Query String Behavior in TP to 1 or 2 URL: https://github.com/apache/trafficcontrol/issues/3888#issuecomment-525389036 Why is using the qstring in the cache key and passing it up "the least desirable option for the CDN"?

[GitHub] [trafficcontrol] ezelkow1 commented on a change in pull request #3762: Add Cache-Side Config Generator

2019-08-27 Thread GitBox
ezelkow1 commented on a change in pull request #3762: Add Cache-Side Config Generator URL: https://github.com/apache/trafficcontrol/pull/3762#discussion_r318195483 ## File path: lib/go-atscfg/volumedotconfig.go ## @@ -0,0 +1,72 @@ +package atscfg + +/* + * Licensed to the

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3762: Add Cache-Side Config Generator

2019-08-27 Thread GitBox
ocket commented on a change in pull request #3762: Add Cache-Side Config Generator URL: https://github.com/apache/trafficcontrol/pull/3762#discussion_r318190112 ## File path: lib/go-atscfg/volumedotconfig.go ## @@ -0,0 +1,72 @@ +package atscfg + +/* + * Licensed to