[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320647870 ## File path: docs/source/api/cachegroups_id_parameters.rst ## @@ -28,6 +28,14 @@ Gets all the

[GitHub] [trafficcontrol] rawlinp edited a comment on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN.

2019-09-04 Thread GitBox
rawlinp edited a comment on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN. URL: https://github.com/apache/trafficcontrol/issues/3893#issuecomment-527981579 If adding a DB constraint means existing DB violations

[GitHub] [trafficcontrol] rob05c commented on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN.

2019-09-04 Thread GitBox
rob05c commented on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN. URL: https://github.com/apache/trafficcontrol/issues/3893#issuecomment-527985241 > "[we] shouldn't hold an upgrade hostage over database state"

[GitHub] [trafficcontrol] rawlinp commented on issue #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
rawlinp commented on issue #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#issuecomment-528001537 add to whitelist This is an automated message from the Apache Git

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320916648 ## File path: misc/kickstart_create_network_line.py ## @@ -215,12 +222,12 @@ def

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320919332 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,97 @@

[GitHub] [trafficcontrol] asf-ci commented on issue #3641: Pylint configuration is now agreed-upon

2019-09-04 Thread GitBox
asf-ci commented on issue #3641: Pylint configuration is now agreed-upon URL: https://github.com/apache/trafficcontrol/pull/3641#issuecomment-528044460 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4197/

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320755402 ## File path: traffic_ops/testing/api/v14/cachegroups_parameters_test.go ## @@ -0,0 +1,91 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320753420 ## File path: traffic_ops/testing/api/v14/cachegroups_parameters_test.go ## @@ -0,0 +1,91 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320748367 ## File path: lib/go-tc/cachegroup_parameters.go ## @@ -0,0 +1,32 @@ +package tc + +/* + *

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320754829 ## File path: traffic_ops/testing/api/v14/cachegroups_parameters_test.go ## @@ -0,0 +1,91 @@

[GitHub] [trafficcontrol] ocket8888 commented on issue #3891: Internal Server Error message when create a new role

2019-09-04 Thread GitBox
ocket commented on issue #3891: Internal Server Error message when create a new role URL: https://github.com/apache/trafficcontrol/issues/3891#issuecomment-527983400 The issue is a nil dereference causing a runtime panic [in the endpoint's

[GitHub] [trafficcontrol] rawlinp commented on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN.

2019-09-04 Thread GitBox
rawlinp commented on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN. URL: https://github.com/apache/trafficcontrol/issues/3893#issuecomment-527992782 +1 on adding an API constraint against invalid input not requiring

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320922075 ## File path: misc/kickstart_create_network_line.py ## @@ -231,43 +238,46 @@ def

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320927217 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,97 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320848632 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,97 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320845597 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,97 @@

[GitHub] [trafficcontrol] rawlinp closed issue #3897: TP, TO: 503 Service Unavailable error on generating SSL keys for DS

2019-09-04 Thread GitBox
rawlinp closed issue #3897: TP,TO: 503 Service Unavailable error on generating SSL keys for DS URL: https://github.com/apache/trafficcontrol/issues/3897 This is an automated message from the Apache Git Service. To respond

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320910049 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,97 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320920276 ## File path: misc/kickstart_create_network_line.py ## @@ -231,43 +238,46 @@ def

[GitHub] [trafficcontrol] rawlinp commented on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN.

2019-09-04 Thread GitBox
rawlinp commented on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN. URL: https://github.com/apache/trafficcontrol/issues/3893#issuecomment-527981579 If adding a DB constraint means existing DB violations would make

[GitHub] [trafficcontrol] ocket8888 commented on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN.

2019-09-04 Thread GitBox
ocket commented on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN. URL: https://github.com/apache/trafficcontrol/issues/3893#issuecomment-527986640 > _" I wouldn't think an API constraint would need a

Jenkins build is back to normal : trafficcontrol-PR #4196

2019-09-04 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] asf-ci commented on issue #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
asf-ci commented on issue #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#issuecomment-527998529 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320900012 ## File path: misc/kickstart_create_network_line.py ## @@ -215,12 +222,12 @@ def

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320897993 ## File path: misc/kickstart_create_network_line.py ## @@ -14,60 +14,56 @@ # -'''

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320898799 ## File path: misc/kickstart_create_network_line.py ## @@ -109,7 +105,8 @@ def

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320900810 ## File path: misc/kickstart_create_network_line.py ## @@ -231,43 +238,46 @@ def

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320911626 ## File path: misc/kickstart_create_network_line.py ## @@ -14,60 +14,56 @@ # -'''

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320914157 ## File path: misc/kickstart_create_network_line.py ## @@ -14,60 +14,56 @@ # -'''

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320913400 ## File path: misc/kickstart_create_network_line.py ## @@ -231,43 +238,46 @@ def

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script

2019-09-04 Thread GitBox
rawlinp commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320915439 ## File path: misc/kickstart_create_network_line.py ## @@ -231,43 +238,46 @@ def

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320760370 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -119,6 +119,8 @@ func

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320754572 ## File path: traffic_ops/testing/api/v14/cachegroups_parameters_test.go ## @@ -0,0 +1,91 @@

[GitHub] [trafficcontrol] ocket8888 commented on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN.

2019-09-04 Thread GitBox
ocket commented on issue #3893: Add a database constraint preventing assigning Servers from one CDN to a DeliveryService on a different CDN. URL: https://github.com/apache/trafficcontrol/issues/3893#issuecomment-527934357 This is technically a breaking change, right? I think the exact

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321002338 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321000462 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
ocket commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321002901 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
rob05c commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321002073 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
rob05c commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321002073 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321002280 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@

[GitHub] [trafficcontrol] asf-ci commented on issue #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
asf-ci commented on issue #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#issuecomment-528112709 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
rob05c commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321002073 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r321006287 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,111 @@

[GitHub] [trafficcontrol] asf-ci commented on issue #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
asf-ci commented on issue #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#issuecomment-528143842 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] asf-ci commented on issue #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
asf-ci commented on issue #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#issuecomment-528159074 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320969279 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,97 @@

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go

2019-09-04 Thread GitBox
mhoppa commented on a change in pull request #3900: Rewrite /cachegroups/{{id}}/parameters to Go URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320968699 ## File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go ## @@ -0,0 +1,97 @@