[GitHub] [trafficcontrol] rob05c commented on issue #3966: Add server capabilities API

rob05c commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540240343 > Should POST/DELETE only be admin? Right now I have it set to Operations. I think Ops is right. Admin vs Ops is somewhat nebulous, but I think

[GitHub] [trafficcontrol] ocket8888 merged pull request #3899: Add TO Go server cache configs

ocket merged pull request #3899: Add TO Go server cache configs URL: https://github.com/apache/trafficcontrol/pull/3899 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r333279081 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,162 @@ + +# Server Capabilities + +##

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r333278919 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,162 @@ + +# Server Capabilities + +##

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r333279220 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,162 @@ + +# Server Capabilities + +##

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

ocket commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-540221525 That thread - though it was swiftly derailed - was only about deprecating `/capabilities/{name}`, and while deprecating methods other than GET was

[GitHub] [trafficcontrol] jheitz200 commented on a change in pull request #3964: Add GET/POST/DELETE for server_server_capabilities

jheitz200 commented on a change in pull request #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#discussion_r333248544 ## File path: lib/go-tc/server_capability.go ## @@ -0,0 +1,9 @@ +package tc Review

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3972: Add Server Capabilities blueprint

ocket commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r333279942 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,162 @@ + +# Server Capabilities + +##

[GitHub] [trafficcontrol] ocket8888 commented on issue #3954: Added deprecation notices for /user/current/update

ocket commented on issue #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#issuecomment-540294066 This took **hours** to figure out. Turns out, [ is **VERY** different than ( in Perl.

[GitHub] [trafficcontrol] jheitz200 commented on a change in pull request #3964: Add GET/POST/DELETE for server_server_capabilities

jheitz200 commented on a change in pull request #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#discussion_r333250919 ## File path: lib/go-tc/server_capability.go ## @@ -0,0 +1,28 @@ +package tc Review

[GitHub] [trafficcontrol] mhoppa commented on issue #3880: Rewrote /capabilities/{{name}} to Go

mhoppa commented on issue #3880: Rewrote /capabilities/{{name}} to Go URL: https://github.com/apache/trafficcontrol/pull/3880#issuecomment-540218712 based on https://lists.apache.org/thread.html/cfd3a6d631f2c7510e3a15ee051840a9f04f3f0aa0c2696e460c9ab9@%3Cdev.trafficcontrol.apache.org%3E

[GitHub] [trafficcontrol] jheitz200 commented on a change in pull request #3964: Add GET/POST/DELETE for server_server_capabilities

jheitz200 commented on a change in pull request #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#discussion_r333248544 ## File path: lib/go-tc/server_capability.go ## @@ -0,0 +1,9 @@ +package tc Review

[GitHub] [trafficcontrol] ocket8888 opened a new issue #3975: Environment Variables override explicit configuration in client tests

ocket opened a new issue #3975: Environment Variables override explicit configuration in client tests URL: https://github.com/apache/trafficcontrol/issues/3975 ## I'm submitting a ... - bug report ## Traffic Control components affected ... - Traffic Control Client (Go)

[GitHub] [trafficcontrol] asf-ci commented on issue #3899: Add TO Go server cache configs

asf-ci commented on issue #3899: Add TO Go server cache configs URL: https://github.com/apache/trafficcontrol/pull/3899#issuecomment-540244779 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4437/

Build failed in Jenkins: trafficcontrol-PR #4438

See Changes: -- GitHub pull request #3875 of commit 55d64f4cd96b6481c71cf02a1b34b837e56d2434, has merge conflicts. Running as SYSTEM !!! PR mergeability status has changed !!! PR

[GitHub] [trafficcontrol] asf-ci commented on issue #3875: Add TO Go ATS CDN configs

asf-ci commented on issue #3875: Add TO Go ATS CDN configs URL: https://github.com/apache/trafficcontrol/pull/3875#issuecomment-540250816 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4438/

Jenkins build is back to normal : trafficcontrol-PR #4440

See

[GitHub] [trafficcontrol] asf-ci commented on issue #3954: Added deprecation notices for /user/current/update

asf-ci commented on issue #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#issuecomment-540296449 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ocket8888 commented on issue #3880: Rewrote /capabilities/{{name}} to Go

ocket commented on issue #3880: Rewrote /capabilities/{{name}} to Go URL: https://github.com/apache/trafficcontrol/pull/3880#issuecomment-540224884 That thread never reached a decision as to whether or not deprecated routes ought to be rewritten. If a decision to not rewrite these

[GitHub] [trafficcontrol] ocket8888 edited a comment on issue #3954: Added deprecation notices for /user/current/update

ocket edited a comment on issue #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#issuecomment-540294066 This took **hours** to figure out. Turns out, [ is **VERY** different from ( in Perl.

[GitHub] [trafficcontrol] mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540253926 I added this comment to the blueprint regarding the need for bulk assignment (or deletion) of servers to a server

[GitHub] [trafficcontrol] asf-ci commented on issue #3875: Add TO Go ATS CDN configs

asf-ci commented on issue #3875: Add TO Go ATS CDN configs URL: https://github.com/apache/trafficcontrol/pull/3875#issuecomment-540262236 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4439/

Build failed in Jenkins: trafficcontrol-PR #4439

See Changes: [ocket] Add TO Go server cache configs (#3899) [rob] Add TO Go ATS CDN configs [rob] Change atscfg ds name trimming to use funcs [rob] Add CDN configs to generator [rob] Fix test for

[GitHub] [trafficcontrol] mitchell852 merged pull request #3883: Fixed double-build of TR RPMs in CiaB makefile

mitchell852 merged pull request #3883: Fixed double-build of TR RPMs in CiaB makefile URL: https://github.com/apache/trafficcontrol/pull/3883 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540051772 > yep! @mitchell852 that would look like: > > ``` >{ >"response": [ >{

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3972: Add Server Capabilities blueprint

rob05c commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r333089204 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,162 @@ + +# Server Capabilities + +## Problem

[GitHub] [trafficcontrol] mitchell852 commented on issue #3966: Add server capabilities API

mitchell852 commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540061661 i don't suppose you happened to add entries to seeds.sql for creating a "capability" (i'm talking about a user capability here) like the

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3966: Add server capabilities API

mitchell852 edited a comment on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540061661 i don't suppose you happened to add entries to seeds.sql for creating a "capability" (i'm talking about a user capability here) like the

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3966: Add server capabilities API

mitchell852 edited a comment on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540061661 i don't suppose you happened to add entries to seeds.sql for creating a "capability" (i'm talking about a user capability here) like the

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3966: Add server capabilities API

mitchell852 edited a comment on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540061661 i don't suppose you happened to add entries to seeds.sql for creating a "capability" (i'm talking about a user capability here) like the

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3971: Add server_capabilities API docs

mhoppa commented on a change in pull request #3971: Add server_capabilities API docs URL: https://github.com/apache/trafficcontrol/pull/3971#discussion_r333043201 ## File path: docs/source/api/server_capabilities.rst ## @@ -0,0 +1,190 @@ +.. +.. +.. Licensed under the

[GitHub] [trafficcontrol] mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540045010 without reading thru the code does DELETE ensure that no delivery services are currently assigned to the server that

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3972: Add Server Capabilities blueprint

ocket commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r333075565 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,162 @@ + +# Server Capabilities Review

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3972: Add Server Capabilities blueprint

ocket commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r333070312 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,162 @@ + +# Server Capabilities + +##

[GitHub] [trafficcontrol] mhoppa commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mhoppa commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540048971 yep! @mitchell852 that would look like: ``` { "response": [ {

[GitHub] [trafficcontrol] rob05c commented on issue #3966: Add server capabilities API

rob05c commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540057546 >without reading thru the code, does DELETE validate that the "server capability" is: >a. not being used by any server and >b. is not

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3972: Add Server Capabilities blueprint

rob05c commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r333094054 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,162 @@ + +# Server Capabilities Review

[GitHub] [trafficcontrol] asf-ci commented on issue #3972: Add Server Capabilities blueprint

asf-ci commented on issue #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#issuecomment-540064276 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4432/

[GitHub] [trafficcontrol] asf-ci commented on issue #3971: Add server_capabilities API docs

asf-ci commented on issue #3971: Add server_capabilities API docs URL: https://github.com/apache/trafficcontrol/pull/3971#issuecomment-540068003 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4433/

[GitHub] [trafficcontrol] ocket8888 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

ocket commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540075579 well you can fetch a server's details from its hostname. What would help is if a server automatically came with its list of

[GitHub] [trafficcontrol] mhoppa commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mhoppa commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540046101 @mitchell852 makes sense to me :) it does not as we do not have the association on delivery service to server capability yet.

[GitHub] [trafficcontrol] mhoppa commented on issue #3966: Add server capabilities API

mhoppa commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540058711 > > without reading thru the code, does DELETE validate that the "server capability" is: > > > a. not being used by any server and > > b. is

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3972: Add Server Capabilities blueprint

rob05c commented on a change in pull request #3972: Add Server Capabilities blueprint URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r333092037 ## File path: blueprints/server-capabilitites.md ## @@ -0,0 +1,162 @@ + +# Server Capabilities + +## Problem

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3971: Add server_capabilities API docs

rawlinp commented on a change in pull request #3971: Add server_capabilities API docs URL: https://github.com/apache/trafficcontrol/pull/3971#discussion_r333096916 ## File path: docs/source/api/server_capabilities.rst ## @@ -0,0 +1,190 @@ +.. +.. +.. Licensed under the

[GitHub] [trafficcontrol] mhoppa commented on issue #3971: Add server_capabilities API docs

mhoppa commented on issue #3971: Add server_capabilities API docs URL: https://github.com/apache/trafficcontrol/pull/3971#issuecomment-540072058 Im fine waiting for that @rawlinp actually might be good because then we can include screen shots of the front end and use of the endpoints

[GitHub] [trafficcontrol] rob05c commented on issue #3962: Add atscfg remap.config tests

rob05c commented on issue #3962: Add atscfg remap.config tests URL: https://github.com/apache/trafficcontrol/pull/3962#issuecomment-540080137 >I do think use of table driven tests Huh, TIL. I do that a lot, didn't know it had a name. But, if we wanted to reduce the

[GitHub] [trafficcontrol] mitchell852 commented on issue #3966: Add server capabilities API

mitchell852 commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540043806 without reading thru the code, does DELETE validate that the "server capability" is: a. not being used by any server and b. is not

[GitHub] [trafficcontrol] mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540047268 @mhoppa - can you give me an example of what the response to this would look like: GET

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mitchell852 edited a comment on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540051772 > yep! @mitchell852 that would look like: > > ``` >{ >"response": [ >

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update

mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#discussion_r333079221 ## File path: traffic_ops/app/lib/MojoPlugins/Response.pm ## @@ -119,6 +119,27 @@ sub

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update

mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#discussion_r333078932 ## File path: traffic_ops/app/lib/API/User.pm ## @@ -599,6 +599,123 @@ sub current {

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3966: Add server capabilities API

mitchell852 edited a comment on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540061661 i don't suppose you happened to add entries to seeds.sql for creating a "capability" (i'm talking about a user capability here) like the

[GitHub] [trafficcontrol] rawlinp commented on issue #3971: Add server_capabilities API docs

rawlinp commented on issue #3971: Add server_capabilities API docs URL: https://github.com/apache/trafficcontrol/pull/3971#issuecomment-540071587 Sure, I can take a shot, but we should probably have more holistic documentation PR describing how to use all the endpoints together.

[GitHub] [trafficcontrol] mhoppa commented on issue #3929: Rewrote /user/reset_password to Go

mhoppa commented on issue #3929: Rewrote /user/reset_password to Go URL: https://github.com/apache/trafficcontrol/pull/3929#issuecomment-540077170 Since #3925 is merged want to merge this with master and mark it as non draft?

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3954: Added deprecation notices for /user/current/update

ocket commented on a change in pull request #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#discussion_r333111865 ## File path: traffic_ops/app/lib/API/User.pm ## @@ -599,6 +599,123 @@ sub current {

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation

mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation URL: https://github.com/apache/trafficcontrol/pull/3766#discussion_r333110700 ## File path: docs/source/api/cachegroups.rst ## @@ -123,19 +130,25 @@ Creates a :term:`Cache Group`

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation

mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation URL: https://github.com/apache/trafficcontrol/pull/3766#discussion_r333110506 ## File path: docs/source/api/cachegroup_fallbacks.rst ## @@ -19,6 +19,10 @@ ``cachegroup_fallbacks``

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update

mhoppa commented on a change in pull request #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#discussion_r333115367 ## File path: traffic_ops/app/lib/API/User.pm ## @@ -599,6 +599,123 @@ sub current {

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3766: Cachegroup fallbacks deprecation

ocket commented on a change in pull request #3766: Cachegroup fallbacks deprecation URL: https://github.com/apache/trafficcontrol/pull/3766#discussion_r333126189 ## File path: docs/source/api/cachegroups.rst ## @@ -123,19 +130,25 @@ Creates a :term:`Cache Group`

[GitHub] [trafficcontrol] ajschmidt commented on a change in pull request #3961: added ability to select TLS version in TR

ajschmidt commented on a change in pull request #3961: added ability to select TLS version in TR URL: https://github.com/apache/trafficcontrol/pull/3961#discussion_r333116037 ## File path:

[GitHub] [trafficcontrol] mitchell852 commented on issue #3966: Add server capabilities API

mitchell852 commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540090948 > Should POST/DELETE only be admin? Right now I have it set to Operations. probably a question for @rob05c

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mitchell852 edited a comment on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540091783 > well you can fetch a server's details from its hostname. What would help is if a server automatically came with

[GitHub] [trafficcontrol] mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540091783 > well you can fetch a server's details from its hostname. What would help is if a server automatically came with its

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mitchell852 edited a comment on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540119364 you may need to add "user capabilities" to seeds.sql for these new endpoints. i.e.

[GitHub] [trafficcontrol] mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

mitchell852 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540119364 you may need to add "user capabilities" for these new endpoints. i.e. server-server-capabilities-read

[GitHub] [trafficcontrol] ocket8888 commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

ocket commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540120707 Right that's what I'm saying. If you want full server information in this payload, then you've basically created an

[GitHub] [trafficcontrol] asf-ci commented on issue #3966: Add server capabilities API

asf-ci commented on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540120851 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4435/

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation

mhoppa commented on a change in pull request #3766: Cachegroup fallbacks deprecation URL: https://github.com/apache/trafficcontrol/pull/3766#discussion_r333126435 ## File path: docs/source/api/cachegroups.rst ## @@ -123,19 +130,25 @@ Creates a :term:`Cache Group`

[GitHub] [trafficcontrol] asf-ci commented on issue #3929: Rewrote /user/reset_password to Go

asf-ci commented on issue #3929: Rewrote /user/reset_password to Go URL: https://github.com/apache/trafficcontrol/pull/3929#issuecomment-540093112 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4434/

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3954: Added deprecation notices for /user/current/update

ocket commented on a change in pull request #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#discussion_r333128810 ## File path: traffic_ops/app/lib/API/User.pm ## @@ -599,6 +599,123 @@ sub current {

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

ocket commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r333199475 ## File path: traffic_ops/traffic_ops_golang/role/roles.go ## @@ -122,9 +122,11 @@ func

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

ocket commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r333201940 ## File path: docs/source/api/roles.rst ## @@ -65,19 +84,236 @@ Response Structure

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

ocket commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r333201791 ## File path: traffic_ops/traffic_ops_golang/role/roles.go ## @@ -177,12 +179,16 @@

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r333202515 ## File path: docs/source/api/roles.rst ## @@ -65,19 +84,236 @@ Response Structure

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r333202515 ## File path: docs/source/api/roles.rst ## @@ -65,19 +84,236 @@ Response Structure

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

ocket commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r333203902 ## File path: docs/source/api/roles.rst ## @@ -65,19 +84,236 @@ Response Structure

[GitHub] [trafficcontrol] asf-ci commented on issue #3973: Fixed Regional Geo Blocking on Steering Delivery Services

asf-ci commented on issue #3973: Fixed Regional Geo Blocking on Steering Delivery Services URL: https://github.com/apache/trafficcontrol/pull/3973#issuecomment-540176605 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go

mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333210764 ## File path: traffic_ops/testing/api/v14/capabilities_test.go ## @@ -0,0 +1,159 @@ +package v14 + +/* + * Licensed

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go

mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333213972 ## File path: traffic_ops/traffic_ops_golang/capabilities/capabilities.go ## @@ -0,0 +1,305 @@ +package

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go

mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333210971 ## File path: traffic_ops/testing/api/v14/capabilities_test.go ## @@ -0,0 +1,159 @@ +package v14 + +/* + * Licensed

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go

mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333216351 ## File path: traffic_ops/traffic_ops_golang/capabilities/capabilities.go ## @@ -0,0 +1,305 @@ +package

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go

mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333211816 ## File path: traffic_ops/testing/api/v14/capabilities_test.go ## @@ -0,0 +1,159 @@ +package v14 + +/* + * Licensed

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go

mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333209076 ## File path: traffic_ops/client/capability.go ## @@ -0,0 +1,121 @@ +package client + +/* + * Licensed under the

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go

mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333208376 ## File path: traffic_ops/client/capability.go ## @@ -0,0 +1,121 @@ +package client + +/* + * Licensed under the

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go

mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333215404 ## File path: traffic_ops/traffic_ops_golang/capabilities/capabilities.go ## @@ -0,0 +1,305 @@ +package

[GitHub] [trafficcontrol] mhoppa commented on issue #3870: Rewrite /capabilities to Go

mhoppa commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-540179090 Also some merge conflicts to fix This is an automated message from the Apache Git

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go

mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333214722 ## File path: traffic_ops/traffic_ops_golang/capabilities/capabilities.go ## @@ -0,0 +1,305 @@ +package

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go

mhoppa commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333202014 ## File path: lib/go-tc/capabilities.go ## @@ -0,0 +1,38 @@ +package tc + +/* + * Licensed to the Apache Software

[GitHub] [trafficcontrol] dneuman64 opened a new pull request #3973: Fixed Regional Geo Blocking on Steering Delivery Services

dneuman64 opened a new pull request #3973: Fixed Regional Geo Blocking on Steering Delivery Services URL: https://github.com/apache/trafficcontrol/pull/3973 ## What does this PR (Pull Request) do? - [ x] This PR fixes #3910 ## Which Traffic Control components are

[GitHub] [trafficcontrol] ocket8888 edited a comment on issue #3954: Added deprecation notices for /user/current/update

ocket edited a comment on issue #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#issuecomment-540151369 Well, actually, it is. The success message is in a sub-list for some reason. I'll try to figure out why it's

[GitHub] [trafficcontrol] ocket8888 commented on issue #3954: Added deprecation notices for /user/current/update

ocket commented on issue #3954: Added deprecation notices for /user/current/update URL: https://github.com/apache/trafficcontrol/pull/3954#issuecomment-540151369 Well, technically, it is I'll try to figure out why it's doing that.

[GitHub] [trafficcontrol] rawlinp commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities

rawlinp commented on issue #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#issuecomment-540140162 ID and hostname seem fine. That is at least enough information to link to the server page if someone wanted to see a

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r333195222 ## File path: traffic_ops/traffic_ops_golang/role/roles.go ## @@ -177,12 +179,16 @@ func

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r333194946 ## File path: traffic_ops/traffic_ops_golang/role/roles.go ## @@ -122,9 +122,11 @@ func

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r333195701 ## File path: docs/source/api/roles.rst ## @@ -65,19 +84,236 @@ Response Structure

[GitHub] [trafficcontrol] jhg03a opened a new issue #3974: Remove weight parameter from CRConfig.json

jhg03a opened a new issue #3974: Remove weight parameter from CRConfig.json URL: https://github.com/apache/trafficcontrol/issues/3974 ## I'm submitting a ... - [ ] bug report - [ ] new feature / enhancement request - [X] improvement request (usability,

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3870: Rewrite /capabilities to Go

ocket commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333234730 ## File path: traffic_ops/client/capability.go ## @@ -0,0 +1,121 @@ +package client + +/* + * Licensed under

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3870: Rewrite /capabilities to Go

ocket commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333235112 ## File path: traffic_ops/client/capability.go ## @@ -0,0 +1,121 @@ +package client + +/* + * Licensed under

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3870: Rewrite /capabilities to Go

ocket commented on a change in pull request #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r333235306 ## File path: traffic_ops/testing/api/v14/capabilities_test.go ## @@ -0,0 +1,159 @@ +package v14 + +/* + *

[GitHub] [trafficcontrol] jheitz200 commented on a change in pull request #3964: Add GET/POST/DELETE for server_server_capabilities

jheitz200 commented on a change in pull request #3964: Add GET/POST/DELETE for server_server_capabilities URL: https://github.com/apache/trafficcontrol/pull/3964#discussion_r333238442 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -266,6 +266,11 @@

  1   2   >