[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337556776 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337553485 ## File path: docs/source/api/deliveryservices_xmlid_xmlid_sslkeys.rst

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337553629 ## File path: docs/source/api/letsencrypt_autorenew.rst ## @@

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337553576 ## File path: docs/source/api/deliveryservices_xmlid_xmlid_sslkeys.rst

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337553415 ## File path: docs/source/api/deliveryservices_hostname_name_sslkeys.rst

[GitHub] [trafficcontrol] mitchell852 commented on issue #643: Initial commit for Simple Session Tracking Lua script (used with tslu…

mitchell852 commented on issue #643: Initial commit for Simple Session Tracking Lua script (used with tslu… URL: https://github.com/apache/trafficcontrol/pull/643#issuecomment-544970126 @sandmanahoy - let me know if this was tested and if this is something you still want merged.

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337549414 ## File path: docs/source/admin/traffic_router.rst ## @@ -681,8

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337555050 ## File path: docs/source/api/letsencrypt_dnsrecord.rst ## @@

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337556352 ## File path: docs/source/api/letsencrypt_dnsrecords.rst ## @@

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337556250 ## File path: docs/source/api/letsencrypt_dnsrecord.rst ## @@

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337555816 ## File path: docs/source/api/letsencrypt_dnsrecord.rst ## @@

Build failed in Jenkins: trafficcontrol-PR #4610

See Changes: [rawlin_peters] Implement GET /api/1.1/roles handler [rawlin_peters] Add changelog entry [rawlin_peters] Remove unnecessary API version checks --

[GitHub] [trafficcontrol] asf-ci commented on issue #4011: Implement GET /api/1.1/roles handler

asf-ci commented on issue #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011#issuecomment-545134574 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4610/

[GitHub] [trafficcontrol] jheitz200 commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

jheitz200 commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337743518 ## File path: traffic_ops/testing/api/v14/todb.go ## @@ -275,6 +281,20 @@ INSERT

[GitHub] [trafficcontrol] asf-ci commented on issue #4012: WIP - Added IPv6 checking to Traffic Monitor

asf-ci commented on issue #4012: WIP - Added IPv6 checking to Traffic Monitor URL: https://github.com/apache/trafficcontrol/pull/4012#issuecomment-545155560 Can one of the admins verify this patch? This is an automated

Build failed in Jenkins: trafficcontrol-PR #4611

See Changes: [mitchell852] adds server capbility management to a server [mitchell852] adds the ability to view the servers that are utilizing a server [mitchell852] removes unecessary click handler

[GitHub] [trafficcontrol] asf-ci commented on issue #3998: TP: Ability to manager capabilities of servers

asf-ci commented on issue #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#issuecomment-545136360 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

ocket commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337750113 ## File path:

[GitHub] [trafficcontrol] mattjackson220 opened a new pull request #4012: WIP - Added IPv6 checking to Traffic Monitor

mattjackson220 opened a new pull request #4012: WIP - Added IPv6 checking to Traffic Monitor URL: https://github.com/apache/trafficcontrol/pull/4012 ## What does this PR (Pull Request) do? - [ ] This PR fixes #REPLACE_ME OR is not related to any Issue ## Which

[GitHub] [trafficcontrol] mitchell852 commented on issue #4007: Server Capability get by name - returns blank response array when the requested item doesn't exist

mitchell852 commented on issue #4007: Server Capability get by name - returns blank response array when the requested item doesn't exist URL: https://github.com/apache/trafficcontrol/issues/4007#issuecomment-545169954 For what it's worth, to me this makes sense: `GET

[GitHub] [trafficcontrol] rawlinp opened a new pull request #4013: Add TO-Go /api/1.1/servers/status GET handler

rawlinp opened a new pull request #4013: Add TO-Go /api/1.1/servers/status GET handler URL: https://github.com/apache/trafficcontrol/pull/4013 ## What does this PR (Pull Request) do? Rewrite the /api/1.1/servers/status GET handler to Go. - [x] This PR fixes #3826 ##

[GitHub] [trafficcontrol] asf-ci commented on issue #4013: Add TO-Go /api/1.1/servers/status GET handler

asf-ci commented on issue #4013: Add TO-Go /api/1.1/servers/status GET handler URL: https://github.com/apache/trafficcontrol/pull/4013#issuecomment-545177921 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4613

See Changes: [rawlin_peters] Add TO-Go /api/1.1/servers/status GET handler -- GitHub pull request #4013 of commit 4fe24f2c70cd97a08a997213e9b540514e905801, no merge

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3998: TP: Ability to manager capabilities of servers

mitchell852 commented on a change in pull request #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#discussion_r337740844 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3998: TP: Ability to manager capabilities of servers

ocket commented on a change in pull request #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#discussion_r337744648 ## File path:

Jenkins build is back to normal : trafficcontrol-PR #4612

See

[GitHub] [trafficcontrol] asf-ci commented on issue #3998: TP: Ability to manager capabilities of servers

asf-ci commented on issue #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#issuecomment-545150439 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3998: TP: Ability to manager capabilities of servers

mitchell852 commented on a change in pull request #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#discussion_r337740844 ## File path:

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4000: Put server_capability status code is incorrect

mitchell852 edited a comment on issue #4000: Put server_capability status code is incorrect URL: https://github.com/apache/trafficcontrol/issues/4000#issuecomment-545166335 > I just labeled it as it was reported, shall I change it? yeah, maybe @ZugNZwang can change his description

[GitHub] [trafficcontrol] asf-ci commented on issue #3998: TP: Ability to manager capabilities of servers

asf-ci commented on issue #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#issuecomment-545086787 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ocket8888 commented on issue #3999: Traffic Ops API POST with no body returns an EOF error, should return a more informative error

ocket commented on issue #3999: Traffic Ops API POST with no body returns an EOF error, should return a more informative error URL: https://github.com/apache/trafficcontrol/issues/3999#issuecomment-545091857 I don't think it's dispatch/routing, that to me looks like the kind of error

[GitHub] [trafficcontrol] guzzijason opened a new pull request #4010: Port legacy perl TO extension checks from perl to go

guzzijason opened a new pull request #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010 ## What does this PR (Pull Request) do? - Traffic Ops Extensions (server checks) ## What is the best way to verify

[GitHub] [trafficcontrol] ocket8888 commented on issue #4010: Port legacy perl TO extension checks from perl to go

ocket commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-545108518 ok to test This is an automated message from the Apache

[GitHub] [trafficcontrol] rawlinp opened a new pull request #4011: Implement GET /api/1.1/roles handler

rawlinp opened a new pull request #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011 ## What does this PR (Pull Request) do? Modify the 1.3 GET handler to also handle requests at 1.1 (the only difference is the addition of the

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337558120 ## File path: docs/source/api/deliveryservices_hostname_name_sslkeys.rst

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3929: Rewrote /user/reset_password to Go

mhoppa commented on a change in pull request #3929: Rewrote /user/reset_password to Go URL: https://github.com/apache/trafficcontrol/pull/3929#discussion_r337643607 ## File path: infrastructure/cdn-in-a-box/traffic_ops/config.sh ## @@ -111,7 +111,7 @@ cat <<-EOF

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3929: Rewrote /user/reset_password to Go

ocket commented on a change in pull request #3929: Rewrote /user/reset_password to Go URL: https://github.com/apache/trafficcontrol/pull/3929#discussion_r337580415 ## File path: traffic_ops/traffic_ops_golang/login/login_test.go ## @@ -121,4 +121,5 @@ func

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3998: TP: Ability to manager capabilities of servers

mitchell852 commented on a change in pull request #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#discussion_r337652192 ## File path:

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3998: TP: Ability to manager capabilities of servers

mitchell852 commented on a change in pull request #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#discussion_r337652192 ## File path:

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4008: TP: fixes bug that surfaces when trying to compare profiles without params

mitchell852 opened a new pull request #4008: TP: fixes bug that surfaces when trying to compare profiles without params URL: https://github.com/apache/trafficcontrol/pull/4008 ## What does this PR (Pull Request) do? This PR fixes a bug highlighted by a failing UI test. When comparing 2

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3929: Rewrote /user/reset_password to Go

mhoppa commented on a change in pull request #3929: Rewrote /user/reset_password to Go URL: https://github.com/apache/trafficcontrol/pull/3929#discussion_r337581097 ## File path: traffic_ops/traffic_ops_golang/login/login_test.go ## @@ -121,4 +121,5 @@ func

[GitHub] [trafficcontrol] rawlinp opened a new pull request #4009: Add top-level vendor dir to TO-Go and TM unit test containers

rawlinp opened a new pull request #4009: Add top-level vendor dir to TO-Go and TM unit test containers URL: https://github.com/apache/trafficcontrol/pull/4009 ## What does this PR (Pull Request) do? The TO-Go and TM unit test containers are failing to find the vendored influxdb

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337565187 ## File path: lib/go-tc/deliveryservice_server_capabilities.go ## @@ -0,0 +1,28

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337610384 ## File path:

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337600378 ## File path: traffic_ops/testing/api/v14/deliveryservice_server_capabilities_test.go

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337607687 ## File path:

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337572627 ## File path: traffic_ops/client/deliveryservice_server_capabilities.go ## @@

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337595138 ## File path: traffic_ops/testing/api/v14/deliveryservice_server_capabilities_test.go

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337623669 ## File path: traffic_ops/testing/api/v14/todb.go ## @@ -103,6 +103,12 @@ func

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337592200 ## File path: traffic_ops/testing/api/v14/deliveryservice_server_capabilities_test.go

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint

ChrisHines commented on a change in pull request #4006: implement deliveryservice_server_capabilities api endpoint URL: https://github.com/apache/trafficcontrol/pull/4006#discussion_r337619314 ## File path:

[GitHub] [trafficcontrol] asf-ci commented on issue #4009: Add top-level vendor dir to TO-Go and TM unit test containers

asf-ci commented on issue #4009: Add top-level vendor dir to TO-Go and TM unit test containers URL: https://github.com/apache/trafficcontrol/pull/4009#issuecomment-545061245 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4603

See Changes: [ocket] rewrote /user/reset_password to Go [ocket] Fixed redundant rollbacks [ocket] Removed UUID dependency, doing it manually now [ocket] Go fmt [ocket] Fixed UUID

[GitHub] [trafficcontrol] rob05c commented on issue #4000: Put server_capability status code is incorrect

rob05c commented on issue #4000: Put server_capability status code is incorrect URL: https://github.com/apache/trafficcontrol/issues/4000#issuecomment-545074002 It's not "incorrect," it's just less precise than it could be. The HTTP spec (RFC 7231) doesn't require a 405, you can always use

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1596

See Changes: [ocket] Add top-level vendor dir to TO-Go and TM unit test containers (#4009) -- Started by an SCM change Running as SYSTEM [EnvInject]

Build failed in Jenkins: trafficcontrol-master-build #1553

See Changes: [ocket] Add top-level vendor dir to TO-Go and TM unit test containers (#4009) -- Started by an SCM change Running as SYSTEM [EnvInject] -

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4011: Implement GET /api/1.1/roles handler

ocket commented on a change in pull request #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011#discussion_r337709162 ## File path: traffic_ops/traffic_ops_golang/role/roles.go ## @@ -159,16 +159,32 @@ func (role

[GitHub] [trafficcontrol] asf-ci commented on issue #3998: TP: Ability to manager capabilities of servers

asf-ci commented on issue #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#issuecomment-545126553 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : trafficcontrol-PR #4609

See

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r337560858 ## File path: docs/source/api/letsencrypt_autorenew.rst ## @@

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3929: Rewrote /user/reset_password to Go

mhoppa commented on a change in pull request #3929: Rewrote /user/reset_password to Go URL: https://github.com/apache/trafficcontrol/pull/3929#discussion_r337560837 ## File path: traffic_ops/traffic_ops_golang/login/login_test.go ## @@ -121,4 +121,5 @@ func

[GitHub] [trafficcontrol] asf-ci commented on issue #4008: TP: fixes bug that surfaces when trying to compare profiles without params

asf-ci commented on issue #4008: TP: fixes bug that surfaces when trying to compare profiles without params URL: https://github.com/apache/trafficcontrol/pull/4008#issuecomment-545023272 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] asf-ci commented on issue #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

asf-ci commented on issue #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#issuecomment-545025630 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] asf-ci commented on issue #3929: Rewrote /user/reset_password to Go

asf-ci commented on issue #3929: Rewrote /user/reset_password to Go URL: https://github.com/apache/trafficcontrol/pull/3929#issuecomment-545062721 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4603/

[GitHub] [trafficcontrol] rob05c commented on issue #3999: Create server_capability response message is incorrect - this is also a issue that needs to be fixed globally for responses

rob05c commented on issue #3999: Create server_capability response message is incorrect - this is also a issue that needs to be fixed globally for responses URL: https://github.com/apache/trafficcontrol/issues/3999#issuecomment-545075883 I don't think this is a bug, it's a fundamental

[GitHub] [trafficcontrol] rob05c removed a comment on issue #3999: Create server_capability response message is incorrect - this is also a issue that needs to be fixed globally for responses

rob05c removed a comment on issue #3999: Create server_capability response message is incorrect - this is also a issue that needs to be fixed globally for responses URL: https://github.com/apache/trafficcontrol/issues/3999#issuecomment-545075883 I don't think this is a bug, it's a

[GitHub] [trafficcontrol] ocket8888 merged pull request #4009: Add top-level vendor dir to TO-Go and TM unit test containers

ocket merged pull request #4009: Add top-level vendor dir to TO-Go and TM unit test containers URL: https://github.com/apache/trafficcontrol/pull/4009 This is an automated message from the Apache Git Service. To respond

[GitHub] [trafficcontrol] asf-ci commented on issue #3929: Rewrote /user/reset_password to Go

asf-ci commented on issue #3929: Rewrote /user/reset_password to Go URL: https://github.com/apache/trafficcontrol/pull/3929#issuecomment-545092582 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4606/

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3998: TP: Ability to manager capabilities of servers

ocket commented on a change in pull request #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#discussion_r337679635 ## File path:

[GitHub] [trafficcontrol] asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go

asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-545110446 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] asf-ci commented on issue #3998: TP: Ability to manager capabilities of servers

asf-ci commented on issue #3998: TP: Ability to manager capabilities of servers URL: https://github.com/apache/trafficcontrol/pull/3998#issuecomment-545072973 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : trafficcontrol-PR #4604

See

[GitHub] [trafficcontrol] rob05c commented on issue #4007: Server Capability get by name - returns blank response array when the requested item doesn't exist

rob05c commented on issue #4007: Server Capability get by name - returns blank response array when the requested item doesn't exist URL: https://github.com/apache/trafficcontrol/issues/4007#issuecomment-545077220 I don't think this is a bug, it's a fundamental change to the API. For

[GitHub] [trafficcontrol] rob05c commented on issue #3999: Create server_capability response message is incorrect - this is also a issue that needs to be fixed globally for responses

rob05c commented on issue #3999: Create server_capability response message is incorrect - this is also a issue that needs to be fixed globally for responses URL: https://github.com/apache/trafficcontrol/issues/3999#issuecomment-545080006 >does this happen on any other POSTs in our api?

[GitHub] [trafficcontrol] ocket8888 commented on issue #4000: Put server_capability status code is incorrect

ocket commented on issue #4000: Put server_capability status code is incorrect URL: https://github.com/apache/trafficcontrol/issues/4000#issuecomment-545090676 I just labeled it as it was reported, shall I change it?

[GitHub] [trafficcontrol] ocket8888 merged pull request #4008: TP: fixes bug that surfaces when trying to compare profiles without params

ocket merged pull request #4008: TP: fixes bug that surfaces when trying to compare profiles without params URL: https://github.com/apache/trafficcontrol/pull/4008 This is an automated message from the Apache Git

[GitHub] [trafficcontrol] asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go

asf-ci commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-545106638 Can one of the admins verify this patch? This is an

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1597

See

[GitHub] [trafficcontrol] ocket8888 commented on issue #4010: Port legacy perl TO extension checks from perl to go

ocket commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-545107969 What's the motivation for this? Check extensions just run as scripts with no actual dependency on the Perl TO codebase,

[GitHub] [trafficcontrol] guzzijason commented on issue #4010: Port legacy perl TO extension checks from perl to go

guzzijason commented on issue #4010: Port legacy perl TO extension checks from perl to go URL: https://github.com/apache/trafficcontrol/pull/4010#issuecomment-545110217 @ocket I just emailed the dev/users lists with some more info regarding motivation. The only dependency was

[GitHub] [trafficcontrol] asf-ci commented on issue #4011: Implement GET /api/1.1/roles handler

asf-ci commented on issue #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011#issuecomment-545112558 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4608/

Build failed in Jenkins: trafficcontrol-PR #4608

See Changes: [rawlin_peters] Implement GET /api/1.1/roles handler [rawlin_peters] Add changelog entry -- GitHub pull request #4011 of commit

Build failed in Jenkins: trafficcontrol-master-build #1554

See Changes: [ocket] accounts for null arrays (#4008) -- [...truncated 647.40 KB...] Installing ri documentation for sass-3.4.25 Parsing documentation for

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4011: Implement GET /api/1.1/roles handler

rawlinp commented on a change in pull request #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011#discussion_r337721593 ## File path: traffic_ops/traffic_ops_golang/role/roles.go ## @@ -159,16 +159,32 @@ func (role *TORole)

[GitHub] [trafficcontrol] rawlinp commented on issue #4011: Implement GET /api/1.1/roles handler

rawlinp commented on issue #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011#issuecomment-545185758 Fixed. Those are interesting unit test failures. I assumed anonymously embedding a new `RoleV11` struct into `Role` would be non-breaking,

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4014: Rewrite federation user GET/POST/DELETE

mhoppa opened a new pull request #4014: Rewrite federation user GET/POST/DELETE URL: https://github.com/apache/trafficcontrol/pull/4014 ## What does this PR (Pull Request) do? - [x] This PR fixes #3791 AND #3792 ## Which Traffic Control components are affected by

[GitHub] [trafficcontrol] rob05c commented on issue #4011: Implement GET /api/1.1/roles handler

rob05c commented on issue #4011: Implement GET /api/1.1/roles handler URL: https://github.com/apache/trafficcontrol/pull/4011#issuecomment-545187363 >Fixed. Those are interesting unit test failures. I assumed anonymously embedding a new RoleV11 struct into Role would be non-breaking, but I

Build failed in Jenkins: trafficcontrol-PR #4616

See Changes: [Michael_Hoppal] Rewrite federation user GET/POST/DELETE -- GitHub pull request #4014 of commit ab32a65c08ea86a2a1dcf1d67a546626bd6ede95, no merge

Jenkins build is back to normal : trafficcontrol-PR #4614

See

Build failed in Jenkins: trafficcontrol-PR #4615

See Changes: [rawlin_peters] Add TO-Go /api/1.1/servers/status GET handler -- GitHub pull request #4013 of commit 9d6ed0aebd085cc1866138616367fd73ce78f95e, no merge

[GitHub] [trafficcontrol] asf-ci commented on issue #4013: Add TO-Go /api/1.1/servers/status GET handler

asf-ci commented on issue #4013: Add TO-Go /api/1.1/servers/status GET handler URL: https://github.com/apache/trafficcontrol/pull/4013#issuecomment-545202466 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] asf-ci commented on issue #4014: Rewrite federation user GET/POST/DELETE

asf-ci commented on issue #4014: Rewrite federation user GET/POST/DELETE URL: https://github.com/apache/trafficcontrol/pull/4014#issuecomment-545202597 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4616/

[GitHub] [trafficcontrol] rob05c commented on issue #916: [TC-197] File descriptor leak caused by NIO protocol connector

rob05c commented on issue #916: [TC-197] File descriptor leak caused by NIO protocol connector URL: https://github.com/apache/trafficcontrol/issues/916#issuecomment-545201667 TC default Tomcat version is now 8.5, this bug was observed in an older Tomcat version, we haven't seen it in 8.5.

[GitHub] [trafficcontrol] rob05c closed issue #916: [TC-197] File descriptor leak caused by NIO protocol connector

rob05c closed issue #916: [TC-197] File descriptor leak caused by NIO protocol connector URL: https://github.com/apache/trafficcontrol/issues/916 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

ocket opened a new pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015 ## What does this PR (Pull Request) do? - [x] This PR fixes #3790 Rewrites `/federations` to Go. This also adds API version 1.4

Build failed in Jenkins: trafficcontrol-PR #4617

See Changes: -- GitHub pull request #4015 of commit 44f96cd43035468429f408ecda9ecda9b4a1, no merge conflicts. Running as SYSTEM Setting status of

[GitHub] [trafficcontrol] asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE

asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#issuecomment-545269481 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : trafficcontrol-PR #4618

See

[GitHub] [trafficcontrol] asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE

asf-ci commented on issue #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#issuecomment-545274994 Refer to this link for build results (access rights to CI server needed):