[GitHub] [trafficcontrol] mitchell852 commented on issue #4084: TP: delivery service widget - changes search to ds xmlId rather than display name

mitchell852 commented on issue #4084: TP: delivery service widget - changes search to ds xmlId rather than display name URL: https://github.com/apache/trafficcontrol/pull/4084#issuecomment-549973913 > Of course, after so long using XMLIDs operators may find the change jarring.

[GitHub] [trafficcontrol] ocket8888 commented on issue #4083: No Error when child tenant accesses parent tenant's delivery-services

ocket commented on issue #4083: No Error when child tenant accesses parent tenant's delivery-services URL: https://github.com/apache/trafficcontrol/issues/4083#issuecomment-549989276 For as long as the DS endpoints have been using the CRUDer that's definitely not true. Because both

[GitHub] [trafficcontrol] ocket8888 commented on issue #4083: No Error when child tenant accesses parent tenant's delivery-services

ocket commented on issue #4083: No Error when child tenant accesses parent tenant's delivery-services URL: https://github.com/apache/trafficcontrol/issues/4083#issuecomment-549943702 We're trying to favor query parameters over path parameters these days, so the API is designed with

[GitHub] [trafficcontrol] lbathina commented on issue #4076: TP do not return error message on current page when DELETE Server Capabilities

lbathina commented on issue #4076: TP do not return error message on current page when DELETE Server Capabilities URL: https://github.com/apache/trafficcontrol/issues/4076#issuecomment-550075191 validated and the issue is fixed. can be closed.

Build failed in Jenkins: trafficcontrol-PR #4719

See Changes: -- GitHub pull request #4079 of commit 70cfabefb656ca36aec3791f341b6fbd00400e8b, no merge conflicts. Running as SYSTEM Setting status of

[GitHub] [trafficcontrol] asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST

asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST URL: https://github.com/apache/trafficcontrol/pull/4079#issuecomment-550080489 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4719/

Build failed in Jenkins: trafficcontrol-PR #4718

See Changes: [ocket] Rewrote /federation_resolvers - POST [ocket] Rewrote /federation_resolvers - GET [ocket] Added TO binary to .gitignore [ocket] Fixed routing [ocket] fix queries

[GitHub] [trafficcontrol] asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST

asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST URL: https://github.com/apache/trafficcontrol/pull/4079#issuecomment-550069899 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4718/

[GitHub] [trafficcontrol] ajschmidt commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

ajschmidt commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r342859130 ## File path:

Build failed in Jenkins: trafficcontrol-PR #4720

See Changes: [ocket] go fmt -- GitHub pull request #4079 of commit 3ea418df440e4f9be5e58bcf863f2fc806344b9b, no merge conflicts. Running as SYSTEM Setting status

[GitHub] [trafficcontrol] asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST

asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST URL: https://github.com/apache/trafficcontrol/pull/4079#issuecomment-550081698 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4720/

[GitHub] [trafficcontrol] ocket8888 closed issue #4085: deliveryserviceserver POST endpoint can add servers with mismatching CDN from Delivery Service

ocket closed issue #4085: deliveryserviceserver POST endpoint can add servers with mismatching CDN from Delivery Service URL: https://github.com/apache/trafficcontrol/issues/4085 This is an automated message from the

[GitHub] [trafficcontrol] ocket8888 commented on issue #4085: deliveryserviceserver POST endpoint can add servers with mismatching CDN from Delivery Service

ocket commented on issue #4085: deliveryserviceserver POST endpoint can add servers with mismatching CDN from Delivery Service URL: https://github.com/apache/trafficcontrol/issues/4085#issuecomment-550069608 Duplicate of #3756

Build failed in Jenkins: trafficcontrol-PR #4713

See Changes: [ocket] fix queries -- GitHub pull request #4079 of commit 75b7f7d7b4efa71f07b7ea34c5ad756cf7cc5d81, no merge conflicts. Running as SYSTEM Setting

[GitHub] [trafficcontrol] asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST

asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST URL: https://github.com/apache/trafficcontrol/pull/4079#issuecomment-549900546 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4713/

[GitHub] [trafficcontrol] ocket8888 commented on issue #3775: Traffic Portal makes malformed request to /roles on creation

ocket commented on issue #3775: Traffic Portal makes malformed request to /roles on creation URL: https://github.com/apache/trafficcontrol/issues/3775#issuecomment-549902082 Yes, actually I tested this when I was reviewing #4011 .

[GitHub] [trafficcontrol] ocket8888 closed issue #3775: Traffic Portal makes malformed request to /roles on creation

ocket closed issue #3775: Traffic Portal makes malformed request to /roles on creation URL: https://github.com/apache/trafficcontrol/issues/3775 This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4082: Fix federation user validation

mhoppa opened a new pull request #4082: Fix federation user validation URL: https://github.com/apache/trafficcontrol/pull/4082 ## What does this PR (Pull Request) do? This PR makes sure the on federation user post the userIDs is defined. - [x] This PR fixes #4068

Build failed in Jenkins: trafficcontrol-PR #4716

See Changes: [ocket] Rewrote /federation_resolvers - POST [ocket] Rewrote /federation_resolvers - GET [ocket] Added TO binary to .gitignore [ocket] Fixed routing [ocket] fix queries

Build failed in Jenkins: trafficcontrol-PR #4715

See Changes: [Michael_Hoppal] Fix federation user validation -- GitHub pull request #4082 of commit a570989df5c587818cbdd25ed52d20d28d517c7e, no merge conflicts.

[GitHub] [trafficcontrol] asf-ci commented on issue #3761: Improvements to Server-to-Delivery Service assignments

asf-ci commented on issue #3761: Improvements to Server-to-Delivery Service assignments URL: https://github.com/apache/trafficcontrol/pull/3761#issuecomment-549911878 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4084: TP: delivery service widget - changes search to ds xmlId rather than display name

mitchell852 opened a new pull request #4084: TP: delivery service widget - changes search to ds xmlId rather than display name URL: https://github.com/apache/trafficcontrol/pull/4084 ## What does this PR (Pull Request) do? - [x] This PR fixes #3753 ## Which Traffic Control

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4082: Fix federation user validation

ocket commented on a change in pull request #4082: Fix federation user validation URL: https://github.com/apache/trafficcontrol/pull/4082#discussion_r342703744 ## File path: lib/go-tc/federation.go ## @@ -184,7 +186,9 @@ type FederationUserPost struct { // Validate

[GitHub] [trafficcontrol] ocket8888 commented on issue #4033: To: INternal server error when server capability associated with Server/ds is deleted

ocket commented on issue #4033: To: INternal server error when server capability associated with Server/ds is deleted URL: https://github.com/apache/trafficcontrol/issues/4033#issuecomment-549901384 It likely doesn't check both and that error message isn't strictly wrong. It's just

[GitHub] [trafficcontrol] asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST

asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST URL: https://github.com/apache/trafficcontrol/pull/4079#issuecomment-549912317 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4716/

[GitHub] [trafficcontrol] asf-ci commented on issue #4082: Fix federation user validation

asf-ci commented on issue #4082: Fix federation user validation URL: https://github.com/apache/trafficcontrol/pull/4082#issuecomment-549912100 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4715/

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4083: No Error when child tenant accesses parent tenant's delivery-services

ZugNZwang opened a new issue #4083: No Error when child tenant accesses parent tenant's delivery-services URL: https://github.com/apache/trafficcontrol/issues/4083 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request - [ ]

[GitHub] [trafficcontrol] asf-ci commented on issue #4084: TP: delivery service widget - changes search to ds xmlId rather than display name

asf-ci commented on issue #4084: TP: delivery service widget - changes search to ds xmlId rather than display name URL: https://github.com/apache/trafficcontrol/pull/4084#issuecomment-549935525 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4717

See Changes: [rawlin_peters] Add atscfg logic for Server Capabilities. (#3980) [ocket] Prevent Assigning Servers to Delivery Services Without Required [ocket] Fix file permissions on Go source file

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4082: Fix federation user validation

mhoppa commented on a change in pull request #4082: Fix federation user validation URL: https://github.com/apache/trafficcontrol/pull/4082#discussion_r342704855 ## File path: lib/go-tc/federation.go ## @@ -184,7 +186,9 @@ type FederationUserPost struct { // Validate

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4082: Fix federation user validation

ocket commented on a change in pull request #4082: Fix federation user validation URL: https://github.com/apache/trafficcontrol/pull/4082#discussion_r342762916 ## File path: lib/go-tc/federation.go ## @@ -184,7 +186,9 @@ type FederationUserPost struct { // Validate

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4085: deliveryserviceserver POST endpoint can add servers with mismatching CDN from Delivery Service

ZugNZwang opened a new issue #4085: deliveryserviceserver POST endpoint can add servers with mismatching CDN from Delivery Service URL: https://github.com/apache/trafficcontrol/issues/4085 ## I'm submitting a ... - [X] bug report - [ ] new feature /

[GitHub] [trafficcontrol] mitchell852 commented on issue #4083: No Error when child tenant accesses parent tenant's delivery-services

mitchell852 commented on issue #4083: No Error when child tenant accesses parent tenant's delivery-services URL: https://github.com/apache/trafficcontrol/issues/4083#issuecomment-549971764 I'm pretty sure GET /deliveryservices/4 where id=4 is not in your tenancy has always resulted in a

[GitHub] [trafficcontrol] ocket8888 commented on issue #4083: No Error when child tenant accesses parent tenant's delivery-services

ocket commented on issue #4083: No Error when child tenant accesses parent tenant's delivery-services URL: https://github.com/apache/trafficcontrol/issues/4083#issuecomment-549940234 This bug manifests in the TO API, if that's fixed TP will display the returned error automatically.

[GitHub] [trafficcontrol] ocket8888 closed issue #4068: Admin can assign User to a Federation with wrong PARAMETER

ocket closed issue #4068: Admin can assign User to a Federation with wrong PARAMETER URL: https://github.com/apache/trafficcontrol/issues/4068 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] ocket8888 merged pull request #4082: Fix federation user validation

ocket merged pull request #4082: Fix federation user validation URL: https://github.com/apache/trafficcontrol/pull/4082 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4082: Fix federation user validation

ocket commented on a change in pull request #4082: Fix federation user validation URL: https://github.com/apache/trafficcontrol/pull/4082#discussion_r342722170 ## File path: lib/go-tc/federation.go ## @@ -184,7 +186,9 @@ type FederationUserPost struct { // Validate

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4082: Fix federation user validation

mhoppa commented on a change in pull request #4082: Fix federation user validation URL: https://github.com/apache/trafficcontrol/pull/4082#discussion_r342736383 ## File path: lib/go-tc/federation.go ## @@ -184,7 +186,9 @@ type FederationUserPost struct { // Validate

Build failed in Jenkins: trafficcontrol-PR #4711

See Changes: [ocket] Rewrote /federation_resolvers - POST [ocket] Rewrote /federation_resolvers - GET [ocket] Added TO binary to .gitignore -- GitHub pull

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4068: Admin can assign User to a Federation with wrong PARAMETER

mitchell852 edited a comment on issue #4068: Admin can assign User to a Federation with wrong PARAMETER URL: https://github.com/apache/trafficcontrol/issues/4068#issuecomment-549882937 > POST Request: `https://{{TO_BASE_URL}}/api/{{api_version}}/federations/{{federationsID}}/users. `

[GitHub] [trafficcontrol] asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST

asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST URL: https://github.com/apache/trafficcontrol/pull/4079#issuecomment-549887363 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4711/

[GitHub] [trafficcontrol] mitchell852 removed a comment on issue #4039: TO, TP: server should not be allowed to be deleted when it has a DS assigned to it.

mitchell852 removed a comment on issue #4039: TO,TP: server should not be allowed to be deleted when it has a DS assigned to it. URL: https://github.com/apache/trafficcontrol/issues/4039#issuecomment-549886796 can we close this @lbathina

Build failed in Jenkins: trafficcontrol-PR #4712

See Changes: [ocket] Fixed routing -- GitHub pull request #4079 of commit cfc5c99face5faefcb27d60c1236c64e6190936d, no merge conflicts. Running as SYSTEM Setting

[GitHub] [trafficcontrol] asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST

asf-ci commented on issue #4079: Rewrote /federation_resolvers - POST URL: https://github.com/apache/trafficcontrol/pull/4079#issuecomment-549893918 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4712/

[GitHub] [trafficcontrol] mitchell852 commented on issue #4069: TP: DS-> Manage Required Capabilities is displayed as Manage Required Server Capabilities

mitchell852 commented on issue #4069: TP: DS-> Manage Required Capabilities is displayed as Manage Required Server Capabilities URL: https://github.com/apache/trafficcontrol/issues/4069#issuecomment-549881658 @lbathina - can you close unless you have strong feelings about this change.

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4068: Admin can assign User to a Federation with wrong PARAMETER

mitchell852 edited a comment on issue #4068: Admin can assign User to a Federation with wrong PARAMETER URL: https://github.com/apache/trafficcontrol/issues/4068#issuecomment-549882937 > POST Request: `https://{{TO_BASE_URL}}/api/{{api_version}}/federations/{{federationsID}}/users. `

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4068: Admin can assign User to a Federation with wrong PARAMETER

mitchell852 edited a comment on issue #4068: Admin can assign User to a Federation with wrong PARAMETER URL: https://github.com/apache/trafficcontrol/issues/4068#issuecomment-549882937 > POST Request: `https://{{TO_BASE_URL}}/api/{{api_version}}/federations/{{federationsID}}/users. `

[GitHub] [trafficcontrol] mitchell852 commented on issue #4068: Admin can assign User to a Federation with wrong PARAMETER

mitchell852 commented on issue #4068: Admin can assign User to a Federation with wrong PARAMETER URL: https://github.com/apache/trafficcontrol/issues/4068#issuecomment-549882937 > POST Request: `https://{{TO_BASE_URL}}/api/{{api_version}}/federations/{{federationsID}}/users. ` > With

[GitHub] [trafficcontrol] mitchell852 commented on issue #4068: Admin can assign User to a Federation with wrong PARAMETER

mitchell852 commented on issue #4068: Admin can assign User to a Federation with wrong PARAMETER URL: https://github.com/apache/trafficcontrol/issues/4068#issuecomment-549884986 and i'm not sure the title of this issue is correct `Admin can assign User to a Federation with wrong

[GitHub] [trafficcontrol] mhoppa commented on issue #4068: Admin can assign User to a Federation with wrong PARAMETER

mhoppa commented on issue #4068: Admin can assign User to a Federation with wrong PARAMETER URL: https://github.com/apache/trafficcontrol/issues/4068#issuecomment-549886395 My plan is to make userIds required - replace is a documented optional parameter

[GitHub] [trafficcontrol] mitchell852 commented on issue #3775: Traffic Portal makes malformed request to /roles on creation

mitchell852 commented on issue #3775: Traffic Portal makes malformed request to /roles on creation URL: https://github.com/apache/trafficcontrol/issues/3775#issuecomment-549890421 This seems to be fixed because I'm guessing the API now handles the missing `capabilities` field. Can this be

[GitHub] [trafficcontrol] lbathina commented on issue #4033: To: INternal server error when server capability associated with Server/ds is deleted

lbathina commented on issue #4033: To: INternal server error when server capability associated with Server/ds is deleted URL: https://github.com/apache/trafficcontrol/issues/4033#issuecomment-549889936 this is fixed. the message displayed when the server capability is associated to

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4081: TP: makes parameter row clickable to show parameter details

mitchell852 opened a new pull request #4081: TP: makes parameter row clickable to show parameter details URL: https://github.com/apache/trafficcontrol/pull/4081 ## What does this PR (Pull Request) do? - [ ] This PR fixes is not related to any Issue ## Which Traffic Control

[GitHub] [trafficcontrol] asf-ci commented on issue #4081: TP: makes parameter row clickable to show parameter details

asf-ci commented on issue #4081: TP: makes parameter row clickable to show parameter details URL: https://github.com/apache/trafficcontrol/pull/4081#issuecomment-549856841 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4710

See Changes: [mitchell852] makes parameter row clickable to show parameter details -- GitHub pull request #4081 of commit f8a75ec4eb73bd746454707bace88cbc63dc2b75, no