[GitHub] [trafficcontrol] mhoppa commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

mhoppa commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561166680 @rob05c What can we do to get this past DO NOT MERGE? This is an automated

[GitHub] [trafficcontrol] mhoppa commented on issue #3823: Rewrite /api_capabilities to Go

mhoppa commented on issue #3823: Rewrite /api_capabilities to Go URL: https://github.com/apache/trafficcontrol/issues/3823#issuecomment-561178845 We should only rewrite the GET and deprecate the POST on this rewrite. As any create/update/delete of api capabilities should be done through db

[GitHub] [trafficcontrol] rob05c commented on issue #3823: Rewrite /api_capabilities to Go

rob05c commented on issue #3823: Rewrite /api_capabilities to Go URL: https://github.com/apache/trafficcontrol/issues/3823#issuecomment-561214650 >We should only rewrite the GET and deprecate the POST on this rewrite. As any create/update/delete of api capabilities should be done through db

[GitHub] [trafficcontrol] rob05c commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

rob05c commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561216854 @mhoppa We have a Plugins system in TO now. The "DO NOT MERGE" was added because Comcast has an non-open-source Perl TO Extension overriding

[GitHub] [trafficcontrol] mhoppa commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

mhoppa commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561222711 Okay makes sense. I am concerned that in a 1 year and half no work has been done on it to rewrite it as this will soon be blocking our comple

[GitHub] [trafficcontrol] mhoppa commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

mhoppa commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561223999 Will take this offline to see what we can do to get this across the finish line! --

[GitHub] [trafficcontrol] rob05c commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

rob05c commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561224541 It's because it uses an internal log data tool, which itself involves a large amount of infrastructure. It's not that Comcast doesn't want

[GitHub] [trafficcontrol] ocket8888 commented on issue #3823: Rewrite /api_capabilities to Go

ocket commented on issue #3823: Rewrite /api_capabilities to Go URL: https://github.com/apache/trafficcontrol/issues/3823#issuecomment-561226109 That was my initial concern as well, but the thinking is that plug-ins should be provided a way to declare their required user capabilities at

[GitHub] [trafficcontrol] ocket8888 commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

ocket commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561226633 Can this be safely merged once #4145 is merged? This is an automated mess

[GitHub] [trafficcontrol] rob05c commented on issue #3823: Rewrite /api_capabilities to Go

rob05c commented on issue #3823: Rewrite /api_capabilities to Go URL: https://github.com/apache/trafficcontrol/issues/3823#issuecomment-561229113 >plug-ins should be provided a way to declare their required user capabilities at start-up. I'd be +1 on that as well. As long as there's

[GitHub] [trafficcontrol] mitchell852 commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

mitchell852 commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561237813 > Can this be safely merged once #4145 is merged? I believe so because #4145 allows you to turn off certain Go routes if desired.

[GitHub] [trafficcontrol] mhoppa removed a comment on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

mhoppa removed a comment on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561223999 Will take this offline to see what we can do to get this across the finish line! --

[GitHub] [trafficcontrol] mhoppa commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

mhoppa commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561248226 > I question the need for our proprietary version in the first place. I think the issue was that we were adding a lot of TRs and didn't want

[GitHub] [trafficcontrol] ocket8888 commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

ocket commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561248399 That's fine with me, it certainly doesn't make any breaking changes to just do things in parallel. --

[GitHub] [trafficcontrol] rawlinp commented on issue #3823: Rewrite /api_capabilities to Go

rawlinp commented on issue #3823: Rewrite /api_capabilities to Go URL: https://github.com/apache/trafficcontrol/issues/3823#issuecomment-561259691 From my perspective I think it makes the most sense to have a plugin "seed" its own capabilities somehow on TO startup, and to not allow updati

[GitHub] [trafficcontrol] mitchell852 opened a new issue #4151: Unable to unassign a delivery service request

mitchell852 opened a new issue #4151: Unable to unassign a delivery service request URL: https://github.com/apache/trafficcontrol/issues/4151 ## I'm submitting a ... - [x] bug report - [ ] new feature / enhancement request - [ ] improvement request (usability, performance,

[GitHub] [trafficcontrol] rob05c commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

rob05c commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561265635 I'm unlikely to be implementing, so I'll defer to the people who will be. Th

[GitHub] [trafficcontrol] rawlinp commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

rawlinp commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561270090 I'm almost certain that was the issue. We weren't very far into the Go rewrite by the point that TO extension was written, and Perl doesn't

[GitHub] [trafficcontrol] rob05c commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE

rob05c commented on issue #2307: Add TO Go cdns/routing - DO NOT MERGE URL: https://github.com/apache/trafficcontrol/pull/2307#issuecomment-561272440 >@rob05c should whoever works on parallelizing this just open a PR against your fork's branch? Sure. Or it's not very big, they could

[GitHub] [trafficcontrol] ocket8888 commented on issue #4151: Unable to unassign a delivery service request

ocket commented on issue #4151: Unable to unassign a delivery service request URL: https://github.com/apache/trafficcontrol/issues/4151#issuecomment-561274038 Possibly a routing issue? This is an automated message from th

[GitHub] [trafficcontrol] ocket8888 merged pull request #4145: Add TO API Routing Blacklist via cdn.conf

ocket merged pull request #4145: Add TO API Routing Blacklist via cdn.conf URL: https://github.com/apache/trafficcontrol/pull/4145 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [trafficcontrol] asf-ci commented on issue #4125: Rewrite users/register to Go

asf-ci commented on issue #4125: Rewrite users/register to Go URL: https://github.com/apache/trafficcontrol/pull/4125#issuecomment-561284092 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4853/ --

Build failed in Jenkins: trafficcontrol-PR #4853

See Changes: -- GitHub pull request #4125 of commit 4395f30fae584d71c4a2fd33f3233195f938f94a, has merge conflicts. Running as SYSTEM !!! PR mergeability status has changed !!! PR no

[GitHub] [trafficcontrol] ocket8888 commented on issue #4125: Rewrite users/register to Go

ocket commented on issue #4125: Rewrite users/register to Go URL: https://github.com/apache/trafficcontrol/pull/4125#issuecomment-561287969 it was a problem with my clause ordering in a query. I know I tried it out manually, must've changed it after that and forgot to verify. I didn't b

[GitHub] [trafficcontrol] rawlinp opened a new pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go

rawlinp opened a new pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go URL: https://github.com/apache/trafficcontrol/pull/4152 ## What does this PR (Pull Request) do? Remove some duplicate routes, add a unit test to check for duplicate route

[GitHub] [trafficcontrol] mitchell852 commented on issue #4150: Tenancy Error Message when Delivery Service Already Exists

mitchell852 commented on issue #4150: Tenancy Error Message when Delivery Service Already Exists URL: https://github.com/apache/trafficcontrol/issues/4150#issuecomment-561293506 This is an interesting one. The first error is confusing to the user because in this case they were working ins

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4150: Tenancy Error Message when Delivery Service Already Exists

mitchell852 edited a comment on issue #4150: Tenancy Error Message when Delivery Service Already Exists URL: https://github.com/apache/trafficcontrol/issues/4150#issuecomment-561293506 This is an interesting one. The first error is confusing to the user because in this case they were work

[GitHub] [trafficcontrol] mitchell852 commented on issue #4054: cache_stats endpoint orderby=value returns Internal Server Error

mitchell852 commented on issue #4054: cache_stats endpoint orderby=value returns Internal Server Error URL: https://github.com/apache/trafficcontrol/issues/4054#issuecomment-561296183 @ZugNZwang - looks like orderby was never supported for this endpoint: https://github.com/apache/tr

Jenkins build is back to normal : trafficcontrol-PR #4854

See

[GitHub] [trafficcontrol] asf-ci commented on issue #4149: Server capabilities docs

asf-ci commented on issue #4149: Server capabilities docs URL: https://github.com/apache/trafficcontrol/pull/4149#issuecomment-561301376 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4854/ --

[GitHub] [trafficcontrol] asf-ci commented on issue #4125: Rewrite users/register to Go

asf-ci commented on issue #4125: Rewrite users/register to Go URL: https://github.com/apache/trafficcontrol/pull/4125#issuecomment-561307967 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4855/ --

[GitHub] [trafficcontrol] asf-ci commented on issue #4127: Rewrite GET stats_summary from Perl to Golang

asf-ci commented on issue #4127: Rewrite GET stats_summary from Perl to Golang URL: https://github.com/apache/trafficcontrol/pull/4127#issuecomment-561310283 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4856

[GitHub] [trafficcontrol] ocket8888 commented on issue #4150: Tenancy Error Message when Delivery Service Already Exists

ocket commented on issue #4150: Tenancy Error Message when Delivery Service Already Exists URL: https://github.com/apache/trafficcontrol/issues/4150#issuecomment-561319419 No that's definitely a regression: ```http HTTP/1.1 400 Bad Request Connection: keep-alive Access-Cont

[GitHub] [trafficcontrol] asf-ci commented on issue #4152: Remove some duplicate routes, tighten up some route regexes in routes.go

asf-ci commented on issue #4152: Remove some duplicate routes, tighten up some route regexes in routes.go URL: https://github.com/apache/trafficcontrol/pull/4152#issuecomment-561319825 Refer to this link for build results (access rights to CI server needed): https://builds.apache.or

[GitHub] [trafficcontrol] ocket8888 commented on issue #4150: Tenancy Error Message when Delivery Service Already Exists

ocket commented on issue #4150: Tenancy Error Message when Delivery Service Already Exists URL: https://github.com/apache/trafficcontrol/issues/4150#issuecomment-561321087 Actually, never mind, you're right. I was on the wrong tenant when I did the request that got me the above respon

[GitHub] [trafficcontrol] mhoppa commented on issue #4151: Unable to unassign a delivery service request

mhoppa commented on issue #4151: Unable to unassign a delivery service request URL: https://github.com/apache/trafficcontrol/issues/4151#issuecomment-561323124 Looks like postgres issue on the query -> ```ERROR: api.go:136: 2019-12-03T19:36:14.6387349Z: 172.21.0.1:51184 pq: invalid inpu

[GitHub] [trafficcontrol] mhoppa edited a comment on issue #4151: Unable to unassign a delivery service request

mhoppa edited a comment on issue #4151: Unable to unassign a delivery service request URL: https://github.com/apache/trafficcontrol/issues/4151#issuecomment-561323124 Looks like postgres issue on the query -> ``` ERROR: api.go:136: 2019-12-03T19:36:14.6387349Z: 172.21.0.1:51184 pq:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go

ocket commented on a change in pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go URL: https://github.com/apache/trafficcontrol/pull/4152#discussion_r353385836 ## File path: traffic_ops/traffic_ops_golang/routing/routing_test.go ###

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go

ocket commented on a change in pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go URL: https://github.com/apache/trafficcontrol/pull/4152#discussion_r353386354 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @

[GitHub] [trafficcontrol] ocket8888 commented on issue #4151: Unable to unassign a delivery service request

ocket commented on issue #4151: Unable to unassign a delivery service request URL: https://github.com/apache/trafficcontrol/issues/4151#issuecomment-561332648 Looks like the problem is in here: ```go v := null if req.AssigneeID != nil { v = strconv.Itoa(*req.AssigneeID)

[GitHub] [trafficcontrol] mhoppa commented on issue #4151: Unable to unassign a delivery service request

mhoppa commented on issue #4151: Unable to unassign a delivery service request URL: https://github.com/apache/trafficcontrol/issues/4151#issuecomment-561333018 Putting up a fix now 👍 This is an automated message from the Apac

[GitHub] [trafficcontrol] asf-ci commented on issue #4127: Rewrite GET stats_summary from Perl to Golang

asf-ci commented on issue #4127: Rewrite GET stats_summary from Perl to Golang URL: https://github.com/apache/trafficcontrol/pull/4127#issuecomment-561334839 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4858

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4153: Fix unassign ds req bug

mhoppa opened a new pull request #4153: Fix unassign ds req bug URL: https://github.com/apache/trafficcontrol/pull/4153 ## What does this PR (Pull Request) do? - [x] This PR fixes #4151 ## Which Traffic Control components are affected by this PR? - Traff

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go

rawlinp commented on a change in pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go URL: https://github.com/apache/trafficcontrol/pull/4152#discussion_r353398734 ## File path: traffic_ops/traffic_ops_golang/routing/routing_test.go #

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go

rawlinp commented on a change in pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go URL: https://github.com/apache/trafficcontrol/pull/4152#discussion_r353399127 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4150: Tenancy Error Message when Delivery Service Already Exists

mitchell852 edited a comment on issue #4150: Tenancy Error Message when Delivery Service Already Exists URL: https://github.com/apache/trafficcontrol/issues/4150#issuecomment-561340008 > If we're returning that they have insufficient permissions to modify a DS, then we've already disclose

[GitHub] [trafficcontrol] mitchell852 commented on issue #4150: Tenancy Error Message when Delivery Service Already Exists

mitchell852 commented on issue #4150: Tenancy Error Message when Delivery Service Already Exists URL: https://github.com/apache/trafficcontrol/issues/4150#issuecomment-561340008 > If we're returning that they have insufficient permissions to modify a DS, then we've already disclosed the D

[GitHub] [trafficcontrol] mitchell852 merged pull request #4153: Fix unassign ds req bug

mitchell852 merged pull request #4153: Fix unassign ds req bug URL: https://github.com/apache/trafficcontrol/pull/4153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [trafficcontrol] mitchell852 closed issue #4151: Unable to unassign a delivery service request

mitchell852 closed issue #4151: Unable to unassign a delivery service request URL: https://github.com/apache/trafficcontrol/issues/4151 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [trafficcontrol] ocket8888 commented on issue #4150: Tenancy Error Message when Delivery Service Already Exists

ocket commented on issue #4150: Tenancy Error Message when Delivery Service Already Exists URL: https://github.com/apache/trafficcontrol/issues/4150#issuecomment-561347411 Yes, the second one is a much better UX. This is

[GitHub] [trafficcontrol] asf-ci commented on issue #4153: Fix unassign ds req bug

asf-ci commented on issue #4153: Fix unassign ds req bug URL: https://github.com/apache/trafficcontrol/pull/4153#issuecomment-561348299 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4859/ ---

[GitHub] [trafficcontrol] mitchell852 merged pull request #4149: Server capabilities docs

mitchell852 merged pull request #4149: Server capabilities docs URL: https://github.com/apache/trafficcontrol/pull/4149 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [trafficcontrol] asf-ci commented on issue #4152: Remove some duplicate routes, tighten up some route regexes in routes.go

asf-ci commented on issue #4152: Remove some duplicate routes, tighten up some route regexes in routes.go URL: https://github.com/apache/trafficcontrol/pull/4152#issuecomment-561390538 Refer to this link for build results (access rights to CI server needed): https://builds.apache.or

[GitHub] [trafficcontrol] ocket8888 merged pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go

ocket merged pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go URL: https://github.com/apache/trafficcontrol/pull/4152 This is an automated message from the Apache Git Service.

Build failed in Jenkins: trafficcontrol-PR #4861

See Changes: [mitchell852] Fix unassign ds req bug (#4153) [mitchell852] Server capabilities docs (#4149) [ocket] Rewrote /user/current to Go [ocket] Update CHANGELOG [ocket] add client method fo

[GitHub] [trafficcontrol] asf-ci commented on issue #3996: Rewrote /user/current to Go

asf-ci commented on issue #3996: Rewrote /user/current to Go URL: https://github.com/apache/trafficcontrol/pull/3996#issuecomment-561433628 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4861/ ---

Jenkins build is back to normal : trafficcontrol-PR #4862

See

[GitHub] [trafficcontrol] asf-ci commented on issue #3598: Removed restangular from UserService

asf-ci commented on issue #3598: Removed restangular from UserService URL: https://github.com/apache/trafficcontrol/pull/3598#issuecomment-561439433 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4862/ --