[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox
mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378983632 ## File path:

[GitHub] [trafficcontrol] mhoppa commented on issue #4257: Get request to api_capabilities using query values that don't exist return null

2020-02-13 Thread GitBox
mhoppa commented on issue #4257: Get request to api_capabilities using query values that don't exist return null URL: https://github.com/apache/trafficcontrol/issues/4257#issuecomment-585801557 this was fixed in https://github.com/apache/trafficcontrol/pull/4321 @mitchell852 @rawlinp

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox
mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378982702 ## File path:

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox
mhoppa commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378985577 ## File path:

[GitHub] [trafficcontrol] mhoppa commented on issue #4386: Fix dnssec refresh endpoint

2020-02-13 Thread GitBox
mhoppa commented on issue #4386: Fix dnssec refresh endpoint URL: https://github.com/apache/trafficcontrol/pull/4386#issuecomment-585855654 ready for review please remove the WIP tag This is an automated message from the

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox
mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378984778 ## File path:

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox
mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378982102 ## File path:

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox
mhoppa commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378935342 ## File path:

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox
mhoppa commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r378936950 ## File path:

[GitHub] [trafficcontrol] rawlinp closed issue #4257: Get request to api_capabilities using query values that don't exist return null

2020-02-13 Thread GitBox
rawlinp closed issue #4257: Get request to api_capabilities using query values that don't exist return null URL: https://github.com/apache/trafficcontrol/issues/4257 This is an automated message from the Apache Git Service.

Build failed in Jenkins: trafficcontrol-PR #5311

2020-02-13 Thread Apache Jenkins Server
See Changes: [github] Make pkg.ps1 compatible with PowerShell Core (OSS version) (#4391) [matthew_jackson] Added IPv6 checking to Traffic Monitor [matthew_jackson] updated CHANGELOG [matthew_jackson] update

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox
mitchell852 commented on a change in pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables URL: https://github.com/apache/trafficcontrol/pull/4394#discussion_r379014401 ## File path:

Build failed in Jenkins: trafficcontrol-PR #5312

2020-02-13 Thread Apache Jenkins Server
See Changes: [mitchell852] adds column configurability to users tables [mitchell852] adds column configurability to parameters tables [mitchell852] adds back the action column for each of parameter removal

Build failed in Jenkins: trafficcontrol-PR #5314

2020-02-13 Thread Apache Jenkins Server
See Changes: -- [...truncated 2.68 MB...] docs_1 | writing output... [ 81%] api/user_reset_password docs_1 | writing output... [

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4397: Fixed /api/2.0/roles always returning empty array

2020-02-13 Thread GitBox
ocket opened a new pull request #4397: Fixed /api/2.0/roles always returning empty array URL: https://github.com/apache/trafficcontrol/pull/4397 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue The `/roles` endpoint when called in API version

[GitHub] [trafficcontrol] ocket8888 commented on issue #4397: Fixed /api/2.0/roles always returning empty array

2020-02-13 Thread GitBox
ocket commented on issue #4397: Fixed /api/2.0/roles always returning empty array URL: https://github.com/apache/trafficcontrol/pull/4397#issuecomment-585945318 Not really sure about "medium", but at best it means that new users can not be created and old ones can't be updated - which

Jenkins build is back to normal : trafficcontrol-PR #5315

2020-02-13 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4397: Fixed /api/2.0/roles always returning empty array

2020-02-13 Thread GitBox
ocket commented on a change in pull request #4397: Fixed /api/2.0/roles always returning empty array URL: https://github.com/apache/trafficcontrol/pull/4397#discussion_r379107649 ## File path: traffic_ops/traffic_ops_golang/role/roles.go ## @@ -164,6 +164,11 @@ func

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox
rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379024121 ## File path: traffic_monitor/manager/manager.go ## @@ -45,6 +46,8 @@ import ( func

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4399: Fixed '/deliveryservices' not working with API 2.0

2020-02-13 Thread GitBox
ocket opened a new pull request #4399: Fixed '/deliveryservices' not working with API 2.0 URL: https://github.com/apache/trafficcontrol/pull/4399 ## What does this PR (Pull Request) do? - [x] This PR fixes #4398 This fixes the version-checking logic of the handler for GET

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1833

2020-02-13 Thread Apache Jenkins Server
See Changes: [github] TP: adds configurability (show/hide columns) to the parameters and users [github] Fixed /api/2.0/roles always returning empty array (#4397) [github] Fixed

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox
rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379024121 ## File path: traffic_monitor/manager/manager.go ## @@ -45,6 +46,8 @@ import ( func

[GitHub] [trafficcontrol] ocket8888 opened a new issue #4398: /deliveryservices GET handler internal server error in 2.0

2020-02-13 Thread GitBox
ocket opened a new issue #4398: /deliveryservices GET handler internal server error in 2.0 URL: https://github.com/apache/trafficcontrol/issues/4398 ## I'm submitting a ... - bug report ## Traffic Control components affected ... - Traffic Ops ## Current behavior:

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4400: TP: Fixes missubg ecs enabled property on a number of ds tables

2020-02-13 Thread GitBox
mitchell852 opened a new pull request #4400: TP: Fixes missubg ecs enabled property on a number of ds tables URL: https://github.com/apache/trafficcontrol/pull/4400 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue ## Which Traffic Control

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox
rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379024121 ## File path: traffic_monitor/manager/manager.go ## @@ -45,6 +46,8 @@ import ( func

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox
ocket commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379037787 ## File path: traffic_monitor/manager/manager.go ## @@ -45,6 +46,8 @@ import (

Build failed in Jenkins: trafficcontrol-PR #5313

2020-02-13 Thread Apache Jenkins Server
See Changes: [github] Rewrote deliveryservices/{{ID}/safe to Go (#4388) [github] Deprecate /regions/name/{{name}} (#4357) [github] Remove methods marked as deprecated in 3.x (#4390) [github] Added

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4397: Fixed /api/2.0/roles always returning empty array

2020-02-13 Thread GitBox
mhoppa commented on a change in pull request #4397: Fixed /api/2.0/roles always returning empty array URL: https://github.com/apache/trafficcontrol/pull/4397#discussion_r379104175 ## File path: traffic_ops/traffic_ops_golang/role/roles.go ## @@ -164,6 +164,11 @@ func

[GitHub] [trafficcontrol] ocket8888 merged pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-13 Thread GitBox
ocket merged pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables URL: https://github.com/apache/trafficcontrol/pull/4394 This is an automated message from the Apache Git

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox
rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379024121 ## File path: traffic_monitor/manager/manager.go ## @@ -45,6 +46,8 @@ import ( func

[GitHub] [trafficcontrol] mitchell852 closed issue #4398: /deliveryservices GET handler internal server error in 2.0

2020-02-13 Thread GitBox
mitchell852 closed issue #4398: /deliveryservices GET handler internal server error in 2.0 URL: https://github.com/apache/trafficcontrol/issues/4398 This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] mitchell852 merged pull request #4399: Fixed '/deliveryservices' not working with API 2.0

2020-02-13 Thread GitBox
mitchell852 merged pull request #4399: Fixed '/deliveryservices' not working with API 2.0 URL: https://github.com/apache/trafficcontrol/pull/4399 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] mitchell852 merged pull request #4397: Fixed /api/2.0/roles always returning empty array

2020-02-13 Thread GitBox
mitchell852 merged pull request #4397: Fixed /api/2.0/roles always returning empty array URL: https://github.com/apache/trafficcontrol/pull/4397 This is an automated message from the Apache Git Service. To respond to the

Build failed in Jenkins: trafficcontrol-PR #5321

2020-02-13 Thread Apache Jenkins Server
See Changes: [ocket] Updated experimental Angular8 TP to use TOAPI v2.0 [ocket] Updated CDN-in-a-Box to use TOAPI v2.0 [ocket] Updated atstccfg library to use TOAPI v2.0 (don't think that

Jenkins build is back to normal : trafficcontrol-PR #5322

2020-02-13 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox
rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379169003 ## File path: traffic_monitor/poller/cache.go ## @@ -162,14 +181,30 @@ func poller(

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox
rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379176893 ## File path: traffic_ops/traffic_ops_golang/crconfig/servers.go ## @@ -111,7 +111,7

Build failed in Jenkins: trafficcontrol-PR #5324

2020-02-13 Thread Apache Jenkins Server
See Changes: -- GitHub pull request #4401 of commit 126e65aaf414ed5f4d2a9b01ef9ed1a6ddef9dfc, no merge conflicts. Running as SYSTEM Setting status of

Build failed in Jenkins: trafficcontrol-PR #5325

2020-02-13 Thread Apache Jenkins Server
See Changes: [mitchell852] upgrades load-grunt-config to 3.0.1 -- [...truncated 2.87 MB...] docs_1 | writing output... [ 75%]

[GitHub] [trafficcontrol] mitchell852 commented on issue #4400: TP: Fixes missing ecs enabled property on a number of ds tables

2020-02-13 Thread GitBox
mitchell852 commented on issue #4400: TP: Fixes missing ecs enabled property on a number of ds tables URL: https://github.com/apache/trafficcontrol/pull/4400#issuecomment-585994819 @mattjackson220 is going to review this.

Build failed in Jenkins: trafficcontrol-PR #5319

2020-02-13 Thread Apache Jenkins Server
See Changes: -- GitHub pull request #4396 of commit b0ca67c0effb0f32041ec95cf4b54958fcbce359, no merge conflicts. Running as SYSTEM Setting status of

Build failed in Jenkins: trafficcontrol-PR #5320

2020-02-13 Thread Apache Jenkins Server
See Changes: -- GitHub pull request #4396 of commit c86f0b09951c1c4db99299c213579e697e59e169, no merge conflicts. Running as SYSTEM Setting status of

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4371: API 2.0 documentation

2020-02-13 Thread GitBox
ocket commented on a change in pull request #4371: API 2.0 documentation URL: https://github.com/apache/trafficcontrol/pull/4371#discussion_r379171815 ## File path: docs/source/api/v2/cdns_name_snapshot.rst ## @@ -0,0 +1,542 @@ +.. +.. +.. Licensed under the Apache

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4371: API 2.0 documentation

2020-02-13 Thread GitBox
ocket commented on a change in pull request #4371: API 2.0 documentation URL: https://github.com/apache/trafficcontrol/pull/4371#discussion_r379172049 ## File path: docs/source/api/v2/cdns_name_snapshot_new.rst ## @@ -0,0 +1,545 @@ +.. +.. +.. Licensed under the Apache

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-13 Thread GitBox
ocket commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r379192083 ## File path:

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox
rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379160057 ## File path: traffic_monitor/health/cache.go ## @@ -171,45 +172,100 @@ func

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4401: TP: upgrades load-grunt-config to 3.0.1 and removes grun-usemin

2020-02-13 Thread GitBox
mitchell852 opened a new pull request #4401: TP: upgrades load-grunt-config to 3.0.1 and removes grun-usemin URL: https://github.com/apache/trafficcontrol/pull/4401 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue ## Which Traffic Control

[GitHub] [trafficcontrol] ocket8888 commented on issue #4401: TP: upgrades application build dependencies

2020-02-13 Thread GitBox
ocket commented on issue #4401: TP: upgrades application build dependencies URL: https://github.com/apache/trafficcontrol/pull/4401#issuecomment-586011557 Why upgrade that one, specifically? Most of our dependencies are pretty out-of-date

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing

2020-02-13 Thread GitBox
rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches, including monitoring and routing URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379043530 ## File path: traffic_monitor/manager/manager.go ## @@ -45,6 +46,8 @@ import ( func

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

2020-02-13 Thread GitBox
mhoppa commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r379063930 ## File path: traffic_ops/traffic_ops_golang/api/shared_handlers.go ## @@