[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-29 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340247925 ## File path: traffic_ops/app/conf/cdn.conf ## @@ -1,7 +1,7 @@ { "hypnotoad" : {

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-29 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340233091 ## File path: docs/source/api/federations.rst ## @@ -150,82 +173,122 @@ Request Structure

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-29 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r340198521 ## File path: docs/source/api/federations.rst ## @@ -150,82 +173,122 @@ Request Structure

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339835934 ## File path: traffic_ops/traffic_ops_golang/api/api.go ## @@ -86,7 +86,7 @@ func

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339835857 ## File path: traffic_ops/traffic_ops_golang/federations/federations.go ## @@ -167,3 +206,296

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339835100 ## File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go ## @@ -346,3 +430,17 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339834865 ## File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go ## @@ -42,6 +42,75 @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE

2019-10-28 Thread GitBox
ocket commented on a change in pull request #4015: Rewrite /federations to Go - POST/PUT/DELETE URL: https://github.com/apache/trafficcontrol/pull/4015#discussion_r339834661 ## File path: lib/go-tc/federation.go ## @@ -67,36 +80,85 @@ type FederationMapping struct {