[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4074: Set Content-Length header in Traffic Router
ocket commented on a change in pull request #4074: Set Content-Length header in Traffic Router URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r342164768 ## File path: docs/source/development/traffic_router/traffic_router_api.rst ## @@ -364,18 +364,18 @@ Request Structure GET /crs/consistenthash/deliveryservice?deliveryServiceId=demo1=/ HTTP/1.1 Host: trafficrouter.infra.ciab.test - User-Agent: curl/7.47.0 + User-Agent: curl/7.52.1 Accept: */* Response Structure -- .. code-block:: http - :caption: Response Example + :caption: Response Example (JSON expanded) - HTTP/1.1 200 OK + HTTP/1.1 200 Review comment: Same as above RE: reason-phrase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4074: Set Content-Length header in Traffic Router
ocket commented on a change in pull request #4074: Set Content-Length header in Traffic Router URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r342164277 ## File path: docs/source/development/traffic_router/traffic_router_api.rst ## @@ -41,32 +41,32 @@ Request Structure GET /crs/stats HTTP/1.1 Host: trafficrouter.infra.ciab.test - User-Agent: curl/7.47.0 + User-Agent: curl/7.52.1 Accept: */* Response Structure -- .. code-block:: http - :caption: Response Example + :caption: Response Example (JSON expanded) - HTTP/1.1 200 OK + HTTP/1.1 200 Review comment: Though the HTTP spec doesn't actually care whether or not the reason-phrase exists, our lexer does. They're not accepting pull requests, trust me I've tried. So basically, this needs to be `HTTP/1.1 200 OK` not just `HTTP/1.1 200`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4074: Set Content-Length header in Traffic Router
ocket commented on a change in pull request #4074: Set Content-Length header in Traffic Router URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r342165423 ## File path: docs/source/development/traffic_router/traffic_router_api.rst ## @@ -41,32 +41,32 @@ Request Structure GET /crs/stats HTTP/1.1 Host: trafficrouter.infra.ciab.test - User-Agent: curl/7.47.0 + User-Agent: curl/7.52.1 Accept: */* Response Structure -- .. code-block:: http - :caption: Response Example + :caption: Response Example (JSON expanded) Review comment: You don't need to specify that the JSON has been expanded. Users are instructed to ignore the value of any `Content-Length` header. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4074: Set Content-Length header in Traffic Router
ocket commented on a change in pull request #4074: Set Content-Length header in Traffic Router URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r342164484 ## File path: docs/source/development/traffic_router/traffic_router_api.rst ## @@ -122,19 +122,19 @@ Request Structure GET /crs/stats/ip/255.255.255.255 HTTP/1.1 Host: trafficrouter.infra.ciab.test - User-Agent: curl/7.47.0 + User-Agent: curl/7.52.1 Accept: */* Response Structure -- .. code-block:: http - :caption: Response Example + :caption: Response Example (JSON expanded) - HTTP/1.1 200 OK + HTTP/1.1 200 Review comment: Same as above RE: reason-phrase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4074: Set Content-Length header in Traffic Router
ocket commented on a change in pull request #4074: Set Content-Length header in Traffic Router URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r342164567 ## File path: docs/source/development/traffic_router/traffic_router_api.rst ## @@ -160,20 +160,20 @@ Request Structure GET /crs/locations HTTP/1.1 Host: trafficrouter.infra.ciab.test - User-Agent: curl/7.47.0 + User-Agent: curl/7.52.1 Accept: */* Response Structure -- :locations: An array of the names of :term:`Cache Groups` to which this Traffic Router is capable of routing client traffic .. code-block:: http - :caption: Response Example + :caption: Response Example (JSON expanded) - HTTP/1.1 200 OK + HTTP/1.1 200 Review comment: Same as above RE: reason-phrase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4074: Set Content-Length header in Traffic Router
ocket commented on a change in pull request #4074: Set Content-Length header in Traffic Router URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r342164692 ## File path: docs/source/development/traffic_router/traffic_router_api.rst ## @@ -244,26 +244,26 @@ Request Structure GET /crs/locations/CDN_in_a_Box_Edge/caches HTTP/1.1 Host: trafficrouter.infra.ciab.test - User-Agent: curl/7.47.0 + User-Agent: curl/7.52.1 Accept: */* Response Structure -- .. code-block:: http - :caption: Response Example + :caption: Response Example (JSON expanded) - HTTP/1.1 200 OK + HTTP/1.1 200 Review comment: Same as above RE: reason-phrase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4074: Set Content-Length header in Traffic Router
ocket commented on a change in pull request #4074: Set Content-Length header in Traffic Router URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r342164636 ## File path: docs/source/development/traffic_router/traffic_router_api.rst ## @@ -190,27 +190,27 @@ Request Structure GET /crs/locations/caches HTTP/1.1 Host: trafficrouter.infra.ciab.test - User-Agent: curl/7.47.0 + User-Agent: curl/7.52.1 Accept: */* Response Structure -- .. code-block:: http - :caption: Response Example + :caption: Response Example (JSON expanded) - HTTP/1.1 200 OK + HTTP/1.1 200 Review comment: Same as above RE: reason-phrase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4074: Set Content-Length header in Traffic Router
ocket commented on a change in pull request #4074: Set Content-Length header in Traffic Router URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r342164955 ## File path: docs/source/development/traffic_router/traffic_router_api.rst ## @@ -539,25 +545,24 @@ Request Structure .. code-block:: http :caption: Request Example - GET /crs/consistenthash/patternbased/deliveryservice?deliveryServiceId=asdf=%2Fsometext1234%2Fstream_name%2Fasset_name.m3u8 HTTP/1.1 + GET /crs/consistenthash/patternbased/deliveryservice?deliveryServiceId=demo1=%2Fsometext1234%2Fstream_name%2Fasset_name.m3u8 HTTP/1.1 Host: localhost: - User-Agent: curl/7.54.0 + User-Agent: curl/7.52.1 Accept: */* Response Structure -- .. code-block:: http - :caption: Response Example + :caption: Response Example (JSON expanded) - HTTP/1.1 200 OK + HTTP/1.1 200 Review comment: Same as above RE: reason-phrase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4074: Set Content-Length header in Traffic Router
ocket commented on a change in pull request #4074: Set Content-Length header in Traffic Router URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r342164862 ## File path: docs/source/development/traffic_router/traffic_router_api.rst ## @@ -501,23 +508,22 @@ Request Structure GET /crs/consistenthash/patternbased/regex?regex=%2F.*%3F%28%2F.*%3F%2F%29.*%3F%28%5C.m3u8%29=%2Ftext1234%2Fname%2Fasset.m3u8 HTTP/1.1 Host: localhost: - User-Agent: curl/7.54.0 + User-Agent: curl/7.52.1 Accept: */* Response Structure -- .. code-block:: http - :caption: Response Example + :caption: Response Example (JSON expanded) - HTTP/1.1 200 OK + HTTP/1.1 200 Review comment: Same as above RE: reason-phrase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
