[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4707: Add an API test for DELETE /regions?name={{name}}

2020-05-20 Thread GitBox


zrhoffman commented on a change in pull request #4707:
URL: https://github.com/apache/trafficcontrol/pull/4707#discussion_r428374271



##
File path: CHANGELOG.md
##
@@ -11,6 +11,7 @@ The format is based on [Keep a 
Changelog](http://keepachangelog.com/en/1.0.0/).
 - Traffic Ops: Added an API 3.0 endpoint, /api/3.0/topologies, to create, 
read, update and delete flexible topologies.
 - Traffic Ops: Added support for `topology` query parameter to `GET 
/api/3.0/cachegroups` to return all cachegroups used in the given topology.
 - Traffic Portal: Added the ability to create, read, update and delete 
flexible topologies.
+- Added an API test for `DELETE /api/3.0/regions?name={{name}}`

Review comment:
   Okay, changelog entry gone in da68d318a.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4707: Add an API test for DELETE /regions?name={{name}}

2020-05-20 Thread GitBox


zrhoffman commented on a change in pull request #4707:
URL: https://github.com/apache/trafficcontrol/pull/4707#discussion_r428363721



##
File path: CHANGELOG.md
##
@@ -11,6 +11,7 @@ The format is based on [Keep a 
Changelog](http://keepachangelog.com/en/1.0.0/).
 - Traffic Ops: Added an API 3.0 endpoint, /api/3.0/topologies, to create, 
read, update and delete flexible topologies.
 - Traffic Ops: Added support for `topology` query parameter to `GET 
/api/3.0/cachegroups` to return all cachegroups used in the given topology.
 - Traffic Portal: Added the ability to create, read, update and delete 
flexible topologies.
+- Added an API test for `DELETE /api/3.0/regions?name={{name}}`

Review comment:
   This API test currently fails due to a regression in #4704. This PR will 
is intended to include a fix, and bugfixes should be included in the changelog. 
When the fix is pushed, I'll update the existing changelog entry instead of 
adding a new one.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org