[GitHub] [trafficcontrol] zrhoffman commented on issue #4290: Undocumented Traffic Ops Golang routes

2020-01-15 Thread GitBox
zrhoffman commented on issue #4290: Undocumented Traffic Ops Golang routes
URL: https://github.com/apache/trafficcontrol/issues/4290#issuecomment-574889927
 
 
   Oops, my update didn't save. It should be good now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [trafficcontrol] zrhoffman commented on issue #4290: Undocumented Traffic Ops Golang routes

2020-01-15 Thread GitBox
zrhoffman commented on issue #4290: Undocumented Traffic Ops Golang routes
URL: https://github.com/apache/trafficcontrol/issues/4290#issuecomment-574884937
 
 
   > [...] [T]he `/deliveryservices/dnsseckeys/generate` [...] docs page can 
get removed [...].
   
   Now the issue mentions removing the `deliveryservices/dnsseckeys/generate` 
page.
   
   > By the way, can you turn your list in the Issue into a checklist, so that 
items can be checked off as they're done?
   
   Updated.
   
   > Also, looks like your bottom list has /types/{{ID}} in it twice.
   
   Thanks, fixed. In a draft, they were links to the different sections of ATC 
Read the Docs site.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [trafficcontrol] zrhoffman commented on issue #4290: Undocumented Traffic Ops Golang routes

2020-01-15 Thread GitBox
zrhoffman commented on issue #4290: Undocumented Traffic Ops Golang routes
URL: https://github.com/apache/trafficcontrol/issues/4290#issuecomment-574796877
 
 
   Added them.
   
   Also, that issue also mentions incomplete documentation for [POST 
`deliveryservices/dnsseckeys/generate`](https://github.com/apache/trafficcontrol/blob/RELEASE-4.0.0-RC0/docs/source/api/deliveryservices_dnsseckeys_generate.rst).
 I have been unsuccessful finding any history of references to that route in 
the project (including TO Perl) except [in the Python TO 
client](https://github.com/apache/trafficcontrol/blob/RELEASE-4.0.0-RC1/traffic_control/clients/python/trafficops/tosession.py#L754)
 and in our documentation. The route itself 404s. Can we just remove that page?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [trafficcontrol] zrhoffman commented on issue #4290: Undocumented Traffic Ops Golang routes

2020-01-13 Thread GitBox
zrhoffman commented on issue #4290: Undocumented Traffic Ops Golang routes
URL: https://github.com/apache/trafficcontrol/issues/4290#issuecomment-573932216
 
 
   These endpoints are documented:
   * POST `roles`
   * PUT `roles`
   * DELETE `roles`
   
   These endpoints from that issue are listed in this one (and are still 
undocumented):
   * GET `steering`
   * GET/POST/PUT/DELETE `deliveryservice_requests`
   
   These endpoints are still undocumented yet unmentioned in this issue:
   * DELETE `divisions/{{ID}}`
   * DELETE `regions/{{ID}}`
   
   @ocket Should I add those endpoints to this issue so we have a list of 
undocumented ones in one place?
   
   Not sure which exact endpoints that issue is referring to:
   * POST type
   * PUT type
   * DELETE type
   
   ---
   
   Also, I have edited this issue to specify which HTTP methods the mentioned 
endpoints are defined for.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [trafficcontrol] zrhoffman commented on issue #4290: Undocumented Traffic Ops Golang routes

2020-01-13 Thread GitBox
zrhoffman commented on issue #4290: Undocumented Traffic Ops Golang routes
URL: https://github.com/apache/trafficcontrol/issues/4290#issuecomment-573916512
 
 
   The following routes are also mentioned in #3443:
   
   * GET `steering`
   * GET/POST/PUT/DELETE `deliveryservice_requests `


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services