[GitHub] asfgit commented on issue #2010: Go login

asfgit commented on issue #2010: Go login URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-375312705 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1265/ Test

[GitHub] dewrich opened a new pull request #2031: Created the swaggerdocs dir to document the /cdns API

dewrich opened a new pull request #2031: Created the swaggerdocs dir to document the /cdns API URL: https://github.com/apache/incubator-trafficcontrol/pull/2031 This is an automated message from the Apache Git Service. To

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #571

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1268 originally caused by: GitHub pull request #2027 of commit

[GitHub] asfgit commented on issue #2027: [Issue 1819/1820] - adds ds request comments to TP

asfgit commented on issue #2027: [Issue 1819/1820] - adds ds request comments to TP URL: https://github.com/apache/incubator-trafficcontrol/pull/2027#issuecomment-375343375 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2031: Created the swaggerdocs dir to document the /cdns API

asfgit commented on issue #2031: Created the swaggerdocs dir to document the /cdns API URL: https://github.com/apache/incubator-trafficcontrol/pull/2031#issuecomment-375346891 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR #1268

See -- GitHub pull request #2027 of commit 037744ba6c35790ba0f79a5170699c2d3b563d93, no merge conflicts. Setting status of 037744ba6c35790ba0f79a5170699c2d3b563d93 to

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #568

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1265 originally caused by: GitHub pull request #2010 of commit

[GitHub] asfgit commented on issue #2031: Created the swaggerdocs dir to document the /cdns API

asfgit commented on issue #2031: Created the swaggerdocs dir to document the /cdns API URL: https://github.com/apache/incubator-trafficcontrol/pull/2031#issuecomment-375319603 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR #1266

See -- GitHub pull request #2031 of commit dcd007bc02f71a55a3596501ffcc77141922abc4, no merge conflicts. Setting status of dcd007bc02f71a55a3596501ffcc77141922abc4 to

[GitHub] asfgit commented on issue #2031: Created the swaggerdocs dir to document the /cdns API

asfgit commented on issue #2031: Created the swaggerdocs dir to document the /cdns API URL: https://github.com/apache/incubator-trafficcontrol/pull/2031#issuecomment-375324997 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #570

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1267 originally caused by: GitHub pull request #2031 of commit

Build failed in Jenkins: incubator-trafficcontrol-PR #1267

See -- GitHub pull request #2031 of commit 401e02d6698834d01140c40c32e65e6d8fbfd4c3, no merge conflicts. Setting status of 401e02d6698834d01140c40c32e65e6d8fbfd4c3 to

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #572

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1269 originally caused by: GitHub pull request #2031 of commit

Jenkins build is back to normal : incubator-trafficcontrol-PR #1269

See

[GitHub] limited commented on a change in pull request #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/…

limited commented on a change in pull request #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/… URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r176469393 ## File path: CHANGELOG.md ## @@ -34,6 +34,7 @@ The format

[GitHub] mitchell852 commented on issue #2030: Feature: UI elements to delete active invalidation rules & queue revalidations

mitchell852 commented on issue #2030: Feature: UI elements to delete active invalidation rules & queue revalidations URL: https://github.com/apache/incubator-trafficcontrol/issues/2030#issuecomment-375366000 I think this would require 2 things: 1. A new API endpoint like POST

[GitHub] mitchell852 opened a new issue #2034: TO API - provide the ability to CRUD roles

mitchell852 opened a new issue #2034: TO API - provide the ability to CRUD roles URL: https://github.com/apache/incubator-trafficcontrol/issues/2034 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mitchell852 opened a new issue #2039: Show/hide UI views based on capabilities

mitchell852 opened a new issue #2039: Show/hide UI views based on capabilities URL: https://github.com/apache/incubator-trafficcontrol/issues/2039 Currently, in TP all views are displayed regardless of role. However, role is enforced when trying to access each view. This can result in an

[GitHub] mitchell852 commented on issue #2030: Feature: UI elements to delete active invalidation rules & queue revalidations

mitchell852 commented on issue #2030: Feature: UI elements to delete active invalidation rules & queue revalidations URL: https://github.com/apache/incubator-trafficcontrol/issues/2030#issuecomment-375366000 I think this would require 2 things: 1. A new API endpoint like POST

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #573

See

[GitHub] asfgit commented on issue #2027: [Issue 1819/1820] - adds ds request comments to TP

asfgit commented on issue #2027: [Issue 1819/1820] - adds ds request comments to TP URL: https://github.com/apache/incubator-trafficcontrol/pull/2027#issuecomment-375368525 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 commented on issue #2036: [Portal] store case-insensitive user info in DB

mitchell852 commented on issue #2036: [Portal] store case-insensitive user info in DB URL: https://github.com/apache/incubator-trafficcontrol/issues/2036#issuecomment-375377313 I think this should be as simple as using a lower(email) when doing an insert or an update to the user table.

[GitHub] mitchell852 opened a new issue #2037: Seed roles, capabilities and api endpoints

mitchell852 opened a new issue #2037: Seed roles, capabilities and api endpoints URL: https://github.com/apache/incubator-trafficcontrol/issues/2037 - [ ] Seed default roles - [ ] Seed default capabilities - [ ] Seed default api endpoints - [ ] Seed default roles/capability

[GitHub] mtorluemke opened a new issue #2032: ORT doesn't notice new TLS certs

mtorluemke opened a new issue #2032: ORT doesn't notice new TLS certs URL: https://github.com/apache/incubator-trafficcontrol/issues/2032 For most ATS config files, the line ordering doesn't matter when determining if a file has changed. For TLS certs, the order actually does matter. So,

[GitHub] mitchell852 opened a new issue #2033: TP - provide the ability to CRUD roles

mitchell852 opened a new issue #2033: TP - provide the ability to CRUD roles URL: https://github.com/apache/incubator-trafficcontrol/issues/2033 This is an automated message from the Apache Git Service. To respond to the

[GitHub] tyagian opened a new issue #2036: [Portal] store case-insensitive user info in DB

tyagian opened a new issue #2036: [Portal] store case-insensitive user info in DB URL: https://github.com/apache/incubator-trafficcontrol/issues/2036 I found this issue while adding a user. TP store case sensitive email-id of user. Eg. If we add new user email-id a...@foo.com during

[GitHub] mitchell852 commented on issue #2027: [Issue 1819/1820] - adds ds request comments to TP

mitchell852 commented on issue #2027: [Issue 1819/1820] - adds ds request comments to TP URL: https://github.com/apache/incubator-trafficcontrol/pull/2027#issuecomment-375366828 retest this please This is an automated

[GitHub] mitchell852 opened a new issue #2035: TP - Provide ability to associate roles w/ capabilities

mitchell852 opened a new issue #2035: TP - Provide ability to associate roles w/ capabilities URL: https://github.com/apache/incubator-trafficcontrol/issues/2035 - [ ] Add a capability to a role - [ ] Remove a capability from a role

[GitHub] mitchell852 opened a new issue #2038: Enforce capabilities for API requests

mitchell852 opened a new issue #2038: Enforce capabilities for API requests URL: https://github.com/apache/incubator-trafficcontrol/issues/2038 Each API request needs to be authorized using the capabilities of the user as defined by the user's role. If authorization fails, a 403 Forbidden

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #569

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1266 originally caused by: GitHub pull request #2031 of commit

[GitHub] mitchell852 opened a new issue #2043: TP - provide the ability to manage roles/capability mappings

mitchell852 opened a new issue #2043: TP - provide the ability to manage roles/capability mappings URL: https://github.com/apache/incubator-trafficcontrol/issues/2043 - [ ] Add a capability to a role - [ ] Remove a capability from a role Depends on #2035

[GitHub] mitchell852 opened a new issue #2041: TO API - provide the ability to manage capabilities

mitchell852 opened a new issue #2041: TO API - provide the ability to manage capabilities URL: https://github.com/apache/incubator-trafficcontrol/issues/2041 - [ ] GET /capabilities <-- readonly role required - [ ] GET /capabilities/:id <-- readonly role required - [ ] GET

[GitHub] mitchell852 opened a new issue #2042: TP - provide the ability to manage capabilties

mitchell852 opened a new issue #2042: TP - provide the ability to manage capabilties URL: https://github.com/apache/incubator-trafficcontrol/issues/2042 - [ ] Show all capabilities - [ ] Show a specific capability - [ ] Show all users for a capability - [ ] Show all roles for a

[GitHub] mitchell852 commented on issue #2040: TO API - provide the ability to manage roles/capability mappings

mitchell852 commented on issue #2040: TO API - provide the ability to manage roles/capability mappings URL: https://github.com/apache/incubator-trafficcontrol/issues/2040#issuecomment-375400861 duplicate of #2035 This is

[GitHub] mitchell852 opened a new issue #2040: TO API - provide the ability to manage roles/capability mappings

mitchell852 opened a new issue #2040: TO API - provide the ability to manage roles/capability mappings URL: https://github.com/apache/incubator-trafficcontrol/issues/2040 Provide the ability to map roles to capabilities. For example POST /api/rolecapability OR POST

[GitHub] mitchell852 closed issue #2040: TO API - provide the ability to manage roles/capability mappings

mitchell852 closed issue #2040: TO API - provide the ability to manage roles/capability mappings URL: https://github.com/apache/incubator-trafficcontrol/issues/2040 This is an automated message from the Apache Git Service.

[GitHub] mitchell852 commented on issue #2036: [Portal] store case-insensitive user info in DB

mitchell852 commented on issue #2036: [Portal] store case-insensitive user info in DB URL: https://github.com/apache/incubator-trafficcontrol/issues/2036#issuecomment-375377562 i also think the post("/api/$version/users/register route would need to do this as well

[GitHub] mitchell852 commented on issue #1744: Deleting a header rewrite rule causes ORT problems

mitchell852 commented on issue #1744: Deleting a header rewrite rule causes ORT problems URL: https://github.com/apache/incubator-trafficcontrol/issues/1744#issuecomment-375436699 I think this line needs to be fixed

[GitHub] mitchell852 opened a new pull request #2045: [Issue 2019] - when deleting a param, it shows the profiles that use the param.

mitchell852 opened a new pull request #2045: [Issue 2019] - when deleting a param, it shows the profiles that use the param. URL: https://github.com/apache/incubator-trafficcontrol/pull/2045 fixes #2019 This is an automated

[GitHub] mitchell852 commented on issue #2015: Traffic Portal: clone parameters (feature request)

mitchell852 commented on issue #2015: Traffic Portal: clone parameters (feature request) URL: https://github.com/apache/incubator-trafficcontrol/issues/2015#issuecomment-375450445 @guzzijason - when you clone this parameter, do you want the cloned parameter to be attached to the same

[GitHub] asfgit commented on issue #2010: Go login

asfgit commented on issue #2010: Go login URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-375453841 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1273/ Test

[GitHub] mitchell852 commented on issue #994: [TC-500] Creating/Updating a Delivery Service via API has length constraint on displayName of 48, but no such constraint in UI code

mitchell852 commented on issue #994: [TC-500] Creating/Updating a Delivery Service via API has length constraint on displayName of 48, but no such constraint in UI code URL: https://github.com/apache/incubator-trafficcontrol/issues/994#issuecomment-375454541 the maxlength of 48 is

[GitHub] mitchell852 closed issue #994: [TC-500] Creating/Updating a Delivery Service via API has length constraint on displayName of 48, but no such constraint in UI code

mitchell852 closed issue #994: [TC-500] Creating/Updating a Delivery Service via API has length constraint on displayName of 48, but no such constraint in UI code URL: https://github.com/apache/incubator-trafficcontrol/issues/994

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #576

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1273 originally caused by: GitHub pull request #2010 of commit

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #577

See

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #578

See -- Started by upstream project "incubator-trafficcontrol-PR" build number 1275 originally caused by: GitHub pull request #2010 of commit

[GitHub] asfgit commented on issue #2045: [Issue 2019] - when deleting a param, it shows the profiles that use the param.

asfgit commented on issue #2045: [Issue 2019] - when deleting a param, it shows the profiles that use the param. URL: https://github.com/apache/incubator-trafficcontrol/pull/2045#issuecomment-375456049 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2010: Go login

asfgit commented on issue #2010: Go login URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-375457921 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1275/ Test

[GitHub] dangogh opened a new pull request #2046: TO API: mid,edgeHeaderRewrite should be null if removed, not empty string

dangogh opened a new pull request #2046: TO API: mid,edgeHeaderRewrite should be null if removed, not empty string URL: https://github.com/apache/incubator-trafficcontrol/pull/2046 Expects a non-space character in the field. If not, substitutes undef so a null is written to the db.

[GitHub] asfgit commented on issue #2046: TO API: mid,edgeHeaderRewrite should be null if removed, not empty string

asfgit commented on issue #2046: TO API: mid,edgeHeaderRewrite should be null if removed, not empty string URL: https://github.com/apache/incubator-trafficcontrol/pull/2046#issuecomment-375467460 Refer to this link for build results (access rights to CI server needed):

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #579

See

[GitHub] elsloo closed pull request #2046: TO API: mid,edgeHeaderRewrite should be null if removed, not empty string

elsloo closed pull request #2046: TO API: mid,edgeHeaderRewrite should be null if removed, not empty string URL: https://github.com/apache/incubator-trafficcontrol/pull/2046 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] elsloo closed issue #1744: Deleting a header rewrite rule causes ORT problems

elsloo closed issue #1744: Deleting a header rewrite rule causes ORT problems URL: https://github.com/apache/incubator-trafficcontrol/issues/1744 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mitchell852 opened a new pull request #2047: [Issue 1050] - adds an optional charts button to the server page. enabled in traffic…

mitchell852 opened a new pull request #2047: [Issue 1050] - adds an optional charts button to the server page. enabled in traffic… URL: https://github.com/apache/incubator-trafficcontrol/pull/2047 …_portal_properties.json

[GitHub] elsloo closed pull request #2044: [Issue 2007] - adds cg parent and 2nd parent to cg table

elsloo closed pull request #2044: [Issue 2007] - adds cg parent and 2nd parent to cg table URL: https://github.com/apache/incubator-trafficcontrol/pull/2044 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] elsloo closed issue #2007: Need a way to see all the children cachegroups of a cachegroup

elsloo closed issue #2007: Need a way to see all the children cachegroups of a cachegroup URL: https://github.com/apache/incubator-trafficcontrol/issues/2007 This is an automated message from the Apache Git Service. To

[GitHub] asfgit commented on issue #1889: Add TO Golang CRConfig generation

asfgit commented on issue #1889: Add TO Golang CRConfig generation URL: https://github.com/apache/incubator-trafficcontrol/pull/1889#issuecomment-375547229 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2047: [Issue 1050] - adds an optional charts button to the server page. enabled in traffic…

asfgit commented on issue #2047: [Issue 1050] - adds an optional charts button to the server page. enabled in traffic… URL: https://github.com/apache/incubator-trafficcontrol/pull/2047#issuecomment-375475232 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #501

See Changes: [jeffrey_elsloo] for edgeHeaderRewrite and midHeaderRewrite, use undef value if non-blank -- [...truncated 2.41 MB...] unit_1

[GitHub] mitchell852 opened a new pull request #2044: [Issue 2007] - adds cg parent and 2nd parent to cg table

mitchell852 opened a new pull request #2044: [Issue 2007] - adds cg parent and 2nd parent to cg table URL: https://github.com/apache/incubator-trafficcontrol/pull/2044 This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #2031: Created the swaggerdocs dir to document the /cdns API

asfgit commented on issue #2031: Created the swaggerdocs dir to document the /cdns API URL: https://github.com/apache/incubator-trafficcontrol/pull/2031#issuecomment-375445713 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2044: [Issue 2007] - adds cg parent and 2nd parent to cg table

asfgit commented on issue #2044: [Issue 2007] - adds cg parent and 2nd parent to cg table URL: https://github.com/apache/incubator-trafficcontrol/pull/2044#issuecomment-375449406 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 commented on issue #2015: Traffic Portal: clone parameters (feature request)

mitchell852 commented on issue #2015: Traffic Portal: clone parameters (feature request) URL: https://github.com/apache/incubator-trafficcontrol/issues/2015#issuecomment-375450445 @guzzijason - when you clone this parameter, do you want the cloned parameter to be attached to the same