[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383509104 @mitchell852 I spent some time in the GoLang version implementation today and i have some doubts on GoLang

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383509104 @mitchell852 I spent some time in the GoLang version implementation today and i have some doubts on GoLang

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383509104 @mitchell852 I spent some time in the GoLang version implementation today and i have some doubts on GoLang

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383509104 @mitchell852 I spent some time in the GoLang version implementation today and i have some doubts on GoLang

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383509104 @mitchell852 I spent some time in the GoLang version implementation today and i have some doubts on GoLang

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383509104 @mitchell852 I spent some time in the GoLang version implementation today and i have some doubts on GoLang

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383509104 @mitchell852 I spent some time in the GoLang version implementation today and i have some doubts on GoLang

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383509104 @mitchell852 I spent some time in the GoLang version implementation today and i have some doubts on GoLang

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383509104 @mitchell852 I spent some time in the GoLang version implementation today and i have some doubts on GoLang

[GitHub] mitchell852 commented on issue #2055: deleting inactive delivery services requires double confirmation

2018-04-23 Thread GitBox
mitchell852 commented on issue #2055: deleting inactive delivery services requires double confirmation URL: https://github.com/apache/incubator-trafficcontrol/issues/2055#issuecomment-383586243 3 should be 3. then assign to you and "fulfill" (not delete)

[GitHub] mitchell852 commented on issue #2055: deleting inactive delivery services requires double confirmation

2018-04-23 Thread GitBox
mitchell852 commented on issue #2055: deleting inactive delivery services requires double confirmation URL: https://github.com/apache/incubator-trafficcontrol/issues/2055#issuecomment-383586243 #3 should be 3. then assign to you and "fulfill" (not delete)

[GitHub] mitchell852 commented on issue #2156: When renaming a host in TC, the hashId retains the value of the previous hostname

2018-04-23 Thread GitBox
mitchell852 commented on issue #2156: When renaming a host in TC, the hashId retains the value of the previous hostname URL: https://github.com/apache/incubator-trafficcontrol/issues/2156#issuecomment-383621185 This appears to be because in the crconfig.json file, the hashId is derived

[GitHub] guzzijason opened a new issue #2156: When renaming a host in TC, the hashId retains the value of the previous hostname

2018-04-23 Thread GitBox
guzzijason opened a new issue #2156: When renaming a host in TC, the hashId retains the value of the previous hostname URL: https://github.com/apache/incubator-trafficcontrol/issues/2156 Observed in TP 2.3.0-8247.fb69f019.el7 Possible hashId naming collision if previous hostname

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #746

2018-04-23 Thread Apache Jenkins Server
See

[GitHub] asfgit commented on issue #2103: Add a Coordinates API

2018-04-23 Thread GitBox
asfgit commented on issue #2103: Add a Coordinates API URL: https://github.com/apache/incubator-trafficcontrol/pull/2103#issuecomment-383629882 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1461/

[GitHub] rawlinp commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
rawlinp commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383638835 I reviewed the TR-side of the PR which looks good to me. Once the API-side is solid I'll pull this down and try out the

[GitHub] asfgit commented on issue #2158: modifies ORT to correctly parse api 1.3 for revalidation.

2018-04-23 Thread GitBox
asfgit commented on issue #2158: modifies ORT to correctly parse api 1.3 for revalidation. URL: https://github.com/apache/incubator-trafficcontrol/pull/2158#issuecomment-383709033 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595

2018-04-23 Thread GitBox
asfgit commented on issue #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595 URL: https://github.com/apache/incubator-trafficcontrol/pull/2157#issuecomment-383690560 Can one of the admins verify this patch?

[GitHub] rivasj opened a new pull request #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595

2018-04-23 Thread GitBox
rivasj opened a new pull request #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595 URL: https://github.com/apache/incubator-trafficcontrol/pull/2157 Added json response field use_reval_pending to update_status endpoint in golang API

[GitHub] asfgit commented on issue #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595

2018-04-23 Thread GitBox
asfgit commented on issue #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595 URL: https://github.com/apache/incubator-trafficcontrol/pull/2157#issuecomment-383691672 Can one of the admins verify this patch?

[GitHub] dg4prez closed pull request #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595

2018-04-23 Thread GitBox
dg4prez closed pull request #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595 URL: https://github.com/apache/incubator-trafficcontrol/pull/2157 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] dg4prez closed pull request #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595

2018-04-23 Thread GitBox
dg4prez closed pull request #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595 URL: https://github.com/apache/incubator-trafficcontrol/pull/2157 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] dg4prez commented on issue #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595

2018-04-23 Thread GitBox
dg4prez commented on issue #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595 URL: https://github.com/apache/incubator-trafficcontrol/pull/2157#issuecomment-383707470 Verified and tested against the ORT code in

[GitHub] rivasj opened a new pull request #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595

2018-04-23 Thread GitBox
rivasj opened a new pull request #2157: Added json response field use_reval_pending to update_status endpoint. Fixes #1595 URL: https://github.com/apache/incubator-trafficcontrol/pull/2157 Added json response field use_reval_pending to update_status endpoint in golang API

[GitHub] dg4prez opened a new pull request #2158: modifies ORT to correctly parse api 1.3 for revalidation.

2018-04-23 Thread GitBox
dg4prez opened a new pull request #2158: modifies ORT to correctly parse api 1.3 for revalidation. URL: https://github.com/apache/incubator-trafficcontrol/pull/2158 Updates ORT to work with the revised 1.3 update status API. If the use_reval_pending flag is not present, reverts to the

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #559

2018-04-23 Thread Apache Jenkins Server
See Changes: [mrdgelinas] added json response field use_reval_pending to update_status endpoint -- [...truncated 67.95 KB...] unit_golang_1 |

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-04-23 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-383798798 @rawlinp Thank you. Will let you know once we get the API endpoints right.