[GitHub] mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-04 Thread GitBox
mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-386650324 @elsloo - @Vijay-1 and I discussed/agreed on these API routes but I don't think the changes have been made

[GitHub] asfgit commented on issue #2226: Anonymous IP TO Implementation

2018-05-04 Thread GitBox
asfgit commented on issue #2226: Anonymous IP TO Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2226#issuecomment-386685510 Refer to this link for build results (access rights to CI server needed):

[GitHub] elsloo commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-04 Thread GitBox
elsloo commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-38663 Hey @Vijay-1 and @mitchell852 – where are we on getting these changes into the PR?

[GitHub] asfgit commented on issue #2108: create roles crud endpoints in golang

2018-05-04 Thread GitBox
asfgit commented on issue #2108: create roles crud endpoints in golang URL: https://github.com/apache/incubator-trafficcontrol/pull/2108#issuecomment-386698482 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-04 Thread GitBox
mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-386650324 @Vijay-1 and I discussed these routes but I don't think the changes have been made yet to support them: GET

[GitHub] mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-04 Thread GitBox
mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-386650324 @Vijay-1 and I discussed/agreed on these API routes but I don't think the changes have been made yet to support

[GitHub] mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-04 Thread GitBox
mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-386650324 @Vijay-1 and I discussed/agreed on these API routes but I don't think the changes have been made yet to support

[GitHub] mitchell852 closed pull request #2225: Fix Traffic Ops Golang CRConfig to match Perl's magic LogRequestHeaders parameter handling

2018-05-04 Thread GitBox
mitchell852 closed pull request #2225: Fix Traffic Ops Golang CRConfig to match Perl's magic LogRequestHeaders parameter handling URL: https://github.com/apache/incubator-trafficcontrol/pull/2225 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it

[GitHub] PeterRyder opened a new pull request #2226: Anonymous IP TO Implementation

2018-05-04 Thread GitBox
PeterRyder opened a new pull request #2226: Anonymous IP TO Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2226 @rivasj New PR for Anonymous IP Traffic Ops implementation after rebase. Refer to

[GitHub] mitchell852 commented on issue #1979: DO NOT MERGE - Junk commit to test prbuilder

2018-05-04 Thread GitBox
mitchell852 commented on issue #1979: DO NOT MERGE - Junk commit to test prbuilder URL: https://github.com/apache/incubator-trafficcontrol/pull/1979#issuecomment-386648792 @jhg03a - can this be closed? This is an automated

[GitHub] PeterRyder commented on issue #1643: Anonymous IP TO Implementation

2018-05-04 Thread GitBox
PeterRyder commented on issue #1643: Anonymous IP TO Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/1643#issuecomment-38980 Closing - refer to new PR https://github.com/apache/incubator-trafficcontrol/pull/2226 for 2.3.x rebase

[GitHub] mitchell852 commented on a change in pull request #2222: Add TO Go 1.1 routes

2018-05-04 Thread GitBox
mitchell852 commented on a change in pull request #: Add TO Go 1.1 routes URL: https://github.com/apache/incubator-trafficcontrol/pull/#discussion_r186128347 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -77,106 +77,107 @@ func Routes(d ServerData)

[GitHub] mitchell852 commented on a change in pull request #2222: Add TO Go 1.1 routes

2018-05-04 Thread GitBox
mitchell852 commented on a change in pull request #: Add TO Go 1.1 routes URL: https://github.com/apache/incubator-trafficcontrol/pull/#discussion_r186127827 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -77,106 +77,107 @@ func Routes(d ServerData)

[GitHub] asfgit commented on issue #2229: Add Traffic Ops Golang deliveryservicesregexes

2018-05-04 Thread GitBox
asfgit commented on issue #2229: Add Traffic Ops Golang deliveryservicesregexes URL: https://github.com/apache/incubator-trafficcontrol/pull/2229#issuecomment-386760085 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2229: Add Traffic Ops Golang deliveryservicesregexes

2018-05-04 Thread GitBox
asfgit commented on issue #2229: Add Traffic Ops Golang deliveryservicesregexes URL: https://github.com/apache/incubator-trafficcontrol/pull/2229#issuecomment-386769915 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2229: Add Traffic Ops Golang deliveryservicesregexes

2018-05-04 Thread GitBox
asfgit commented on issue #2229: Add Traffic Ops Golang deliveryservicesregexes URL: https://github.com/apache/incubator-trafficcontrol/pull/2229#issuecomment-386766718 Refer to this link for build results (access rights to CI server needed):

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-05-07 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-386972753 @mitchell852 @elsloo Will upload the changes in couple of days. Caught up in some thing else.

[GitHub] mitchell852 opened a new pull request #2227: ensures that the state changes when the url query param changes for c…

2018-05-04 Thread GitBox
mitchell852 opened a new pull request #2227: ensures that the state changes when the url query param changes for c… URL: https://github.com/apache/incubator-trafficcontrol/pull/2227 …ustom menu items fixes a bug in TP's custom menu found by @guzzijason

[GitHub] rob05c commented on issue #2229: Add Traffic Ops Golang deliveryservicesregexes

2018-05-04 Thread GitBox
rob05c commented on issue #2229: Add Traffic Ops Golang deliveryservicesregexes URL: https://github.com/apache/incubator-trafficcontrol/pull/2229#issuecomment-386754750 This is ready, in terms of functionality. I'm not sure how to write API tests for it though. Everything is ID based,

[GitHub] rob05c commented on a change in pull request #2222: Add TO Go 1.1 routes

2018-05-04 Thread GitBox
rob05c commented on a change in pull request #: Add TO Go 1.1 routes URL: https://github.com/apache/incubator-trafficcontrol/pull/#discussion_r186188020 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -77,106 +77,107 @@ func Routes(d ServerData)

[GitHub] rob05c commented on a change in pull request #2222: Add TO Go 1.1 routes

2018-05-04 Thread GitBox
rob05c commented on a change in pull request #: Add TO Go 1.1 routes URL: https://github.com/apache/incubator-trafficcontrol/pull/#discussion_r186187979 ## File path: traffic_ops/traffic_ops_golang/routes.go ## @@ -77,106 +77,107 @@ func Routes(d ServerData)

[GitHub] asfgit commented on issue #2222: Add TO Go 1.1 routes

2018-05-04 Thread GitBox
asfgit commented on issue #: Add TO Go 1.1 routes URL: https://github.com/apache/incubator-trafficcontrol/pull/#issuecomment-386733440 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1520/

[GitHub] ajschmidt opened a new pull request #2228: Added the Get API in Go for the DeliveryserviceServers endpoint

2018-05-04 Thread GitBox
ajschmidt opened a new pull request #2228: Added the Get API in Go for the DeliveryserviceServers endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2228 This is the first of 6 methods in the API. More to come.

[GitHub] asfgit commented on issue #2227: ensures that the state changes when the url query param changes for c…

2018-05-04 Thread GitBox
asfgit commented on issue #2227: ensures that the state changes when the url query param changes for c… URL: https://github.com/apache/incubator-trafficcontrol/pull/2227#issuecomment-386714004 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2228: Added the Get API in Go for the DeliveryserviceServers endpoint

2018-05-04 Thread GitBox
asfgit commented on issue #2228: Added the Get API in Go for the DeliveryserviceServers endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2228#issuecomment-386743973 Can one of the admins verify this patch?

[GitHub] asfgit commented on issue #2108: create roles crud endpoints in golang

2018-05-04 Thread GitBox
asfgit commented on issue #2108: create roles crud endpoints in golang URL: https://github.com/apache/incubator-trafficcontrol/pull/2108#issuecomment-386753582 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed pull request #2222: Add TO Go 1.1 routes

2018-05-04 Thread GitBox
mitchell852 closed pull request #: Add TO Go 1.1 routes URL: https://github.com/apache/incubator-trafficcontrol/pull/ This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] asfgit commented on issue #2124: Add TO Go deliveryservices routes

2018-05-04 Thread GitBox
asfgit commented on issue #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-386742179 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2228: Added the Get API in Go for the DeliveryserviceServers endpoint

2018-05-04 Thread GitBox
asfgit commented on issue #2228: Added the Get API in Go for the DeliveryserviceServers endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2228#issuecomment-386743625 Can one of the admins verify this patch?

[GitHub] rob05c opened a new pull request #2229: Add Traffic Ops Golang deliveryservicesregexes

2018-05-04 Thread GitBox
rob05c opened a new pull request #2229: Add Traffic Ops Golang deliveryservicesregexes URL: https://github.com/apache/incubator-trafficcontrol/pull/2229 This is an automated message from the Apache Git Service. To respond

[GitHub] rob05c closed pull request #2227: ensures that the state changes when the url query param changes for c…

2018-05-04 Thread GitBox
rob05c closed pull request #2227: ensures that the state changes when the url query param changes for c… URL: https://github.com/apache/incubator-trafficcontrol/pull/2227 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] rawlinp commented on a change in pull request #2124: Add TO Go deliveryservices routes

2018-05-04 Thread GitBox
rawlinp commented on a change in pull request #2124: Add TO Go deliveryservices routes URL: https://github.com/apache/incubator-trafficcontrol/pull/2124#discussion_r186202885 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv12.go ## @@ -0,0

[GitHub] rob05c commented on issue #2229: Add Traffic Ops Golang deliveryservicesregexes

2018-05-04 Thread GitBox
rob05c commented on issue #2229: Add Traffic Ops Golang deliveryservicesregexes URL: https://github.com/apache/incubator-trafficcontrol/pull/2229#issuecomment-386754750 This is ready, in terms of functionality. I'm not sure how to write API tests for it though. Everything is ID based,

[GitHub] rob05c opened a new issue #2230: Portal Servers page is missing Traffic Monitor link

2018-05-07 Thread GitBox
rob05c opened a new issue #2230: Portal Servers page is missing Traffic Monitor link URL: https://github.com/apache/incubator-trafficcontrol/issues/2230 The old UI has a button on Traffic Monitor Server rows, that links to that monitor's FQDN (web GUI). The Portal has no easy way

[GitHub] DylanVolz commented on issue #2243: Routes.go file should include type capture groups to enforce route parameter types

2018-05-08 Thread GitBox
DylanVolz commented on issue #2243: Routes.go file should include type capture groups to enforce route parameter types URL: https://github.com/apache/incubator-trafficcontrol/issues/2243#issuecomment-387503745 The thought was to make the routing less order reliant. While it won't fully

[GitHub] asfgit commented on issue #2242: uses info api to allow ORT to retain compatibility with older builds

2018-05-08 Thread GitBox
asfgit commented on issue #2242: uses info api to allow ORT to retain compatibility with older builds URL: https://github.com/apache/incubator-trafficcontrol/pull/2242#issuecomment-387505797 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2226: Anonymous IP TO Implementation

2018-05-08 Thread GitBox
asfgit commented on issue #2226: Anonymous IP TO Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2226#issuecomment-387525048 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c closed pull request #2244: prevents failure of ssl files and processing of remap config params

2018-05-08 Thread GitBox
rob05c closed pull request #2244: prevents failure of ssl files and processing of remap config params URL: https://github.com/apache/incubator-trafficcontrol/pull/2244 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] rivasj opened a new pull request #2245: Anonymous IP TP Implementation

2018-05-08 Thread GitBox
rivasj opened a new pull request #2245: Anonymous IP TP Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2245 Updated Traffic Portal UI to have Anonymous Blocking field for HTTP delivery services. Associated with PRs #2226 and #2184

[GitHub] asfgit commented on issue #2246: Add HitCount and FreshFor

2018-05-08 Thread GitBox
asfgit commented on issue #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#issuecomment-387557088 Refer to this link for build results (access rights to CI server needed):

[GitHub] dg4prez opened a new pull request #2244: prevents failure of ssl files and processing of remap config params

2018-05-08 Thread GitBox
dg4prez opened a new pull request #2244: prevents failure of ssl files and processing of remap config params URL: https://github.com/apache/incubator-trafficcontrol/pull/2244 https://github.com/apache/incubator-trafficcontrol/commit/425be777fb485fea43a10392496dd92493988065 introduced a

[GitHub] asfgit commented on issue #2247: Add an Origin API

2018-05-08 Thread GitBox
asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-387561384 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1543/

[GitHub] rawlinp opened a new pull request #2247: Add an Origin API

2018-05-08 Thread GitBox
rawlinp opened a new pull request #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247 Origins are associated to delivery services and contain all origin-specific data that is currently being used in the deliveryservice (org_server_fqdn) and server

[GitHub] asfgit commented on issue #2245: Anonymous IP TP Implementation

2018-05-08 Thread GitBox
asfgit commented on issue #2245: Anonymous IP TP Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2245#issuecomment-387555978 Can one of the admins verify this patch? This is an automated message

[GitHub] smalenfant closed pull request #2242: uses info api to allow ORT to retain compatibility with older builds

2018-05-08 Thread GitBox
smalenfant closed pull request #2242: uses info api to allow ORT to retain compatibility with older builds URL: https://github.com/apache/incubator-trafficcontrol/pull/2242 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] asfgit commented on issue #2245: Anonymous IP TP Implementation

2018-05-08 Thread GitBox
asfgit commented on issue #2245: Anonymous IP TP Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2245#issuecomment-387556108 Can one of the admins verify this patch? This is an automated message

[GitHub] knutsel opened a new pull request #2246: Add HitCount and FreshFor

2018-05-08 Thread GitBox
knutsel opened a new pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246 to the cache inspector. Aslo moved quite a bit of generic stuff from remap/rules.go to web/util.go.

[GitHub] asfgit commented on issue #2226: Anonymous IP TO Implementation

2018-05-08 Thread GitBox
asfgit commented on issue #2226: Anonymous IP TO Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2226#issuecomment-387521025 Refer to this link for build results (access rights to CI server needed):

[GitHub] jhg03a opened a new issue #2263: Improve TO Client SDK Documentation

2018-05-13 Thread GitBox
jhg03a opened a new issue #2263: Improve TO Client SDK Documentation URL: https://github.com/apache/incubator-trafficcontrol/issues/2263 We currently have TO SDK available in both Golang and Python, but they are difficult to get started with/locate. We should add some basic documentation

[GitHub] asfgit commented on issue #2264: Add more documentation about the TO Client SDK

2018-05-13 Thread GitBox
asfgit commented on issue #2264: Add more documentation about the TO Client SDK URL: https://github.com/apache/incubator-trafficcontrol/pull/2264#issuecomment-388692933 Can one of the admins verify this patch? This is an

[GitHub] jhg03a opened a new pull request #2264: Add more documentation about the TO Client SDK

2018-05-13 Thread GitBox
jhg03a opened a new pull request #2264: Add more documentation about the TO Client SDK URL: https://github.com/apache/incubator-trafficcontrol/pull/2264 This adds some basic placeholder documentation and a simple sample Golang client app.

[GitHub] asfgit commented on issue #2264: Add more documentation about the TO Client SDK

2018-05-13 Thread GitBox
asfgit commented on issue #2264: Add more documentation about the TO Client SDK URL: https://github.com/apache/incubator-trafficcontrol/pull/2264#issuecomment-388693550 Can one of the admins verify this patch? This is an

[GitHub] dewrich closed pull request #2264: Add more documentation about the TO Client Libraries

2018-05-14 Thread GitBox
dewrich closed pull request #2264: Add more documentation about the TO Client Libraries URL: https://github.com/apache/incubator-trafficcontrol/pull/2264 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jhg03a opened a new pull request #2265: Fix formatting in Native Client Doc Readme

2018-05-14 Thread GitBox
jhg03a opened a new pull request #2265: Fix formatting in Native Client Doc Readme URL: https://github.com/apache/incubator-trafficcontrol/pull/2265 An error was found in the formatting of the new TO native client documentation after it was merged, so this addresses that error.

[GitHub] rob05c commented on issue #2249: Add CRConfig DS Modified fields

2018-05-14 Thread GitBox
rob05c commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/incubator-trafficcontrol/pull/2249#issuecomment-387898955 I'll also note, I strongly dislike SQL triggers, for myriad reasons; but in this case, it's the best, safest way to guarantee the

[GitHub] dewrich closed pull request #2265: Fix formatting in Native Client Doc Readme

2018-05-14 Thread GitBox
dewrich closed pull request #2265: Fix formatting in Native Client Doc Readme URL: https://github.com/apache/incubator-trafficcontrol/pull/2265 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] mitchell852 commented on a change in pull request #2245: Anonymous IP TP Implementation

2018-05-14 Thread GitBox
mitchell852 commented on a change in pull request #2245: Anonymous IP TP Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2245#discussion_r188078542 ## File path: traffic_portal/app/src/traffic_portal_properties.json ## @@ -252,10 +260,10 @@

[GitHub] rivasj commented on a change in pull request #2245: Anonymous IP TP Implementation

2018-05-14 Thread GitBox
rivasj commented on a change in pull request #2245: Anonymous IP TP Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2245#discussion_r188082216 ## File path: traffic_portal/app/src/traffic_portal_properties.json ## @@ -252,10 +260,10 @@

[GitHub] mitchell852 opened a new pull request #2268: adds ?orderby=name when fetching cache groups

2018-05-14 Thread GitBox
mitchell852 opened a new pull request #2268: adds ?orderby=name when fetching cache groups URL: https://github.com/apache/incubator-trafficcontrol/pull/2268 fixes #2260 This is an automated message from the Apache Git

[GitHub] asfgit commented on issue #2268: adds ?orderby=name when fetching cache groups

2018-05-14 Thread GitBox
asfgit commented on issue #2268: adds ?orderby=name when fetching cache groups URL: https://github.com/apache/incubator-trafficcontrol/pull/2268#issuecomment-388958125 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2149: TO and TODB in docker front-to-back

2018-05-14 Thread GitBox
asfgit commented on issue #2149: TO and TODB in docker front-to-back URL: https://github.com/apache/incubator-trafficcontrol/pull/2149#issuecomment-388961224 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 closed pull request #2245: Anonymous IP TP Implementation

2018-05-14 Thread GitBox
mitchell852 closed pull request #2245: Anonymous IP TP Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2245 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] smalenfant commented on issue #2015: Traffic Portal: clone parameters (feature request)

2018-05-14 Thread GitBox
smalenfant commented on issue #2015: Traffic Portal: clone parameters (feature request) URL: https://github.com/apache/incubator-trafficcontrol/issues/2015#issuecomment-388902247 @mitchell852 Just have this exact problem at the moment. You have to take notes and find your parameter when

[GitHub] mitchell852 opened a new issue #2267: POST api/$version/deliveryservices/sslkeys/add should validate ssl keys

2018-05-14 Thread GitBox
mitchell852 opened a new issue #2267: POST api/$version/deliveryservices/sslkeys/add should validate ssl keys URL: https://github.com/apache/incubator-trafficcontrol/issues/2267 There is currently no validation when adding/uploading ssl keys to a delivery service. This can put Traffic

[GitHub] asfgit commented on issue #2266: ORT: Removing unnecessary errors

2018-05-14 Thread GitBox
asfgit commented on issue #2266: ORT: Removing unnecessary errors URL: https://github.com/apache/incubator-trafficcontrol/pull/2266#issuecomment-388890184 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2226: Anonymous IP TO Implementation

2018-05-14 Thread GitBox
asfgit commented on issue #2226: Anonymous IP TO Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2226#issuecomment-38869 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2149: TO and TODB in docker front-to-back

2018-05-14 Thread GitBox
asfgit commented on issue #2149: TO and TODB in docker front-to-back URL: https://github.com/apache/incubator-trafficcontrol/pull/2149#issuecomment-388893389 Refer to this link for build results (access rights to CI server needed):

[GitHub] smalenfant opened a new pull request #2266: ORT: Removing unnecessary errors

2018-05-14 Thread GitBox
smalenfant opened a new pull request #2266: ORT: Removing unnecessary errors URL: https://github.com/apache/incubator-trafficcontrol/pull/2266 The diff was not showing the source/destination due to improper handling of notes. Fix will... - Prevent wrong ERROR printing on the

[GitHub] elsloo closed pull request #2184: Anonymous IP TR Implementation

2018-05-14 Thread GitBox
elsloo closed pull request #2184: Anonymous IP TR Implementation URL: https://github.com/apache/incubator-trafficcontrol/pull/2184 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] smalenfant commented on issue #1666: TP - option to create and link parameter in profile page

2018-05-14 Thread GitBox
smalenfant commented on issue #1666: TP - option to create and link parameter in profile page URL: https://github.com/apache/incubator-trafficcontrol/issues/1666#issuecomment-388902711 Here's how I see this that could work... - From the profile view (you selected a profile). -

[GitHub] asfgit commented on issue #2149: TO and TODB in docker front-to-back

2018-05-14 Thread GitBox
asfgit commented on issue #2149: TO and TODB in docker front-to-back URL: https://github.com/apache/incubator-trafficcontrol/pull/2149#issuecomment-388912284 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2149: TO and TODB in docker front-to-back

2018-05-14 Thread GitBox
asfgit commented on issue #2149: TO and TODB in docker front-to-back URL: https://github.com/apache/incubator-trafficcontrol/pull/2149#issuecomment-388915771 Refer to this link for build results (access rights to CI server needed):

[GitHub] dg4prez closed pull request #2266: ORT: Removing unnecessary errors

2018-05-14 Thread GitBox
dg4prez closed pull request #2266: ORT: Removing unnecessary errors URL: https://github.com/apache/incubator-trafficcontrol/pull/2266 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] mitchell852 commented on issue #2267: POST api/$version/deliveryservices/sslkeys/add should validate ssl keys

2018-05-14 Thread GitBox
mitchell852 commented on issue #2267: POST api/$version/deliveryservices/sslkeys/add should validate ssl keys URL: https://github.com/apache/incubator-trafficcontrol/issues/2267#issuecomment-388916262 Also, maybe TR should not blow up if/when it encounters a bad cert but hopefully with

[GitHub] dangogh closed pull request #2268: adds ?orderby=name when fetching cache groups

2018-05-14 Thread GitBox
dangogh closed pull request #2268: adds ?orderby=name when fetching cache groups URL: https://github.com/apache/incubator-trafficcontrol/pull/2268 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] dangogh closed issue #2260: TP: sorting of cache group list is no longer alphanumeric

2018-05-14 Thread GitBox
dangogh closed issue #2260: TP: sorting of cache group list is no longer alphanumeric URL: https://github.com/apache/incubator-trafficcontrol/issues/2260 This is an automated message from the Apache Git Service. To respond

[GitHub] dangogh commented on issue #2149: TO and TODB in docker front-to-back

2018-05-14 Thread GitBox
dangogh commented on issue #2149: TO and TODB in docker front-to-back URL: https://github.com/apache/incubator-trafficcontrol/pull/2149#issuecomment-388970888 closing for now while still WIP This is an automated message from

[GitHub] asfgit commented on issue #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
asfgit commented on issue #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#issuecomment-388975850 Can one of the admins verify this patch? This is an

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188118026 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2246: Add HitCount and FreshFor

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2246: Add HitCount and FreshFor URL: https://github.com/apache/incubator-trafficcontrol/pull/2246#discussion_r188119204 ## File path: grove/plugin/http_cacheinspector.go ## @@ -169,16 +170,17 @@ func cacheinspect(icfg

[GitHub] asfgit commented on issue #2270: Add TO Go Servers Details endpoint

2018-05-14 Thread GitBox
asfgit commented on issue #2270: Add TO Go Servers Details endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2270#issuecomment-388989863 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2247: Add an Origin API

2018-05-14 Thread GitBox
asfgit commented on issue #2247: Add an Origin API URL: https://github.com/apache/incubator-trafficcontrol/pull/2247#issuecomment-388997317 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1569/

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114503 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188112182 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114777 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188110995 ## File path: lib/go-tc/deliveryservice_servers.go ## @@ -19,21 +21,40 @@ import "time"

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188115772 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188110723 ## File path: infrastructure/docker/traffic_ops/Dockerfile_psql ## @@ -0,0 +1,20 @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188112817 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114096 ## File path: infrastructure/docker/traffic_ops/dbInit.sh ## @@ -0,0 +1,8 @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188117012 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114875 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188115110 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188112552 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188113319 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188111222 ## File path: lib/go-tc/deliveryservice_servers.go ## @@ -78,3 +99,65 @@ type DssServer

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188114148 ## File path: infrastructure/docker/traffic_ops/Dockerfile_psql ## @@ -0,0 +1,20 @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188111742 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go

2018-05-14 Thread GitBox
rob05c commented on a change in pull request #2269: Deliveryservice_Server API conversion to Go URL: https://github.com/apache/incubator-trafficcontrol/pull/2269#discussion_r188115566 ## File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go ## @@

[GitHub] asfgit commented on issue #2149: TO and TODB in docker front-to-back

2018-05-14 Thread GitBox
asfgit commented on issue #2149: TO and TODB in docker front-to-back URL: https://github.com/apache/incubator-trafficcontrol/pull/2149#issuecomment-388982939 Refer to this link for build results (access rights to CI server needed):

  1   2   3   4   5   6   7   8   9   10   >