Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
@PSUdaemon @dneuman64 @rob05c @dewrich Hey guys, in case you haven't seen
it yet, [they just released the pre-alpha version of the native dependency tool
for
Go](https
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
@dneuman64 These last changes should encapsulate what we talked about:
* Remove `urfave/cli` dependency by having a config object that can be
"autopopu
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
ð¤¦ââï¸ Pulled in upstream but didn't update vendor, so here we go
again...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
@dneuman64 I had to bring in several more dependencies into vendor to cover
those dependencies' dependencies (not to beat a dead horse, but tooling can
really help here). I won't
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r96073860
--- Diff: traffic_stats/build/traffic_stats.spec ---
@@ -75,8 +75,8 @@
godir=src/github.com/apache/incubator-trafficcontrol/traffic_stats
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95489426
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
I've had good experiences with `godep` for the most part, and I'd be happy
to bring it in (I can maybe throw in a Makefile to make some of the local
commands easier). That said
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95610649
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95499191
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
@rob05c Yeah, that's what I'm talking about. That functionality (and since
greater versions of go1.6, the tooling as well) supports the _existence_ of a
vendor folder, and knows
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95096542
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95096773
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95096692
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
Hey @PSUdaemon, thanks for the review. I'm more than happy to make changes
to the PR to conform to project standards. I think the question of dependencies
is a good one, both
GitHub user sbogacz opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167
Refactor and cleanup the influxdb_tools in traffic_stats
1) Cleanup lint warnings in the traffic_stats/influxdb_tools go files
(mostly due to repeated constant strings), and fix
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95100395
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95100626
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
I did look at the licenses beforehand, but I'll admit I don't know the most
about the technicalities of Open Source licenses. I'll go back and get the
tests to use the stdlib
18 matches
Mail list logo
