[GitHub] dangogh commented on issue #1861: implement servers CRUD endpoints in go

2018-03-06 Thread GitBox 
dangogh commented on issue #1861: implement servers CRUD endpoints in go
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1861#issuecomment-371022035
 
 
   Can you add api tests in `testing/api`?  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh commented on issue #1861: implement servers CRUD endpoints in go

2018-02-11 Thread GitBox 
dangogh commented on issue #1861: implement servers CRUD endpoints in go
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1861#issuecomment-364820496
 
 
   np -- I'll help :-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh commented on issue #1861: implement servers CRUD endpoints in go

2018-02-11 Thread GitBox 
dangogh commented on issue #1861: implement servers CRUD endpoints in go
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1861#issuecomment-364786698
 
 
   Error checking needs to be improved..   With Perl version on PUT,  I removed 
the "cdn" and "cdnId" entries and got this message:
```
   to-put servers/600 s.json
   {"alerts":[{"level":"error","text":"CDN of profile does not match Server 
CDN"}]}
   ```
   With this version,  I got this:
   ```
   to-put servers/600 s.json
   {"alerts":[{"text":"database access error","level":"error"}]}
   ```
   and this from the log:
   ```
   ERROR: db_helpers.go:118: failed to parse unique constraint from pq error: 
pq: insert or update on table "server" violates foreign key constraint "fk_cdn2"
   ERROR: alerts.go:81: 2018-02-11T20:41:24.952109304Z: 96.118.253.249:56124 
[database access error]
   96.118.253.249:56124 - admin [11/Feb/2018:20:41:24 +] "PUT 
/api/1.3/servers/600 HTTP/1.1" 500 61 94 "curl/7.43.0"
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services