[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side

2017-08-16 Thread limited
Github user limited commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/754 There's 2 fields- a boolean and a list of the keys to use from the cookie. The list is expected to be short, just a few entries long. No session metadata is stored in the TO DB.

[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side

2017-08-16 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/754 and was this discussed on the ML because i'm a pretty hard -1 on more DS table columns (if possible). That table is way out of control imo (50+ columns already?). @knutsel did i

[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side

2017-08-16 Thread dewrich
Github user dewrich commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/754 @limited @weifensh Is there a way we can prevent adding yet another field to the Delivery Service Table? If we are tracking sessions, maybe that should be a separate table (with th

[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side

2017-08-15 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/754 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/14/ --- If your projec

[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side

2017-08-14 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/754 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side

2017-08-05 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/754 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side

2017-08-05 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/754 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side

2017-07-26 Thread weifensh
Github user weifensh commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/754 @limited Thanks Eric. The white spaces and tabs are mostly introduced by perltidy. Some are caused by reformatting with the new code. And others are because it appears some origina

[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side

2017-07-26 Thread limited
Github user limited commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/754 Thanks John- The diff is quite large, mostly because of whitespace and some formatting related changes. Can you please try to minimize the size of the diff to just ch