mitchell852 commented on a change in pull request #2094: removes path params
from ds request endpoints per api guidelines
URL:
https://github.com/apache/incubator-trafficcontrol/pull/2094#discussion_r179878201
##########
File path: traffic_ops/traffic_ops_golang/routes.go
##########
@@ -108,19 +108,17 @@ func Routes(d ServerData) ([]Route, http.Handler, error)
{
//Delivery service requests
{1.3, http.MethodGet, `deliveryservice_requests/?(\.json)?$`,
api.ReadHandler(dsrequest.GetRefType(), d.DB), auth.PrivLevelReadOnly,
Authenticated, nil},
Review comment:
notice how all the CRUD endpoints look exactly the same now with the
exception of the GET which supports .json. If we don't support .json, then we
could potentially collapse 4 routes down into 1 and call the appropriate
generic handler based on the HTTP verb (get, put, post, delete)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
