[GitHub] rob05c commented on issue #2098: Add TO deleted columns
rob05c commented on issue #2098: Add TO deleted columns URL: https://github.com/apache/incubator-trafficcontrol/pull/2098#issuecomment-380216014 "Undelete" isn't part of the current API or UI. Again, the intention is to maintain backwards-compatibility with the existing API, and add as few new features as necessary to solve the Snapshot-Queue problem. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rob05c commented on issue #2098: Add TO deleted columns
rob05c commented on issue #2098: Add TO deleted columns URL: https://github.com/apache/incubator-trafficcontrol/pull/2098#issuecomment-380151949 @dewrich Self-Service, and in particular solving the Snapshot-Queue Automation problem, is likely going to be a multi-year project. I don't think a single big PR is going to be feasible. It'll constantly have merge conflicts, and likely rebase errors that lose new features and bug fixes. For a project this big, making small atomic changes, one at a time, while keeping the existing API functional, is likely the only way to get it done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rob05c commented on issue #2098: Add TO deleted columns
rob05c commented on issue #2098: Add TO deleted columns URL: https://github.com/apache/incubator-trafficcontrol/pull/2098#issuecomment-380150199 @dewrich You're right, we do need the date. But we have that in the `last_updated` column, so `deleted` can just be a boolean where we also select `last_updated` to get the deletion date. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rob05c commented on issue #2098: Add TO deleted columns
rob05c commented on issue #2098: Add TO deleted columns URL: https://github.com/apache/incubator-trafficcontrol/pull/2098#issuecomment-379871646 @limited We have some designs, specifically around the Snapshot-Queue automation problem, which is what this is "prepping" for. But they're pretty complex. In a nutshell, the plan is to use timestamp history to solve the Snapshot-Queue problem. So, for this PR, `deleted` columns become necessary to preserve previous state (for caches or routers that haven't got the latest yet), while still indicating an object (server/ds/etc) now no longer exists. There's a talk scheduled at the TC Summit in a few weeks, we were hoping to have the talk where people can ask questions and have concerns addressed more efficiently, and then post it to the mailing list, to hopefully reduce the back-and-forth and misunderstandings from discussing something so complex via email. This "prep" stuff I was hoping to get started in the next couple weeks will all be backwards-compatible. The entire thing is, it doesn't change the existing API (though it does eventually add a few new endpoints). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rob05c commented on issue #2098: Add TO deleted columns
rob05c commented on issue #2098: Add TO deleted columns URL: https://github.com/apache/incubator-trafficcontrol/pull/2098#issuecomment-379837295 Tested both up and down SQL commands on a TO database, works. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
