[GitHub] rob05c commented on issue #2249: Add CRConfig DS Modified fields
rob05c commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/incubator-trafficcontrol/pull/2249#issuecomment-387898955 I'll also note, I strongly dislike SQL triggers, for myriad reasons; but in this case, it's the best, safest way to guarantee the fields are updated properly, and proof it against future forgetting to do it. It will be critical that the DS timestamp is updated, once the Router is changed to reload only modified DSes via these `anyModified` fields. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rob05c commented on issue #2249: Add CRConfig DS Modified fields
rob05c commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/incubator-trafficcontrol/pull/2249#issuecomment-387898955 I'll also note, I strongly dislike SQL triggers, for myriad reasons; but in this case, it's the best, safest way to guarantee the fields are updated properly, and proof it against future future forgetting to do it. It will be critical that the DS timestamp is updated, once the Router is changed to reload only modified DSes via the `anyModified` fields. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rob05c commented on issue #2249: Add CRConfig DS Modified fields
rob05c commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/incubator-trafficcontrol/pull/2249#issuecomment-387898955 I'll also note, I strongly dislike SQL triggers; but in this case, it's the best, safest way to guarantee the fields are updated properly, and future-proof it against code in the future forgetting to do it. It will be critical that the DS timestamp is updated, once the Router is changed to reload only modified DSes via the `anyModified` fields. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rob05c commented on issue #2249: Add CRConfig DS Modified fields
rob05c commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/incubator-trafficcontrol/pull/2249#issuecomment-387898955 I'll also note, I strongly dislike SQL triggers, for myriad reasons; but in this case, it's the best, safest way to guarantee the fields are updated properly, and proof it against future future forgetting to do it. It will be critical that the DS timestamp is updated, once the Router is changed to reload only modified DSes via these `anyModified` fields. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rob05c commented on issue #2249: Add CRConfig DS Modified fields
rob05c commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/incubator-trafficcontrol/pull/2249#issuecomment-387898955 I'll also note, I strongly dislike SQL triggers, for myriad reasons; but in this case, it's the best, safest way to guarantee the fields are updated properly, and future-proof it against code in the future forgetting to do it. It will be critical that the DS timestamp is updated, once the Router is changed to reload only modified DSes via the `anyModified` fields. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rob05c commented on issue #2249: Add CRConfig DS Modified fields
rob05c commented on issue #2249: Add CRConfig DS Modified fields URL: https://github.com/apache/incubator-trafficcontrol/pull/2249#issuecomment-387898530 Tested the database migrations to succeed and roll back, tested the database triggers to properly update the modified fields when dependent table entries are deleted, tested the CRConfig timestamps with real data to update properly when any dependent field is updated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
