[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135920#comment-16135920
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/837


> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133480#comment-16133480
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user hbeatty commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/837
  
@dangogh merged - please close


> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133479#comment-16133479
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/837
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/97/



> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133469#comment-16133469
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/837
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/59/



> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133466#comment-16133466
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/837
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/57/



> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133456#comment-16133456
 ] 

ASF GitHub Bot commented on TC-374:
---

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/837

[BACKPORT] [TC-374] eliminate TO orphan processes

(cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
orphan-procs-2.1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/837.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #837


commit 2970c85d0b0f6ff6c7d0836e8ff4fa54029501b8
Author: Dan Kirkwood 
Date:   2017-08-16T18:31:28Z

handle orphan processes in TO

(cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f)




> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133453#comment-16133453
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/836
  
opened against master -- closing


> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133454#comment-16133454
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/836


> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133451#comment-16133451
 ] 

ASF GitHub Bot commented on TC-374:
---

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/836

[BACKPORT] [TC-374] eliminate TO orphan processes



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
orphan-procs-2.1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #836


commit a376bc0670ea137ceef7da7a6e26394600fc77b3
Author: Jeremy Mitchell 
Date:   2017-08-09T14:58:10Z

fixes number validation on global max settings

(cherry picked from commit 8603bc83dfe9b667af54f9101028740940bac86f)

commit 66fa1115f3d27b83fc4cbf9f91878b46e86680b1
Author: hbeatty 
Date:   2017-08-10T13:08:04Z

closes #792

commit aecd573437e6d765ee315e29bb4a98f51f348e19
Author: Steve Malenfant 
Date:   2017-08-11T18:52:32Z

Remove reference to table "public" and match description

commit 7058a550ded22a5f94370ac9a5c1fd8b89707362
Author: Steve Malenfant 
Date:   2017-08-11T19:13:13Z

Removed ".go" typo

commit 6aae6f47ff60b8723a54ccf7370e6b684aed3c36
Author: hbeatty 
Date:   2017-08-15T16:56:53Z

This closes #797

commit fa18c96ed18d4caabf743cd1ee2a02e008a7
Author: Jeremy Mitchell 
Date:   2017-08-15T16:44:56Z

accounts for missing dependency that centos 7.3 doesn't provide. when 
centos 7.4 is available this dependency will be provided with the distro.

(cherry picked from commit 15901255c1847800bbd871e33c757017ec23f74f)

commit 53345aa1bf09fa90938c04c2134b543cd0aff434
Author: Steve Malenfant 
Date:   2017-08-17T14:14:39Z

This closes #821

commit 1c9ce9eb9ce167d50d945aad085231f68f112bcf
Author: Jeremy Mitchell 
Date:   2017-08-15T02:13:51Z

adds back missing tenants menu item

(cherry picked from commit a049589041ece51d6069cae09e2fdf23440d4a91)

commit a581e82a6eeb15a30b12b8a17dd2eb78cfca6bf7
Author: hbeatty 
Date:   2017-08-17T17:02:53Z

This closes #814
This closes #TC-519

commit 4350faf99e5df17bc29ec3807885f3ec02ffbe48
Author: nir-sopher 
Date:   2017-08-13T16:01:38Z

ssl_keys - tenancy checks

(cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6)

commit bad7062d2b8444e67da7d37dc373ee43cb7f1f0a
Author: hbeatty 
Date:   2017-08-18T18:35:01Z

This closes #835
TC-533 #close fixed by GH PR #835

commit 2970c85d0b0f6ff6c7d0836e8ff4fa54029501b8
Author: Dan Kirkwood 
Date:   2017-08-16T18:31:28Z

handle orphan processes in TO

(cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f)




> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133256#comment-16133256
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/823


> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129266#comment-16129266
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/823
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/82/



> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129264#comment-16129264
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/823
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/44/



> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129263#comment-16129263
 ] 

ASF GitHub Bot commented on TC-374:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/823
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/42/



> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129253#comment-16129253
 ] 

ASF GitHub Bot commented on TC-374:
---

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/823

[TC-374] handle orphan processes in TO init.d

allows stop and/or restart of TO in case of orphaned workers.

To test,  find a worker process (`ps -ef | grep 
/opt/traffic_ops/app/scripts/cdn`) and kill with a HUP signal:   `kill -HUP 
5432`

You should see a new process with a parent of 1:

```
$ ps -ef | awk '/^trafops/&&/\/script\/cdn/ { if ($3 == 1) {print} }'
trafops  29881 1  0 18:05 ?00:00:00 
/opt/traffic_ops/app/script/cdn```
```

Restart:
```sudo systemctl restart traffic_ops```

The only `/script/cdn` process with a parent of 1 should be owned by `root` 
and should be the one in the `/var/run/traffic_ops.pid` file.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol TC-374

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/823.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #823


commit c65c2e7d0125e14917341bd8ac05edcb559b5599
Author: Dan Kirkwood 
Date:   2017-08-16T18:31:28Z

handle orphan processes in TO




> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes

2017-08-09 Thread Dylan Volz (JIRA)

[ 
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120083#comment-16120083
 ] 

Dylan Volz commented on TC-374:
---

This means the processes were orphaned, and adopted by root (as expected) but 
then never waited on (reaped). I happened to have just read about a similar 
issue docker can have here: 
https://blog.phusion.nl/2015/01/20/docker-and-the-pid-1-zombie-reaping-problem/ 
that describes it in detail and perhaps a similar solution can be applied in 
our start up script.

> `systemctl stop traffic_ops` does not kill all processes
> 
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>  Labels: systemctl
> Fix For: 2.1.0
>
>
> not sure why it gets in this state,  but traffic_ops processes sometimes get 
> in a state where the parent process is the root (1) for many of the 
> script/cdn workers.   The init.d script doesn't stop them because they don't 
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example:   on my test VM,  if I run this,  I see multiple parent processes:
> {quote}
>  ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}'  | sort -u
>  1
>  22713
>  29306
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)