[GitHub] trafficserver pull request #795: TS-4655: Remove SessionAccept pointer from ...

2016-07-14 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/795 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #797: TS-4659: Log format errors on startup.

2016-07-14 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/797 The original code used the enum value as a sentinel so it would never have hit the empty strings at the ends of the lists. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #796: TS-4660: Improve remap.config error message...

2016-07-14 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/796 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #797: TS-4659: Log format errors on startup.

2016-07-14 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/797 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #829: TS-4703: Adds an API call to retrieve transaction ...

2016-07-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/829 I'm quite negative on this API and the underlying "get_protocol_string()". I think that it doesn't serve the right purpose and is not general enough to be useful. See dev@ for more

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72732562 --- Diff: lib/atscppapi/examples/experimental/websocket/WebSocket.cc --- @@ -0,0 +1,132 @@ +#include "WebSocket.hh" +

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72732670 --- Diff: lib/atscppapi/examples/experimental/websocket/WSBuffer.cc --- @@ -0,0 +1,206 @@ +#include "WSBuffer.hh" --- End diff --

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72732703 --- Diff: lib/atscppapi/examples/Makefile.am --- @@ -15,6 +15,8 @@ # See the License for the specific language governing permissions

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72732848 --- Diff: lib/atscppapi/examples/experimental/websocket/WSBuffer.cc --- @@ -0,0 +1,206 @@ +#include "WSBuffer.hh" + +#include &quo

[GitHub] trafficserver pull request #824: TS-4699: Adds a C++ API WebSocket example

2016-07-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/824#discussion_r72732656 --- Diff: lib/atscppapi/examples/experimental/websocket/WSBuffer.hh --- @@ -0,0 +1,69 @@ +#ifndef WS_BUFFER_HH_HEADERS_ +#define

[GitHub] trafficserver issue #823: TS-4697: free MIOBuffer if fails on ipallow check.

2016-07-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/823 We don't really use event return values outside of event handlers, so if we return a failure from ``accept()``, it should just be a ``bool``. Originally, the contract

[GitHub] trafficserver issue #833: TS-3474: HTTP/2 Server Push support

2016-07-31 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/833 There are quite a few changes that seem unrelated to the proposed API. Can you separate those out into an independent PR? --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #847: TS-4729: Remove dead assaignment in Http2St...

2016-08-10 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/847#discussion_r74273262 --- Diff: proxy/http2/Http2Stream.cc --- @@ -509,7 +509,7 @@ Http2Stream::update_write_request(IOBufferReader *buf_reader, int64_t write_len

[GitHub] trafficserver issue #847: TS-4729: Remove dead assaignment in Http2Stream

2016-08-10 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/847 Also, there's a typo in the commit subject line ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #829: TS-4703: Adds an API call to retrieve transaction ...

2016-08-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/829 @amc we should have this discussion on ``@dev``. My main objection to this API is that is makes promises it doesn't (maybe can't) keep. It just tells you whether this is HTTP/1 or HTTP/2

[GitHub] trafficserver issue #838: TS-4713: Remove obsolete TSFetchClientProtoStackSe...

2016-08-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/838 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #835: TS-4709: Separate LogFilter expression pars...

2016-08-02 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/835 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #835: TS-4709: Separate LogFilter expression pars...

2016-08-01 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/835 TS-4709: Separate LogFilter expression parsing. Separate LogFilter expression parsing from the configuration file parser so that it can be tested and reused in other contexts. You can

[GitHub] trafficserver pull request #850: TS-4728: Remove invalid LogHost assertion.

2016-08-10 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/850 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #851: TS-4548: Convert custom log config file to ...

2016-08-10 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/851 TS-4548: Convert custom log config file to Lua Initial implementation of ``logging.config`` which is a Lua configuration file for custom logs. You can merge this pull request into a Git

[GitHub] trafficserver issue #851: TS-4548: Convert custom log config file to Lua

2016-08-10 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/851 Ping @shukitchan @zwoop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #842: TS-4717: Http2 stack explosion.

2016-08-09 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/842#discussion_r74106638 --- Diff: proxy/http2/Http2ClientSession.h --- @@ -243,6 +243,12 @@ class Http2ClientSession : public ProxyClientSession return "h

[GitHub] trafficserver issue #850: TS-4728: Remove invalid LogHost assertion.

2016-08-10 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/850 Ping @zwoop @pbchou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #853: TS-4619: intermediate chain loading can miss certi...

2016-08-12 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/853 Is ``SSL_add1_chain_cert`` different from ``SSL_add0_chain_cert``? This looks good to me 👍 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #823: TS-4697: free MIOBuffer if fails on ipallow check.

2016-08-12 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/823 Thanks @oknet. Can you please document the invariants for ``accept`` in ``I_SessionAccept.h``? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #864: TS-4751: Prune cached headers before merging the u...

2016-08-12 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/864 I guess the key phrase from RFC 2616 is ``if the field-value might differ from that sent in any previous response``. What happens if the origin had an ``Expires`` but not it doesn't? RFC7232

[GitHub] trafficserver pull request #851: TS-4548: Convert custom log config file to ...

2016-08-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/851#discussion_r74668539 --- Diff: proxy/logging/LogConfig.cc --- @@ -493,14 +494,21 @@ void LogConfig::setup_log_objects() { Debug("log", "c

[GitHub] trafficserver pull request #850: TS-4728: Remove invalid LogHost assertion.

2016-08-10 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/850 TS-4728: Remove invalid LogHost assertion. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/4728 Alternatively

[GitHub] trafficserver pull request #822: TS-4698: Adds an API call to identify WebSo...

2016-08-11 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/822#discussion_r74539863 --- Diff: proxy/InkAPI.cc --- @@ -4982,6 +4982,15 @@ TSHttpTxnInfoIntGet(TSHttpTxn txnp, TSHttpTxnInfoKey key, TSMgmtInt *value) return

[GitHub] trafficserver pull request #822: TS-4698: Adds an API call to identify WebSo...

2016-08-11 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/822#discussion_r74539983 --- Diff: doc/developer-guide/api/functions/TSHttpTxnIsWebsocket.en.rst --- @@ -0,0 +1,45 @@ +.. Licensed to the Apache Software Foundation (ASF

[GitHub] trafficserver issue #824: TS-4699: Adds a C++ API WebSocket example

2016-08-11 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/824 @ogoodman Would you mind moving the C++ API changes to the other PR so we can keep API changes together? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request #864: TS-4751: Prune cached headers before mergin...

2016-08-12 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/864 TS-4751: Prune cached headers before merging the updated response. When we update a cached response with a new server response, make sure to delete any cache-related beforehand

[GitHub] trafficserver issue #864: TS-4751: Prune cached headers before merging the u...

2016-08-12 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/864 Ping @zwoop @bryancall @SolidWallOfCode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #794: TS-4652: ASAN issue in logging with gcc 6.1.1

2016-07-13 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/794 This looks alright to me. The one part I'm a little concerned about is the changes to the dirent allocation, but I don't think there will be any problems with too-long filenames in practice

[GitHub] trafficserver pull request #795: TS-4655: Remove SessionAccept pointer from ...

2016-07-13 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/795 TS-4655: Remove SessionAccept pointer from SSLNetVConnection. SSLNetVConnection never uses the SessionAccept pointer, so remove it and the associated setter and getter. Tidy up

[GitHub] trafficserver pull request #791: TS-4649: Minor style improvement to the log...

2016-07-12 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/791 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #796: TS-4660: Improve remap.config error messages.

2016-07-14 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/796 @zwoop This is a stopgap to fix the error messages until we can do the larger refactoring in TS-4660. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request #796: TS-4660: Improve remap.config error message...

2016-07-14 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/796 TS-4660: Improve remap.config error messages. Improve some of the confusion about which error message buffer to use in remap_parse_config_bti. The final message is now constructed

[GitHub] trafficserver pull request #797: TS-4659: Log format errors on startup.

2016-07-14 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/797 TS-4659: Log format errors on startup. Remove extraneous field name constants which accidentally match with strstr(). You can merge this pull request into a Git repository by running

[GitHub] trafficserver issue #817: TS-4667 Uses the WKS in the gzip plugin

2016-07-20 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/817 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #773: TS-4622 Use port from SRV response when connecting...

2016-07-20 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/773 👍 This looks good to me and I think it will be safe w/ "TsHttpTxnServerAddrSet()". --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request #816: TS-4639: Add git to Vagrant builds

2016-07-20 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/816 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #818: TS-4683 Adds better error handling on config probl...

2016-07-21 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/818 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #819: TS-4311 Removes support for SPDY completely

2016-07-20 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/819#discussion_r71649770 --- Diff: lib/ts/ink_config.h.in --- @@ -127,5 +127,6 @@ #define TS_BUILD_CANONICAL_HOST "@host@"

[GitHub] trafficserver pull request #818: TS-4683 Adds better error handling on confi...

2016-07-20 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/818#discussion_r71650582 --- Diff: lib/ts/tests.cc --- @@ -19,7 +19,7 @@ limitations under the License. */ -#include "ts/TestBox.h" +#i

[GitHub] trafficserver issue #815: TS-4680: thread safe initialization in TS*DirGet()...

2016-07-20 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/815 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

2016-07-17 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/805 This follows the pattern of the other APIs, but I notice the initialization is not thread safe. Shall we file a separate JIRA for that? --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

2016-07-17 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/805 The documentation for this API family is in {{doc/developer-guide/api/functions/TSInstallDirGet.en.rst}}, Just mention the new API there. --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-17 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/802 I don't think this change is correct. It seems to me that the invariant is that ``server_session`` and ``server_entry`` should be NULL or non-NULL together. So if we call

[GitHub] trafficserver pull request #801: TS-4664: Fix crash by unifying event handle...

2016-07-16 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/801#discussion_r71073791 --- Diff: proxy/ProxyClientSession.cc --- @@ -142,7 +141,9 @@ ProxyClientSession::do_api_callout(TSHttpHookID id) this->api_current = N

[GitHub] trafficserver pull request #801: TS-4664: Fix crash by unifying event handle...

2016-07-16 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/801#discussion_r71073823 --- Diff: proxy/ProxyClientSession.cc --- @@ -142,7 +141,9 @@ ProxyClientSession::do_api_callout(TSHttpHookID id) this->api_current = N

[GitHub] trafficserver pull request #807: TS-4672: Add lifecycle events to hook-trace...

2016-07-18 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/807 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #808: TS-4673: Remove unused HttpSM::historical_a...

2016-07-18 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/808 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-18 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/801 Ah. The invariant is that you are not supposed to be getting IO events during session hook processing. Maybe the fact that this is happening is the root cause of the bug? This change

[GitHub] trafficserver pull request #801: TS-4664: Fix crash by unifying event handle...

2016-07-18 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/801#discussion_r71265855 --- Diff: configure.ac --- @@ -49,7 +49,7 @@ AM_INIT_AUTOMAKE([-Wall -Werror -Wno-portability tar-ustar foreign no-installinf AM_MAINTAINER_MODE

[GitHub] trafficserver issue #807: TS-4672: Add lifecycle events to hook-trace exampl...

2016-07-18 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/807 Yeh lets have a new JIRA for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #779: TS-4627: support TSRemapOSResponse in ts_lua

2016-07-18 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/779 Loods good 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #815: TS-4680: thread safe initialization in TS*DirGet()...

2016-07-19 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/815 File scope would not work since these initializers can depend on librecords. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #815: TS-4680: thread safe initialization in TS*DirGet()...

2016-07-19 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/815 These are globals, so I don't think that thread local storage makes sense here. There are 2 reasonable approaches to this. The most straight-forward is to use static initialization

[GitHub] trafficserver pull request #813: TS-4652 Fixes log field initialization, pre...

2016-07-19 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/813#discussion_r71446015 --- Diff: proxy/logging/Log.cc --- @@ -925,6 +925,7 @@ Log::init(int flags) if (config_flags & STANDALONE_COLLATOR) { co

[GitHub] trafficserver issue #813: TS-4652 Fixes log field initialization, previously...

2016-07-19 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/813 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #799: TS-4647: Fix incorrect buf reference

2016-07-15 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #779: TS-4627: support TSRemapOSResponse in ts_lu...

2016-07-18 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/779#discussion_r71102843 --- Diff: plugins/experimental/ts_lua/ts_lua_http.c --- @@ -29,8 +29,36 @@ typedef enum { TS_LUA_CACHE_LOOKUP_SKIPPED

[GitHub] trafficserver pull request #779: TS-4627: support TSRemapOSResponse in ts_lu...

2016-07-18 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/779#discussion_r71103080 --- Diff: plugins/experimental/ts_lua/ts_lua.c --- @@ -117,7 +117,7 @@ TSRemapDeleteInstance(void *ih) } TSRemapStatus

[GitHub] trafficserver pull request #808: TS-4673: Remove unused HttpSM::historical_a...

2016-07-18 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/808 TS-4673: Remove unused HttpSM::historical_action. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/4873

[GitHub] trafficserver pull request #779: TS-4627: support TSRemapOSResponse in ts_lu...

2016-07-18 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/779#discussion_r71103039 --- Diff: plugins/experimental/ts_lua/ts_lua.c --- @@ -140,13 +141,15 @@ TSRemapDoRemap(void *ih, TSHttpTxn rh, TSRemapRequestInfo *rri

[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-17 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/801 I had to re-read this code to refresh my memory on how this works. I think that the invariant that the ``ProxyClientSession`` requires is that the API hooks are the first and last operations

[GitHub] trafficserver pull request #807: TS-4672: Add lifecycle events to hook-trace...

2016-07-18 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/807 TS-4672: Add lifecycle events to hook-trace example plugin. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/4672

[GitHub] trafficserver pull request #840: TS-4711: Remove proxy.config.log.custom_log...

2016-08-04 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/840 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #829: TS-4703: Adds an API call to retrieve trans...

2016-08-05 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/829#discussion_r73769255 --- Diff: proxy/InkAPI.cc --- @@ -4655,6 +4655,15 @@ TSHttpTxnClientReqGet(TSHttpTxn txnp, TSMBuffer *bufp, TSMLoc *obj) return TS_ERROR

[GitHub] trafficserver issue #823: TS-4697: free MIOBuffer if fails on ipallow check.

2016-08-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/823 You don't need to hold a mutex to free anything. In all of these cases, the callee is supposed to consume both parameters. For consistency, we should not sometime consume only some

[GitHub] trafficserver pull request #840: TS-4711: Remove proxy.config.log.custom_log...

2016-08-03 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/840 TS-4711: Remove proxy.config.log.custom_logs_enabled. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/TS-4711

[GitHub] trafficserver pull request #869: TS-4716: Install manpages in $PREFIX/share/...

2016-08-16 Thread jpeach
GitHub user jpeach reopened a pull request: https://github.com/apache/trafficserver/pull/869 TS-4716: Install manpages in $PREFIX/share/man. Update various layouts to default to installing manpages into $PREFIX/share/man. Some layouts already did this, but it is probably

[GitHub] trafficserver pull request #870: TS-4548: Fix LogHost leak on config error p...

2016-08-16 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/870 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #869: TS-4716: Install manpages in $PREFIX/share/...

2016-08-15 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/869 TS-4716: Install manpages in $PREFIX/share/man. Update various layouts to default to installing manpages into $PREFIX/share/man. Some layouts already did this, but it is probably worth

[GitHub] trafficserver pull request #851: TS-4548: Convert custom log config file to ...

2016-08-15 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/851 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #851: TS-4548: Convert custom log config file to Lua

2016-08-15 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/851 @zwoop @shukitchan I removed the configuration option and added a little Lua stack helper class I had been thinking about. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #859: TS-4724: Modified ts_lua plugin to provide ...

2016-08-15 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/859#discussion_r74778707 --- Diff: proxy/InkAPI.cc --- @@ -2208,6 +2208,20 @@ TSUrlPathSet(TSMBuffer bufp, TSMLoc obj, const char *value, int length) return URLPartSet

[GitHub] trafficserver issue #864: TS-4751: Prune cached headers before merging the u...

2016-08-15 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/864 The problem we hit was we had a bogus Age (12000) header cached. Since the origin was no linger sending an Age header, the object would never become fresh. One common case could

[GitHub] trafficserver issue #849: TS-4729: Fix dead assignment.

2016-08-15 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/849 This change looks consistent with the nearby handling of ``is_done`` 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #859: TS-4724: Modified ts_lua plugin to provide ...

2016-08-15 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/859#discussion_r74778730 --- Diff: proxy/InkAPI.cc --- @@ -2208,6 +2208,20 @@ TSUrlPathSet(TSMBuffer bufp, TSMLoc obj, const char *value, int length) return URLPartSet

[GitHub] trafficserver issue #858: TS-4184 Makes -std=c++11 mandatory

2016-08-15 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/858 👍 We could also just pass the ``mandatory`` flag to the checking macro, which would produce better warning messages, but this is OK too. Consider adding a check for the minimum

[GitHub] trafficserver issue #864: TS-4751: Prune cached headers before merging the u...

2016-08-15 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/864 AFAICT the RFC7232 language was introduced in HTTPbis ticket [#406](https://tools.ietf.org/wg/httpbis/trac/ticket/406). It seems like this change was regarded as a bug fix to RFC2616 rather

[GitHub] trafficserver issue #1423: traffic_ctl status is broken

2017-02-08 Thread jpeach
GitHub user jpeach opened an issue: https://github.com/apache/trafficserver/issues/1423 traffic_ctl status is broken ``` # /opt/ats/bin/traffic_ctl config status traffic_ctl: [11] Invalid parameters passed into function call. ``` --- If your project is set

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

2017-01-30 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1357 Whilst the configuration of SSL keys and certificates is a bit unfortunate, I think that it is important to be consistent. Separately, you have to define the base directory

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102379397 --- Diff: proxy/http/remap/RemapConfig.cc --- @@ -778,7 +778,7 @@ remap_load_plugin(const char **argv, int argc, url_mapping *mp, char *errbuf

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102379269 --- Diff: proxy/Plugin.cc --- @@ -231,8 +231,8 @@ plugin_init(bool validateOnly) if (INIT_ONCE) { api_init

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102378986 --- Diff: proxy/Main.cc --- @@ -38,6 +38,8 @@ #include "ts/ink_syslog.h" #include "ts/hugepages.h" +#inclu

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102378964 --- Diff: proxy/Main.cc --- @@ -38,6 +38,8 @@ #include "ts/ink_syslog.h" #include "ts/hugepages.h" +#inclu

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102379416 --- Diff: proxy/Plugin.cc --- @@ -231,8 +231,8 @@ plugin_init(bool validateOnly) if (INIT_ONCE) { api_init

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102378936 --- Diff: proxy/FetchSM.cc --- @@ -26,6 +26,7 @@ #include #include "HTTP.h" #include "PluginVC.h" +#include

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-21 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1460#discussion_r102378869 --- Diff: lib/wccp/Makefile.am --- @@ -20,8 +20,8 @@ include $(top_srcdir)/build/tidy.mk AM_CPPFLAGS = \ - -I$(abs_top_srcdir

[GitHub] trafficserver issue #1425: PROXY_CONFIG_CONFIG_DIR doesn't change sysconfig ...

2017-02-21 Thread jpeach
Github user jpeach closed the issue at: https://github.com/apache/trafficserver/issues/1425 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1468: Allow overriding proxy.config.config_dir.

2017-02-21 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

2017-02-21 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1479 I don't get how this is better than the previous version. That was purely compile time and this compares the global `typeid` constants at runtime. It doesn't seem better. --- If your

[GitHub] trafficserver issue #1423: traffic_ctl status is broken

2017-02-21 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/issues/1423 ``` [jpeach@sk1 trafficserver]$ /opt/ats/bin/traffic_ctl config status Apache Traffic Server - traffic_server - 7.2.0 - (build # 022120 on Feb 21 2017 at 20:56:37) Started at Tue

[GitHub] trafficserver issue #1423: traffic_ctl status is broken

2017-02-21 Thread jpeach
Github user jpeach closed the issue at: https://github.com/apache/trafficserver/issues/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1469: Introduce a Result error object.

2017-02-20 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1461: Changes debug builds with Intel to just -g

2017-02-20 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/1461 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1475: ASAN issue in traffic_manager metrics Lua binding...

2017-02-20 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/issues/1475 Check the verbose log to ensure that Lua was excluded from ASAN correctly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

  1   2   3   4   5   6   7   8   >