Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1028
@gtenev This looks good. Can you please squash the branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1028
@jpeach we ok to land this now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1028
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/731/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1028
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/835/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1028
@jpeach, renamed "offline" flag to "online", added some reasoning about why
the flag was necessary in the last commit description.
---
If your project is set up for it, you can reply to this
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1028
@gtenev If i'm reading your patch correctly, it adds the ``offline`` flag
such that disks are marked bad *and* offline. That doesn't sound like what you
intended from the description above.
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1028
@jpeach, appreciate your feedback!
It felt that "disk being offline" (might be an operator's decision) and
"disk being bad" (number of IO errors reached a threshold) are better kept
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1028
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/713/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1028
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/817/ for details.
---
If your project is set up for it, you can reply to this email and have your
