Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/1109
Closing the PR-- as we'll take care of this in Jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1109
Not a complete solution as Thomas noted, but may be sufficient to keep
6.2.x moving. Alternatively, we may just want to back port TS-4590.
---
If your project is set up for it, you can
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1109
Is this a duplicate PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1109
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/927/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1109
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1035/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/1109
After doing some more looking, the `m_deleted` flag is just marking the
VConn as "we should delete this" and that combined with `m_deletable` lets it
reschedule the delete in the future
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/1109
@shinrich I did look a bit more into the other backport-- and it seems that
the outcome would be quite similar-- as the `handle_event` method is still
using this `m_deleted` flag to
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/1109
@shinrich we could-- this patch seems to be working fine for our build
though-- seemed like a less intrusive patch to an LTS release.
---
If your project is set up for it, you can reply
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1109
Would it be easier to just back port the fix from TS-4590? I'm a bit
concerned about the proposed fix in this PR. I don't think is correctly using
the m_deleted/m_deletable parameters?
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1109
Does the `destroy` method also clear `m_deletable`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/1109
@jpeach TBH I'm not sure, I figured the PR would be good at least to get
the CI to run on it-- I'm not sure what our official process is now that we do
github for *some* things
---
If
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1109
Are we using github for backports? I thought the process was to mark the
JIRA?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1109
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/901/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1109
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1009/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1109
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1007/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1109
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/899/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
16 matches
Mail list logo
