[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-26 Thread jacksontj
Github user jacksontj commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
Closing the PR-- as we'll take care of this in Jira.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-18 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
Not a complete solution as Thomas noted, but may be sufficient to keep 
6.2.x moving.  Alternatively, we may just want to back port TS-4590.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-17 Thread zwoop
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
Is this a duplicate PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-17 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/927/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-17 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1035/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-17 Thread jacksontj
Github user jacksontj commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
After doing some more looking, the `m_deleted` flag is just marking the 
VConn as "we should delete this" and that combined with `m_deletable` lets it 
reschedule the delete in the future when it can. The fundamental problem I'm 
seeing is it is double freed under some conditions-- since all events trigger a 
delete. This is fixed in 7.x with  TS-4590 -- so I've updated this PR to 
workaround the issue in a simpler mechanism that more closely mirrors what is 
happening on 7.x


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-17 Thread jacksontj
Github user jacksontj commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
@shinrich I did look a bit more into the other backport-- and it seems that 
the outcome would be quite similar-- as the `handle_event` method is still 
using this `m_deleted` flag to determine if the struct was deleted, so it ends 
up being a superset of this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-14 Thread jacksontj
Github user jacksontj commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
@shinrich we could-- this patch seems to be working fine for our build 
though-- seemed like a less intrusive patch to an LTS release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-14 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
Would it be easier to just back port the fix from TS-4590?  I'm a bit 
concerned about the proposed fix in this PR.  I don't think is correctly using 
the m_deleted/m_deletable parameters?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-14 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
Does the `destroy` method also clear `m_deletable`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-14 Thread jacksontj
Github user jacksontj commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
@jpeach TBH I'm not sure, I figured the PR would be good at least to get 
the CI to run on it-- I'm not sure what our official process is now that we do 
github for *some* things


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-14 Thread jpeach
Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
Are we using github for backports? I thought the process was to mark the 
JIRA?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-13 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/901/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-13 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1009/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-13 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1007/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-13 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1109
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/899/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---